voltage-high and voltage-low keys replacement on power transformers

[francois.lacombe]

Dear maintainers,

In #15367, deprecation of special voltages keys voltage-high and voltage-low has been forgotten.
It follows the approval of ​https://wiki.openstreetmap.org/wiki/Proposed_features/Transformer_extension_proposal in 2017

Wiki is up to date with dedicated pages for replacement guidelines.

• ​https://wiki.openstreetmap.org/wiki/Key:voltage-high
• ​https://wiki.openstreetmap.org/wiki/Key:voltage-low

Is it possible to raise a warning, at least like voltage=* in combination with power=transformer/transformer please?

By default, voltage-high and voltage-low are respectively replaceable by voltage:primary and voltage:secondary
When combined to transformer=generator, voltage-high and voltage-low are respectively replaceable by voltage:secondary and voltage:primary (primary and secondary are inverted).

Keep up with good work :)

[gaben]

Isn't the primary winding is on the input, while the rest is on the output side, regardless of the voltage level? So changing keys require a bit of luck to get it right.

[francois.lacombe]

That's right.
It's mostly correct to state voltage-high = voltage:primary, except in power plants with transformers used to step up voltage to transmit power over the grid (where voltage-low is the primary voltage).

transformer=generator can be added on step up transformer and then JOSM could adapt its fix recommendation.

JOSM could also propose to add transformer=generator when primary < secondary voltage, if available.

[francois.lacombe]

​https://wiki.openstreetmap.org/wiki/Key:voltage:primary

A good side improvement would be to warn about some voltage:primary (and respectively voltage:secondary, voltage:tertiary...) usage on following situations:

• Used on areas, relations (wiki states it's only valid on nodes)
• Missing required transformer=* key.

As to avoid situations like this one, using voltage:primary to distinguish substation's voltages.
​https://www.openstreetmap.org/way/88462768

[Klumbumbus]

In 18535/josm:

see #21836 - Add some power/voltage validation rules:

• voltage:primary/secondary/tertiary without transformer
• voltage:primary/secondary/tertiary on a way
• voltage:primary/secondary/tertiary not in correct number format (should be in volts with no units/delimiter/spaces)
• don't warn about unknown numeric values of voltage:primary/secondary/tertiary
• transformer together with voltage on nodes
• voltage:secondary is lower than voltage:primary on transformer=generator
• deprecate voltage-high and voltage-low in favor of voltage:primary/secondary

[Klumbumbus]

Replying to francois.lacombe:

JOSM could also propose to add transformer=generator when primary < secondary voltage, if available.

I think this is a bit risky, since the voltage:primary/secondary tags could be mixed up. Instead I added a warning when voltage:secondary is lower than voltage:primary on transformer=generator. Is the other way round also a safe error? i.e. voltage:secondary is higher than voltage:primary on a transformer=* which is not a transformer=generator

[Klumbumbus]

Do you think something important was missing in r18535?

[Klumbumbus]

In 18536/josm:

see #21836 - Improve error messages (use only key instead of whole tag)

[skyper]

22.07 was released but trac is not up to date.

[taylor.smock]

Replying to skyper:

22.07 was released but trac is not up to date.

Yep. I think either stoecker/Don-vip have to close the milestone. Or someone else with the appropriate privileges. I did the release, but I cannot close milestones ( as specified on wiki:DevelopersGuide/Releasing ). It looks like someone has gone in and marked the milestone completed on the appropriate day.

[Klumbumbus]

Replying to taylor.smock:

It looks like someone has gone in and marked the milestone completed on the appropriate day.

Yes that was me. Yesterday I marked it as completed on 2022-08-02.

[francois.lacombe]

Hi all

That sounds really good to me, thank you!

Replying to Klumbumbus:

I think this is a bit risky, since the voltage:primary/secondary tags could be mixed up. Instead I added a warning when voltage:secondary is lower than voltage:primary on transformer=generator. Is the other way round also a safe error? i.e. voltage:secondary is higher than voltage:primary on a transformer=* which is not a transformer=generator

That's indeed relevant and safer.
Let this warning raises with "Primary < secondary MAY be wrong when no transformer=generator" instead of proposing transformer=generator.

[francois.lacombe]

Depending on team planning and need to release quickly 22.08, it would be great to deal with #20421 that introduce changes on transformers presets as well.

I'll try to comit something in coming days if I manage to free a couple of hours.

[Klumbumbus]

I think this ticket is done. Further improvements see #20421 and #22200.

[francois.lacombe]

Agreed, thank you everyone :)

[skyper]

See #22639