Changeset 18535 in josm

Timestamp:

2022-08-13T18:39:30+02:00 (2 years ago)

Author:

Klumbumbus

Message:

see #21836 - Add some power/voltage validation rules:

• voltage:primary/secondary/tertiary without transformer
• voltage:primary/secondary/tertiary on a way
• voltage:primary/secondary/tertiary not in correct number format (should be in volts with no units/delimiter/spaces)
• don't warn about unknown numeric values of voltage:primary/secondary/tertiary
• transformer together with voltage on nodes
• voltage:secondary is lower than voltage:primary on transformer=generator
• deprecate voltage-high and voltage-low in favor of voltage:primary/secondary

Location:

trunk/resources/data/validator

Files:

• combinations.mapcss (modified) (3 diffs)
• deprecated.mapcss (modified) (1 diff)
• geometry.mapcss (modified) (1 diff)
• ignoretags.cfg (modified) (2 diffs)
• numeric.mapcss (modified) (1 diff)

trunk/resources/data/validator/combinations.mapcss

@@ -11 +11 @@
 
 /* {0.key} without {1.key} (warning level) */
+node[voltage:primary           ][!transformer],
+node[voltage:secondary         ][!transformer],
+node[voltage:tertiary          ][!transformer],
 way[junction                   ][!highway][junction!=yes][!area:highway],
 way[living_street              ][!highway],
@@ -346 +349 @@
 }
 
-/* {0.key} together with {1.key}, #18267, #17630, #17604 */
+/* {0.key} together with {1.key}, #18267, #17630, #17604, #21836 */
+node[transformer][voltage],
 node[marker][cover],
 node[marker][voltage],
@@ -1061 +1065 @@
   assertNoMatch: "relation piste:type=nordic piste:grooming=classic";
 }
+
+/* #21836 */
+*[voltage:primary][voltage:secondary][transformer=generator][tag("voltage:secondary")<tag("voltage:primary")] {
+  throwWarning: tr("{0} is lower than {1} on {2}.", "{1.key}", "{0.key}", "{2.tag}");
+  group: tr("suspicious tag combination");
+}

trunk/resources/data/validator/deprecated.mapcss

@@ -2382 +2382 @@
 }
 
+/* #21836 */
+*[voltage-high],
+*[voltage-low] {
+  throwWarning: tr("{0} is deprecated", "{0.key}");
+  suggestAlternative: "voltage:primary";
+  suggestAlternative: "voltage:secondary";
+  group: tr("deprecated tagging");
+}
+
 /* When tags are deprecated they should be added to ignoretags.cfg too. */

trunk/resources/data/validator/geometry.mapcss

@@ -96 +96 @@
 
 /* {0} on a way, should be a node */
+way[voltage:primary],
+way[voltage:secondary],
+way[voltage:tertiary],
 way[line_attachment],
 way[line_management],

trunk/resources/data/validator/ignoretags.cfg

@@ -136 +136 @@
 E:distance
 E:voltage
+E:voltage:primary
+E:voltage:secondary
+E:voltage:tertiary
 E:amperage
 E:generator:output:electricity
@@ -727 +730 @@
 K:surface=decoturf
 K:school=entrance
+E:voltage-high
+E:voltage-low
 ;
 ; Tags not yet decided (to remove from this section when added or moved up when deprecated) 

trunk/resources/data/validator/numeric.mapcss

@@ -373 +373 @@
 }
 
-way[voltage][voltage =~ /(.*[A-Za-z].*)|.*,.*|.*( ).*/] {
+way[voltage][voltage =~ /(.*[A-Za-z].*)|.*,.*|.*( ).*/],
+way[voltage:primary][voltage:primary =~ /(.*[A-Za-z].*)|.*,.*|.*( ).*/],
+way[voltage:secondary][voltage:secondary =~ /(.*[A-Za-z].*)|.*,.*|.*( ).*/],
+way[voltage:tertiary][voltage:tertiary =~ /(.*[A-Za-z].*)|.*,.*|.*( ).*/] {
   throwWarning: tr("voltage should be in volts with no units/delimiter/spaces");
   assertMatch: "way voltage=medium";