Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#23995 closed defect (fixed)

When changing street name of way with multiple sections, plugin causes JOSM freeze when saying yes to Highway name modification.

Reported by: SekeRob Owned by: taylor.smock
Priority: normal Milestone:
Component: Plugin highwayNameModification Version:
Keywords: template_report Cc: SekeRob

Description

What steps will reproduce the problem?

When changing a name of a street that has more sections, a frame pops up asking "Should we download additional information for Highway Name Modification? (WARNING: May be buggy!)" When saying yes, JOSM freezes. When saying no, the name change is applied to the selected segment and the second step takes off asking on *each* related address to modify (the addr:street tag). Then the process concludes after doing all. It seems oblivious of the fact that there's still segments with old name.

When saying yes and the freeze occurring, then recovering, the names of all the street segments did get the change passed, not always, but in most times. (not remembering always to say no, hence the experience gained of that happening.). The process has to be repeated for each street segment, the question of the address adjusting is not repeated, presuming it checks the addr:street value prior.

Also when instead choosing all street segment with old name and enter new name, JOSM freezes complete too on OK. No pop ups. Do not remember if names do get adjusted in the recovered data file.

Noted is this is actually really good given the many street name corrections needing applying.
Author, or last modifier is tsmock per GitHub.

What is the expected result?

Adjust all street segments with same old name and continue to amend related addresses.

What happens instead?

JOSM freeze.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-10-30 15:48:42 +0100 (Wed, 30 Oct 2024)
Revision:19253
Build-Date:2024-10-31 02:30:30
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19253 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 22H2 (19045)
Memory Usage: 4084 MB / 4084 MB (2531 MB allocated, but free)
Java version: 21.0.3+9-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djava.security.manager=allow]
Dataset consistency test: No problems found

Plugins:
+ Elevation (0.10.1)
+ ElevationProfile (36349)
+ HouseNumberTaggingTool (36344)
+ KartaView (545)
+ MakeParallel (v1.1.0)
+ Mapillary (1778)
+ MicrosoftStreetside (36326)
+ OpeningHoursEditor (36344)
+ RoadSigns (36343)
+ apache-commons (36349)
+ buildings_tools (36344)
+ contourmerge (v0.2.1)
+ easypresets (1623509627)
+ graphview (36344)
+ gridify (1718663815)
+ highwaynamemodification (v0.0.12)
+ javafx (36325)
+ libphonenumber (8.13.49)
+ measurement (36350)
+ notesolver (0.5.0)
+ phonenumber (1.1.1)
+ pt_assistant (637)
+ reltoolbox (36344)
+ reverter (36343)
+ routing (36343)
+ scripting (v0.3.1)
+ tageditor (36350)
+ terracer (36344)
+ todo (139)
+ turnlanes (36344)
+ turnlanes-tagging (1727811971)
+ turnrestrictions (36344)
+ undelete (36349)
+ utilsplugin2 (36350)

Tagging presets:
+ <josm.pref>/EasyPresets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/TurnLanes&zip=1
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Potlach2_access&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&zip=1
- https://josm.openstreetmap.de/josmfile?page=Rules/IncompleteObjectWarnings&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_en&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://gitlab.com/cartocite/josm-style-traffic-signs-orientation/-/raw/main/traffic_sign_orientation_style.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OC.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://raw.githubusercontent.com/OpenNauticalChart/josm/master/european-waterways-classification-style/CEMT-style.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Waterways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NewParkingFeatures&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Last errors/warnings:
- 10826.338 E: Error header: The relation with the id 12994730 has already been deleted
- 10826.441 W: Relation 'multipolygon ("Parrocchia Santa Caterina da Siena", 0 members)' is already deleted. Skipping object in upload.
- 10827.135 E: Error header: The way with the id 764349730 has already been deleted
- 10827.238 W: Way '‎Viale Vittorio Pepe‎ (0 nodes)‌' is already deleted. Skipping object in upload.
- 12428.264 E: Error header: Version mismatch: Provided 2, server had: 3 of Node 7544055644
- 12428.891 E: Conflicts detected - <html>Uploading <strong>failed</strong> because the server has a newer version of one<br>of your nodes, ways, or relations.<br>The conflict is caused by the <strong>node</strong> with id <strong>7,544,055,644</strong>,<br>the server has version 3, your version is 2.<br><br>Click <strong>Synchronize node 7,544,055,644 only</strong> to synchronize the conflicting primitive only.<br>Click <strong>Synchronize entire dataset</strong> to synchronize the entire local dataset with the server.<br>Click <strong>Cancel</strong> to abort and continue editing.<br></html>
- 12454.063 W: Conflicts detected - <html>There was 1 conflict detected.</html>
- 12492.074 E: Error header: Version mismatch: Provided 8, server had: 9 of Way 28144817
- 12492.835 E: Conflicts detected - <html>Uploading <strong>failed</strong> because the server has a newer version of one<br>of your nodes, ways, or relations.<br>The conflict is caused by the <strong>way</strong> with id <strong>28,144,817</strong>,<br>the server has version 9, your version is 8.<br><br>Click <strong>Synchronize way 28,144,817 only</strong> to synchronize the conflicting primitive only.<br>Click <strong>Synchronize entire dataset</strong> to synchronize the entire local dataset with the server.<br>Click <strong>Cancel</strong> to abort and continue editing.<br></html>
- 12496.055 W: Conflicts detected - <html>There was 1 conflict detected.</html>

Attachments (0)

Change History (17)

comment:1 by skyper, 3 months ago

Owner: changed from team to taylor.smock

comment:2 by taylor.smock, 3 months ago

@SekeRob: Thanks for actually using the plugin and giving feedback; I had kind of assumed that the community either had found no problems or (more likely IMO) didn't find the plugin very useful.

I'll see if I can break out some time to debug this issue and otherwise fix issues with the plugin.

comment:3 by SekeRob, 3 months ago

Substantially more useful, to me, than the mappaint style I read about last week which colours all objects with same name, helping to identify which objects need their name or addr:street tag fixed. Your plugin makes up front sure nothing is missed when it comes to changes. Certainly absent mention of plugin in that community thread, presume the map style user and respondents are unaware of this handsdown automation. Cycling down a road which had a name change, starts one side at 2 and highest near 600, step 2, that's a lot of chances to miss something doing by eyeball and hand. Not sure when being asked to do this downloading, if that will do all elements in the area, as that road is not necessarily loaded entirely. It's why I like the type=street relation. Open it in the editor and if it says incomplete one knows to go fetch the rest. (Associated street I've never used which may include linking all addresses too, wild guess).

thanks

comment:4 by taylor.smock, 3 months ago

Your plugin makes up front sure nothing is missed when it comes to changes.

That was the whole idea behind the plugin.

Certainly absent mention of plugin in that community thread, presume the map style user and respondents are unaware of this handsdown automation.

Definitely a possibility; I've never been the best at marketing. Or writing blog/diary posts.

Not sure when being asked to do this downloading

IIRC, it does an overpass query for addr:street=<original name> and highway=* name=<original name>. I'd want to double check that though; it has been years since I actually worked on this plugin. It might do associated street relations to, but I don't remember doing anything for them.

comment:5 by taylor.smock, 3 months ago

It seems oblivious of the fact that there's still segments with old name

Now that I'm looking at the plugin again, I think this was a deliberate design decision to account for situations where only part of the road had its name changed. I'll check and see how "easy" it is to add a dialog for whole road changes.

comment:6 by taylor.smock, 3 months ago

Component: PluginPlugin highwayNameModification
Version: tested

comment:7 by taylor.smock, 3 months ago

Resolution: fixed
Status: newclosed

Fixed in v62.

comment:8 by SekeRob, 3 months ago

Fetched the build 63 this morning (detach old plugin, restart, download new) then tested all possible scenarios that broke things, and scenarios probable.

1) When partial rename, only addresses in immediate vicinity are updated. Cool.
2) When selecting all segments and apply name change all addresses are picked up too.
3) When selecting partial, then rename, then select all, rename, it will only ask for the addresses that had not already been updated. The question of the addresses to be updated nicely homes in on the node being asked to yes/no, seemingly always in progressive order from lowest to highest.

WishList: Show the housenumber in the yes/no frame up top. Some address nodes are densely packed and at 300 addresses on one street side it does give feedback how far into the update process.

Maybe unrelated, something popped up with Gridify having a problem though not utilized prior in this session. Need to observe if persistent and will open new ticket if so.

thanks

PS The 'more info' link in the preferences plugin screen for HDM goes to a www.gitlab.com place asking for email/password. Don't know why, other 'more info' links go to https://josm.openstreetmap.de/wiki/Help/Plugin/...

comment:9 by taylor.smock, 3 months ago

  1. This was a specific design decision; I didn't want to accidentally change addresses that should not have been changed. This is actually where most of the processing time is "spent".
  2. This is because there is no "nearer" way segment with the old name after changing all of them.
  3. I don't remember if I did any sorting on the list. I might have for predictability.

For your wishlist time, this should be a fairly easy "fix" (although I'd probably put x/y in the title instead).

[...] link in the preferences plugin screen for HDM [...]

HDM?

comment:10 by SekeRob, 3 months ago

Sorry HNM :O)))

comment:11 by taylor.smock, 3 months ago

I thought that might be the case. I've got a PR that points to the github repo since it doesn't have any help pages. And adds your wishlist item and a recursive option. I'm writing tests for the recursive option.

comment:12 by taylor.smock, 3 months ago

I've made another release.

Highpoints (from your perspective):

  • Recursive option (asks per additional data download, so you may have to answer affirmatively multiple times)
  • Add basic integration for the todo plugin
    • highwayNameModification does not depend upon the todo plugin; it has to be installed by the user separately
    • It adds potential issues to the todo list, if (and only if) there are no current todo items. The potential issues should have the changed name somewhere in their tags.
    • Not well tested, so YMMV.

comment:13 by SekeRob, 3 months ago

Am afraid build 66 does nothing at all on addresses. It also throws an exception error if replying *No* to downloading additional data and even when saying ignore for this session the warning returns. Went back to the street (Via della Fonte in Sant'Eusanio) where testing. Now also created a street relation, but nothing happens to addresses when changing the road name, part or whole, no asking like before. Tested section where nr.61 is mapped which got actioned with build 63.

relation: https://www.openstreetmap.org/relation/18259286

The standard bug reports should it help:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-10-30 15:48:42 +0100 (Wed, 30 Oct 2024)
Revision:19253
Build-Date:2024-10-31 02:30:30
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19253 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 22H2 (19045)
Memory Usage: 3124 MB / 4084 MB (1436 MB allocated, but free)
Java version: 21.0.3+9-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dicedtea-web.bin.location=%UserProfile%\AppData\Local\Programs\OpenWebStart\javaws, -Djava.util.Arrays.useLegacyMergeSort=true, --add-reads=java.base=ALL-UNNAMED,java.desktop, --add-reads=java.desktop=ALL-UNNAMED,java.naming, --add-reads=java.naming=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/javax.jnlp=ALL-UNNAMED,java.desktop, --add-exports=java.base/com.sun.net.ssl.internal.ssl=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.action=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.provider=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.util=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.validator=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.security.x509=ALL-UNNAMED,java.desktop, --add-exports=java.base/jdk.internal.util.jar=ALL-UNNAMED,java.desktop, --add-exports=java.base/sun.net.www.protocol.http=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.awt.X11=ALL-UNNAMED,java.desktop, --add-exports=java.desktop/sun.applet=ALL-UNNAMED,java.desktop,jdk.jsobject, --add-exports=java.naming/com.sun.jndi.toolkit.url=ALL-UNNAMED,java.desktop, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.desktop/com.apple.eawt=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=javafx.graphics/com.sun.javafx.application=ALL-UNNAMED, --add-exports=jdk.deploy/com.sun.deploy.config=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djava.security.manager=allow]
Dataset consistency test: No problems found

Plugins:
+ Elevation (0.10.1)
+ ElevationProfile (36349)
+ HouseNumberTaggingTool (36344)
+ KartaView (545)
+ MakeParallel (v1.1.0)
+ Mapillary (1778)
+ MicrosoftStreetside (36326)
+ OpeningHoursEditor (36344)
+ RoadSigns (36343)
+ apache-commons (36349)
+ buildings_tools (36344)
+ contourmerge (v0.2.1)
+ easypresets (1623509627)
+ graphview (36344)
+ gridify (1718663815)
+ highwaynamemodification (66)
+ javafx (36325)
+ libphonenumber (8.13.49)
+ measurement (36350)
+ notesolver (0.5.0)
+ phonenumber (1.1.1)
+ pt_assistant (637)
+ reltoolbox (36344)
+ reverter (36343)
+ routing (36343)
+ scripting (v0.3.1)
+ tageditor (36350)
+ terracer (36344)
+ todo (139)
+ turnlanes (36344)
+ turnlanes-tagging (1727811971)
+ turnrestrictions (36344)
+ undelete (36349)
+ utilsplugin2 (36350)

Tagging presets:
+ <josm.pref>/EasyPresets.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1
+ https://raw.githubusercontent.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Golf_Course&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/AdvertisingPreset&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Maxspeed-zones&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/Manholes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/TurnLanes&zip=1
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Potlach2_access&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SlovakiaBicycleRoutes&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&zip=1
- https://josm.openstreetmap.de/josmfile?page=Rules/IncompleteObjectWarnings&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_en&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
+ https://gitlab.com/cartocite/josm-style-traffic-signs-orientation/-/raw/main/traffic_sign_orientation_style.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Modified&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1
+ https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR_OC.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://raw.githubusercontent.com/OpenNauticalChart/josm/master/european-waterways-classification-style/CEMT-style.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Waterways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NewParkingFeatures&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1

Last errors/warnings:
- 18683.379 W: Cannot paint layer {0}: It is locked.
- 18684.389 W: Cannot paint layer {0}: It is locked.
- 21045.409 E: Unable to get system property: java.security.AccessControlException: access denied ("java.util.PropertyPermission" "os.name" "read")
- 21045.409 E: Unable to get system env: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "getenv.ProgramFiles(x86)")
- 21045.410 E: Unable to get system property: java.security.AccessControlException: access denied ("java.util.PropertyPermission" "java.version" "read")
- 21089.025 E: Unable to get thread stack traces: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "getStackTrace")
- 21089.049 E: Handled by bug report queue: java.security.AccessControlException: access denied ("java.util.PropertyPermission" "os.version" "read")
- 21114.614 E: Exception raised in EDT: java.lang.reflect.InvocationTargetException. Cause: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "accessClassInPackage.com.sun.java.swing.plaf.windows")
- 21114.620 E: Handled by bug report queue: java.security.AccessControlException: access denied ("java.util.PropertyPermission" "os.version" "read")
- 21114.681 E: Unable to get thread stack traces: java.security.AccessControlException: access denied ("java.lang.RuntimePermission" "getStackTrace")



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-1 (94) of JOSM
java.security.AccessControlException: access denied ("java.util.PropertyPermission" "os.version" "read")
	at java.base/java.security.AccessControlContext.checkPermission(AccessControlContext.java:488)
	at java.base/java.security.AccessController.checkPermission(AccessController.java:1071)
	at java.base/java.lang.SecurityManager.checkPermission(SecurityManager.java:411)
	at net.sourceforge.jnlp.runtime.JNLPSecurityManager.checkPermission(JNLPSecurityManager.java:272)
	at java.base/java.lang.SecurityManager.checkPropertyAccess(SecurityManager.java:1146)
	at java.base/java.lang.System.getProperty(System.java:967)
	at java.desktop/sun.awt.OSInfo.getWindowsVersion(OSInfo.java:105)
	at java.desktop/com.sun.java.swing.plaf.windows.WindowsLookAndFeel.isOnVista(WindowsLookAndFeel.java:1593)
	at java.desktop/com.sun.java.swing.plaf.windows.WindowsTableHeaderUI$XPDefaultRenderer.getTableCellRendererComponent(WindowsTableHeaderUI.java:138)
	at java.desktop/javax.swing.plaf.basic.BasicTableHeaderUI.getHeaderRenderer(BasicTableHeaderUI.java:736)
	at java.desktop/javax.swing.plaf.basic.BasicTableHeaderUI.getHeaderHeight(BasicTableHeaderUI.java:771)
	at java.desktop/javax.swing.plaf.basic.BasicTableHeaderUI.createHeaderSize(BasicTableHeaderUI.java:799)
	at java.desktop/javax.swing.plaf.basic.BasicTableHeaderUI.getPreferredSize(BasicTableHeaderUI.java:830)
	at java.desktop/javax.swing.JComponent.getPreferredSize(JComponent.java:1734)
	at java.desktop/javax.swing.table.JTableHeader.getPreferredSize(JTableHeader.java:471)
	at java.desktop/java.awt.GridBagLayout.GetLayoutInfo(GridBagLayout.java:1111)
	at java.desktop/java.awt.GridBagLayout.getLayoutInfo(GridBagLayout.java:906)
	at java.desktop/java.awt.GridBagLayout.preferredLayoutSize(GridBagLayout.java:726)
	at java.desktop/java.awt.Container.preferredSize(Container.java:1826)
	at java.desktop/java.awt.Container.getPreferredSize(Container.java:1810)
	at java.desktop/javax.swing.JComponent.getPreferredSize(JComponent.java:1736)
	at java.desktop/javax.swing.ScrollPaneLayout.layoutContainer(ScrollPaneLayout.java:799)
	at java.desktop/java.awt.Container.layout(Container.java:1541)
	at java.desktop/java.awt.Container.doLayout(Container.java:1530)
	at java.desktop/java.awt.Container.validateTree(Container.java:1725)
	at java.desktop/java.awt.Container.validate(Container.java:1660)
	at java.desktop/javax.swing.RepaintManager$3.run(RepaintManager.java:757)
	at java.desktop/javax.swing.RepaintManager$3.run(RepaintManager.java:755)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.desktop/javax.swing.RepaintManager.validateInvalidComponents(RepaintManager.java:754)
	at java.desktop/javax.swing.RepaintManager$ProcessingRunnable.run(RepaintManager.java:1896)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:773)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

comment:14 by taylor.smock, 3 months ago

That should be fixed now.

comment:15 by SekeRob, 3 months ago

Afraid the doornail is still dead with build 68. Tried it today on Pescara's multipart Lungomare Papa Giovanni XXIII, which by Italian conventian has to be Lungomare Papa Giovanni Ventitreesimo, the Twentythird, but no address with the suffix XXIII got the automated update treatment The No asking at all. The Ctrl+F "addr:street"=..." search needed to be called on to fix them. HNM build 63 did do it right without freezing JOSM ad infinitum saying yes to everything. The exception warning also persists.

Sorry for boding this tiding.

comment:16 by taylor.smock, 3 months ago

I need better steps to reproduce then. Here is my current testing procedure for functionality:

  1. Download small area around node 176092968
  2. Select way 628859022
  3. Change name from South University Boulevard to Something else
  4. First dialog, Download additional information, select Do not show again (this session) then press Yes
  5. Second dialog, Should we recursively change names, select Do not show again (this session) then press Yes
  6. Third dialog, Highway name changed (1/33), select Do not show again (this session) then press Yes
  7. Wait for downloads and renames to finish
  8. Search for "South University Boulevard". Only two bus stops should be selected.

If you don't know how to get osm object information, select the object, ctrl+c, go to text input, ctrl+v will do it.

comment:17 by SekeRob, 3 months ago

Followed your instructions to the letter, downloading only a small bit around South University and East Evans. Not getting the 3rd dialog of Highway name change (1/33). Went into the advanced preferences and reset the respective lines v.v. the HNM, 4 lines, which changed to true,-1, true, -1. Then reran the process to the letter of your steps. Get only 2 dialogs. Repeated the advanced prefs reset, but now only 2 Adv.Pref lines are found v.v. the HNM, both with the true value. BofA continues to reside at South University Blvrd. Seems something else is preventing the plugin here to get to the 3rd dialog. Doing a search on 'Something else' only that road section is found i.e. 1 object. At all time the process ends instantaneous after the second dialog Yes.

I never use the 'remember' options in dialogs anyhow... I'd like the be reminded.

BTW, to launch the Download Object which shows the menu shortcut of Ctrl+Shift+O, it actually gets intercepted by my display card utility.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain taylor.smock.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.