[PATCH] image direction is wrong when position is beetween 2 gpx point

[StephaneP]

1) correlate images positions with a support layer, and one image timestamp is beetween two support-layer node
2) enable "override position" and "set image direction"

The image direction should be calculated with the image position and the next node, but it's calculated with the next segment direction. See this screenshot:

[Don-vip]

In 18237/josm:

see #21144 - fix #21334 - fix correlated image direction when position is between 2 gpx points

[Don-vip]

In 18243/josm:

see #21144 - see #21334 - add debug logs + fix coverity 1464077 (Logically dead code: nextWp cannot be null with the isLast branch, but Eclipse doesn't see it)

[Don-vip]

Milestone renamed

[StephaneP]

As #21364 this bug is back in r18321

[StephaneP]

In the current code, when correlating, the image direction isn't pointing to the next Waypoint (curWp) but the 2nd next one (nextWp). I change this with:

-            LatLon nextCoorForDirection = nextWp.getCoor();
+            LatLon nextCoorForDirection = curWp.getCoor();

I then add a comparison in case image and curWp coordinates are equal, to change the nextCoorDirection to nextWp.

+if (nextCoorForDirection.equals(curCoor)) {
+                            nextCoorForDirection = nextWp.getCoor();
+                        }

[StephaneP]

fix direction