[RFC][PATCH] Small improvements in default style

[naoliv]

Consider it as a proof of concept, please.

Have this area ​https://www.openstreetmap.org/#map=12/-21.4232/-45.9483 downloaded in JOSM, at zoom level 12.
We can see this:

And we can spot two problems:
1) highway=residential are on top of major highways (primary and secondary, for example)
2) a lot of blue nodes (for traffic_calming, turning_loop, etc) when we select to hide the nodes

Considering that the default z-index is 0, for 1 I did test this:

styles/standard/elemstyles.mapcss

@@ -476 +476 @@
     color: motorroad#3377ff;
 }
 way[highway=motorway] {
+    z-index: 1.3;
     width: 3;
     color: motorway#809bc0;
 }
 way[highway=motorway_link] {
+    z-index: 1.2;
     width: 3;
     color: motorway#809bc0;
 }
 way[highway=trunk] {
+    z-index: 1.1;
     width: 3;
     color: trunk#7fc97f;
 }
 way[highway=trunk_link] {
+    z-index: 1.0;
     width: 3;
     color: trunk#7fc97f;
 }
 way[highway=primary] {
+    z-index: 0.9;
     width: 3;
     color: primary#fb805f;
 }
 way[highway=primary_link] {
+    z-index: 0.8;
     width: 3;
     color: primary#fb805f;
 }
 way[highway=secondary] {
+    z-index: 0.7;
     width: 3;
     color: secondary#fdbf6f;
 }
 way[highway=secondary_link] {
+    z-index: 0.6;
     width: 3;
     color: secondary#fdbf6f;
 }
 way[highway=tertiary] {
+    z-index: 0.5;
     width: 2;
     color: tertiary#f7f496;
 }
 way[highway=tertiary_link] {
+    z-index: 0.4;
     width: 2;
     color: tertiary#f7f496;
 }
 way[highway=unclassified] {
+    z-index: 0.3;
     width: 2;
     color: street#c0c0c0;
 }
@@ -538 +549 @@
     color: highway_track#6e541c;
 }
 way[highway=residential] {
+    z-index: 0.2;
     width: 2;
     color: street#c0c0c0;
 }
 way[highway=living_street] {
+    z-index: 0.1;
     width: 2;
     dashes: 9,9;
     dashes-background-color: livingdashed#00ff00;

And got a nicer result:

Most probably a proper fix will need another values and/or major-z-index (or even something else) to achieve the result.

For 2 I did this:

styles/standard/elemstyles.mapcss

@@ -4700 +4700 @@
 
 */
 
-node|z-16[setting("hide_icons")],
+node|z-14[setting("hide_icons")] {
+        symbol-size: 1;
+}
+
+node|z15-[setting("hide_icons")],
 node|z17-[!is_prop_set("icon-image")][setting("hide_icons")]!.maxspeedclass,
 node[!is_prop_set("icon-image")][!setting("hide_icons")]!.maxspeedclass {
     symbol-size: 2;

And got this (it doesn't have the z-layer part applied):

ie, at zoom levels 16 and 15 we still see the small blue squares; 14 upwards we hide them.

[bastiK]

+1 for the highways, z-index is the right tool to use here.

As for the blue dots, I would rather keep them. This an editor and not a renderer and the advantage of always having tagged nodes visible outweighs the cost (slightly cluttered map). You can still use filters, to get rid of them temporarily.

[naoliv]

Maybe only some nodes could be hidden, then?
In lower zoom levels we usually don't need to see nodes connected to highways (highway=stop, crossing, turning_loop, traffic_signals, etc), since we are already seeing that there is a highway there.

[Klumbumbus]

In 13125/josm:

see #15483 - improve mappaint by layering highways (patch by naoliv)

[Klumbumbus]

This change also improves the rendering on waterway tunnels:

I kept the numbers between 0 and 1 to avoid regressions with objects already using z-index: 1

[Klumbumbus]

I'll test if it makes sense to hide node:tagged!:unconnected on low zoom. Maybe configurable as Help/Dialog/MapPaint/StyleSettings

[Klumbumbus]

Has anyone an idea about ​https://lists.openstreetmap.org/pipermail/josm-dev/2017-December/007951.html?

[Klumbumbus]

regression: #15698

[bastiK]

Replying to Klumbumbus:

Has anyone an idea about ​https://lists.openstreetmap.org/pipermail/josm-dev/2017-December/007951.html?

Both should be similar, but I cannot really say without testing.

[Klumbumbus]

stabilization phase -> next milestone; the regression will be fixed in 17.12 in #15698

[Klumbumbus]

In 13255/josm:

fix #15698, see #15483 - restore display of cycleway=opposite and limit it to ways with oneway=* except oneway=no

[Klumbumbus]

In 13321/josm:

see #15483 - hide tagged waynodes at low zoom for better view and easier selection of ways. Deactivatable via a new style setting.

[Klumbumbus]

before after comparison​

[Klumbumbus]

regression: #18070

[Klumbumbus]

In 15314/josm:

fix #18070, see #15483, fix #17022, see #11270 - restore display of tram when tagged together or overlapping with highway, handle light_rail the same as tram, i.e. draw on top of highway and don't warn about missing railway=crossing|level_crossing