Test for missing/wrong railway=crossing|level_crossing

[naoliv]

We exchange this for 3 beers if accepted or for 1 beer if something needs to be adjusted (1 beer too if not accepted):

way[railway =~ /^(light_rail|miniature|narrow_gauge|preserved|rail|tram)$/] > node { set .is_in_railway }
way[highway =~ /^(bridleway|cycleway|footway|path|steps)$/] > node[railway != crossing].is_in_railway {
        throwWarning: tr("should have railway=crossing where pedestrians cross");
        fixAdd: "railway=crossing";
}

way[highway =~ /^(bus_guideway|living_street|motorway|pedestrian|primary|raceway|residential|road|secondary|service|tertiary|track|trunk|unclassified)/] > node[railway != level_crossing].is_in_railway {
        throwWarning: tr("should have railway=level_crossing where road cross");
        fixAdd: "railway=level_crossing";
}

[naoliv]

It seems that the beers scared people here

[Klumbumbus]

Ticket #9300 has been marked as a duplicate of this ticket.

[Klumbumbus]

In 9839/josm:

fix #11270 - add validator warning for missing/wrong railway=crossing|level_crossing (modified patch by naoliv)

[Klumbumbus]

Ticket #12519 has been marked as a duplicate of this ticket.

[Klumbumbus]

Ticket #9298 has been marked as a duplicate of this ticket.

[Klumbumbus]

In 12595/josm:

see #11270 - don't warn about missing railway=crossing|level_crossing for questionable cases e.g. when the highway changes from residential to footway at the railway crossing node. This avoids an infinite loop of the validator fix button.

[Klumbumbus]

Test file: attachment:ticket11270.osm​

[Klumbumbus]

In 12895/josm:

see #11270, see #9297 - avoid false positive missing railway crossing warnig for combined railway highway ways.

[Klumbumbus]

In 15314/josm:

fix #18070, see #15483, fix #17022, see #11270 - restore display of tram when tagged together or overlapping with highway, handle light_rail the same as tram, i.e. draw on top of highway and don't warn about missing railway=crossing|level_crossing