add validator warning for short keys

[Klumbumbus]

follow up from #11234

we should warn about keys with 1 or 2 characters as these are mostly typos, except to (used in route relations).

I think we should not allow id, since this is not documented in the wiki and mostly part of local imports or should be ref instead.

the 2 following mapcss syntaxes do not work however:

*[/.{1,2}/] {
  throwWarning: tr("uncommon short key");
}

*[/.?.?/] {
  throwWarning: tr("uncommon short key");
}

[bastiK]

This isn't possible at the moment. We'd need a MapCSS extension or a custom validator test class.

[simon04]

Hi all :),
what about …

*[/^.$/], *[/^..$/] {
  throwWarning: tr("uncommon short key");
}

[Klumbumbus]

That works, thanks :)

[Klumbumbus]

In 8192/josm:

fix #11330 - add validator warning for short keys with only one or two characters (code by simon04)

[bastiK]

Replying to simon04:

Hi all :),
what about …

*[/^.$/], *[/^..$/] {
  throwWarning: tr("uncommon short key");
}

Hi Simon, it's nice to hear from you again!

I completely forgot you added this syntax in r6547, sorry about that. :)

[aceman]

Is "uncommon short key" proper English?
Also, should the "to" be restricted to only occur in relations? Can mapCSS distinguish the object type?

[Klumbumbus]

Replying to aceman:

Is "uncommon short key" proper English?

I don't know :)

Also, should the "to" be restricted to only occur in relations? Can mapCSS distinguish the object type?

Yes it can. For sure we can warn also for to on nodes. I'm not sure about ways. It is not documented, but it seems it is (geographically limited) used on some power cables, see ​http://taginfo.openstreetmap.org/keys/to?filter=ways#map

[aceman]

Replying to Klumbumbus:

Replying to aceman:

Is "uncommon short key" proper English?

I don't know :)

"unusually short key" or something else with -ly suffix would seem more proper to me.

Also, should the "to" be restricted to only occur in relations? Can mapCSS distinguish the object type?

Yes it can. For sure we can warn also for to on nodes. I'm not sure about ways.

It seems the current patch will NOT warn for nodes. Or any objects with "to". Making it NOT warn only on relations is the proposal.

[Klumbumbus]

Replying to aceman:

It seems the current patch will NOT warn for nodes. Or any objects with "to". Making it NOT warn only on relations is the proposal.

Yes, thats what I mean. What I tried to say was that some people think that to is also valid for ways.

[aceman]

Yeah so either we leave it as is or warn at least for nodes.

[skyper]

Replying to Klumbumbus:

I'm not sure about ways. It is not documented, but it seems it is (geographically limited) used on some power cables, see ​http://taginfo.openstreetmap.org/keys/to?filter=ways#map

That is bad tagging as this information should be either on a relation or simply taken from data as the destination would be any power=substation at the end of the lines.

+1 for warning on ways, too.

[Klumbumbus]

Can someone help with the correct english phrase?

• uncommon short key
• unusually short key
• ...

?

[Klumbumbus]

In 8204/josm:

see #11245 - remove controversial clothes tag; fix #10329 - improve color validator warning; fix #11330 - improve uncommon short key validator warning; fix #11344 - add validator warning for 'tower|pole=air_to_ground'

[aceman]

Please, why do you do changes in unrelated tickets? And why is 'clothes' removed, now that localizers have done the work of translating the values? What is controversial in it?

[Klumbumbus]

Replying to aceman:

Please, why do you do changes in unrelated tickets?

I thought it wouldn't hurt to combine these minor changes.

And why is 'clothes' removed, now that localizers have done the work of translating the values? What is controversial in it?

See #11245

[Klumbumbus]

In 15828/josm:

• Fix #18642, see #11330 - Don't warn about the key to on route=ferry ways
• Add vehicle combo to highway=track preset