give warning for color=*

[Klumbumbus]

JOSM validator should warn about color=* since colour=* is the correct key.

see

• ​http://wiki.openstreetmap.org/wiki/Key:colour
• #8208
• ​http://taginfo.openstreetmap.org/compare/color/colour

[Don-vip]

We already have an automatic correction on upload, I don't think this is worth a new manual test:

    public FixDataHook () {
        deprecated.add(new FixDataKey("color",            "colour"));
        deprecated.add(new FixDataTag("highway", "ford",  "ford",    "yes"));
        deprecated.add(new FixDataTag("oneway",  "false", "oneway",  "no"));
        deprecated.add(new FixDataTag("oneway",  "0",     "oneway",  "no"));
        deprecated.add(new FixDataTag("oneway",  "true",  "oneway",  "yes"));
        deprecated.add(new FixDataTag("oneway",  "1",     "oneway",  "yes"));
        deprecated.add(new FixDataTag("highway", "stile", "barrier", "stile"));

[Klumbumbus]

OK, I didn't know that.

[mkoniecz]

Data correction - is it applied to all objects or just modified ones? In the second case validator test still would be useful.

[skyper]

color is not delete if colour with the same value does already exist.

[skyper]

Replying to skyper:

color is not delete if colour with the same value does already exist.

Is it possible to delete it silently in this case ?

[Klumbumbus]

The situation around color is not satisfying.

• If you add color it silently adds colour on upload but keeps color.
• If you modify and upload an object with value of color = value of colour nothing happens.
• No warnings if you manually run the validator.

[Klumbumbus]

Also I would not use a silent autofix for color, since the user does not learn from his mistakes.

[stoecker]

Replying to Klumbumbus:

The situation around color is not satisfying.

• If you add color it silently adds colour on upload but keeps color.

That should not be the case. color is changed into colour, not added.

• If you modify and upload an object with value of color = value of colour nothing happens.
• No warnings if you manually run the validator.

You can add proper validator warnings. The silent change is there, as this is an error we introduced with JOSM presets.

[Klumbumbus]

Replying to stoecker:

Replying to Klumbumbus:

The situation around color is not satisfying.

• If you add color it silently adds colour on upload but keeps color.

That should not be the case. color is changed into colour, not added.

Happend to me, that I added color, the upload seemed fine and the result is ​http://www.openstreetmap.org/way/203410463.

Thanks to Osmose I noticed this.

[stoecker]

In 8178/josm:

see #10329 - fix wrong upload fix and remove wrong old keys when new key has same value

[stoecker]

Uih, an error in the fixing code is not nice.

[stoecker]

In 8179/josm:

see #10329 - also drop old value for FixDataTag, when new value matches

[Don-vip]

My fault I think. Can you check #10816 is still solved?

[stoecker]

Don't see that this may have caused the problem. I think the issue is there from the very beginning.

[Klumbumbus]

In 8184/josm:

see #10329 - add warnings for color

[Klumbumbus]

If you change and try to upload an object with colour=red and color=red, then first the validator warning appears and then the autoremove applies. The same if you add a new object with color. Can this be changed, so first the autofixes take place and then the validator runs? This way the validator warnings will not appear, because the autofix repairs it before.

[stoecker]

Your change would bring previous state back. Silent change without warning. Can be simply reached by removing the checks :-)

I think current way is right. User gets warned and can fix it. If he does not, the silent changes kick in.

[Klumbumbus]

The difference would be that you get warnings when running the validator manually on the whole data set, not only modified objects on upload. However we can keep the current situation.

[skyper]

example file

[skyper]

There exist some combinations with color see ​taginfo and my example file​.

Can we have a warning about any color:, :color and :color:. Thanks.

[Klumbumbus]

In 8204/josm:

see #11245 - remove controversial clothes tag; fix #10329 - improve color validator warning; fix #11330 - improve uncommon short key validator warning; fix #11344 - add validator warning for 'tower|pole=air_to_ground'

[Don-vip]

Follow-up: #15877