Changeset 8178 in josm

Timestamp:

2015-04-09T19:55:39+02:00 (10 years ago)

Author:

stoecker

Message:

see #10329 - fix wrong upload fix and remove wrong old keys when new key has same value

File:

• trunk/src/org/openstreetmap/josm/actions/upload/FixDataHook.java (modified) (5 diffs)

trunk/src/org/openstreetmap/josm/actions/upload/FixDataHook.java

@@ -83 +83 @@
                 if(!e.getKey().equals(k)) {
                     if(drop || !keys.containsKey(k)) {
-                        newKeys.remove(e.getKey());
+                        newKeys.put(e.getKey(), null);
                         if(!drop)
                             newKeys.put(k, v);
                     }
                 } else if(!e.getValue().equals(v)) {
-                    if(v.isEmpty())
-                        newKeys.remove(k);
-                    else
-                        newKeys.put(k, v);
+                    newKeys.put(k, v.isEmpty() ? null : v);
                 } else if (drop) {
-                    newKeys.remove(e.getKey());
+                    newKeys.put(e.getKey(), null);
                 }
             }
@@ -129 +126 @@
             if(keys.containsKey(oldKey) && !keys.containsKey(newKey)) {
                 keys.put(newKey, keys.get(oldKey));
-                keys.remove(oldKey);
+                keys.put(oldKey, null);
+                return true;
+            } else if(keys.containsKey(oldKey) && keys.containsKey(newKey) && keys.get(oldKey).equals(keys.get(newKey))) {
+                keys.put(oldKey, null);
                 return true;
             }
@@ -169 +169 @@
                 keys.put(newKey, newValue);
                 if(!newKey.equals(oldKey))
-                    keys.remove(oldKey);
+                    keys.put(oldKey, null);
                 return true;
             }
@@ -189 +189 @@
 
         for (OsmPrimitive osm : objectsToUpload) {
-            Map<String, String> keys = osm.getKeys();
+            HashMap<String, String> keys = new HashMap<>(osm.getKeys());
             if(!keys.isEmpty()) {
                 boolean modified = false;
@@ -197 +197 @@
                 }
                 if(modified)
-                    cmds.add(new ChangePropertyCommand(Collections.singleton(osm), new HashMap<>(keys)));
+                    cmds.add(new ChangePropertyCommand(Collections.singleton(osm), keys));
             }
         }