Highway label issues in new map style [patch]

[AMDmi3]

New map style brings several problems:

1) It's dependent on zoom. This is not acceptable for advanced editor, as a mapper should always see all objects in area on any zoom, including their types (e.g. icons) and complexity (e.g. nodes). At least there should be an option to do so.

2) Road labels are unreadable when antialiasing is disabled (and here it is disabled, as JOSM is too slow to render dense map data even without it). There's no way to disable labels either.

I haven't found a way to fix these problems in the style, it seems that zooms and labels are handled inside the renderer. I haven't found any relevant knobs in `Advanced Preferences' either. So for now there's no other way than to stick with old XML style.

So, minimal customization abilities should be added, which don't look too complex:

• an option to fix zoom level for renderer
• an option to disable labels for ways

[bastiK]

Replying to AMDmi3:

New map style brings several problems:

1) It's dependent on zoom. This is not acceptable for advanced editor, as a mapper should always see all objects in area on any zoom, including their types (e.g. icons) and complexity (e.g. nodes). At least there should be an option to do so.

This can be configured, see style settings.

2) Road labels are unreadable when antialiasing is disabled (and here it is disabled, as JOSM is too slow to render dense map data eevn without it). There's no way to disable labels either.

Could you describe the machine where you have performance problems (CPU, memory)? Please add a status report.

[AMDmi3]

This can be configured, see style settings.

This works, thanks. However, the location of that settings is really counter-intuitive - I would never open Map Paint Styles window. It probably should be either in Preferences or View->Map paint styles menu.

Could you describe the machine where you have performance problems (CPU, memory)? Please add a status report.

I don't think that has anything to do with my environment. I just work with large data sets.

[Don-vip]

Replying to AMDmi3:

the location of that settings is really counter-intuitive [...] It probably should be either in Preferences or View->Map paint styles menu.

This is discussed in #10435.

[Klumbumbus]

I think one more style setting to hide the street labels on all zoom levels would be good. The labels can sometimes be distracting also on high zoom levels, see example screenshot:

[Klumbumbus]

I made a patch for this.

[bastiK]

In 7520/josm:

applied #10468 - Highway label issues in new map style (based on patch by Klumbumbus)

[bastiK]

Replying to Klumbumbus:

I made a patch for this.

Thanks! The changes I did are with efficiency in mind. The idea is that simple style conditions need not be evaluated at runtime, but there could be a pre-processing step. Any rules where the setting condition does not match can be removed from the style sheet in advance. (Not implemented yet.)

[anonymous]

Thank you! The style is now usable. Now the only regression to the old style I can notice is that selected nodes are not filled (and mappaint.node.fill-selected doesn't affect it), but this is very minor.