Opened 10 years ago
Last modified 3 years ago
#10435 new enhancement
Improvements to user-settings for mapcss mappaint styles
| Reported by: | Klumbumbus | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core mappaint | Version: | |
| Keywords: | style settings mapcss | Cc: | skyper, imagic, richlv |
Description (last modified by )
User-settings for mapcss mappaint styles were included in JOSM with very basic functionality (see #10421). While this was ok for its first use, it could need some improvements which I want to sum up here:
- Currently it is only accessible in mappaint dialog. Many users do not use the dialog or even do not know how to get it. (Although I described where to change the user setting and attached a screenshot in the forum, users searched in the preferences window to change the user setting and gave up searching). It would be useful if the user-settings are also accessible in the preferences window and in the view menu (maybe also for buttons placed in the toolbar). To make it accessible in the preferences window (which is maybe indeed the first place to search for this setting) is maybe relevant for milestone:14.08 since it includes the big changes in default mappaint style.
- Extend the user settings to
numbers, lists,colors and strings. Styles/Lane_and_Road_Attributes would need the colors. (r15731 adds double and string, r16843 adds color)
- Enable to set a keyboard shortcut to change a specific (boolean) user setting.
Enable grouping of similar settings for enabling/disabling several settings at once.Done in r15289
- Make translations with
tr()also working for external mappaint styles which are managed in this wiki Styles#StylesmanagedinJOSMwiki.
Add documentation at Help/Styles/MapCSSImplementation(Done for initial boolean only implementation.)
Attachments (0)
Change History (30)
follow-up: 2 comment:1 by , 10 years ago
comment:2 by , 10 years ago
Replying to Don-vip:
I don't understand the difference between point 4 and #10426 you created earlier?
#10426 was not about user settings but about strings to display on nodes, ways and areas. I would like to use it in Styles/Coloured_Streets. You can see there in the screenshoots that it displays strings on nodes, ways and areas like "street?" or "number?" or "addr:interpolation shouldn't have other addr:*=* tags!"
I don't know if there is a difference in implementation if tr() is used in a mappaint user setting or in a normal block like way[highway=residential][!name]{ text: tr("name?"); } (Help/Styles/MapCSSImplementation says tr()is only for strings in the JOSM user interface).
If there is no difference, then #10426 can be closed as duplicate of this ticket.
comment:3 by , 10 years ago
| Cc: | added |
|---|
comment:4 by , 10 years ago
Replying to Klumbumbus:
- Currently it is only accessible in mappaint dialog. Many users do not use the dialog or even do not know how to get it. (Although I described where to change the user setting and attached a screenshot in the forum, users searched in the preferences window to change the user setting and gave up searching). It would be useful if the user-settings are also accessible in the preferences window and in the view menu (maybe also for buttons placed in the toolbar). To make it accessible in the preferences window (which is maybe indeed the first place to search for this setting) is maybe relevant for milestone:14.08 since it includes the big changes in default mappaint style.
Technically, it is not so easy to have this setting available in the preference window. (At the moment, it is only aware of the metadata, either downloaded from the server or saved to the preferences.xml. The mapcss file is not parsed before the user hits Okay.)
I won't have time for this before the 14.08 release.
comment:6 by , 10 years ago
| Description: | modified (diff) |
|---|
added to ticket text: Add documentation at Help/Styles/MapCSSImplementation
comment:7 by , 10 years ago
| Cc: | added |
|---|
comment:8 by , 10 years ago
| Description: | modified (diff) |
|---|
comment:9 by , 5 years ago
Is anyone still working on this? Or is there a newer ticket pertaining to enhancing mapcss user-settings?
comment:10 by , 5 years ago
I plan to work on making style settings more accessible (first point of this ticket).
comment:11 by , 5 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | style settings mapcss added |
comment:12 by , 5 years ago
Do you know if anyone is/was planning on expanding the user settings (second point of this ticket)?
comment:14 by , 5 years ago
comment:16 by , 5 years ago
| Description: | modified (diff) |
|---|
comment:17 by , 5 years ago
| Description: | modified (diff) |
|---|
follow-up: 20 comment:18 by , 5 years ago
I'm sorry--there was some miscommunication on my end. I meant to say, do you know if anyone is/was planning on expanding the user settings (second point of this ticket)? If not, I'll be working on it.
comment:20 by , 5 years ago
Replying to G_Fyyar:
expanding the user settings (second point of this ticket)? If not, I'll be working on it.
Possible use case see ticket:18095#comment:4
comment:21 by , 5 years ago
| Cc: | added |
|---|
comment:27 by , 5 years ago
Replying to simon04:
In 15731/josm:
Could you please add documentation on wiki:/Help/Styles/MapCSSImplementation#Stylesettings?
comment:28 by , 5 years ago
Documentation done, see Help/Styles/MapCSSImplementation?action=diff&version=170
I agree on point 1 we should make it more accessible. I don't understand the difference between point 4 and #10426 you created earlier?