source: josm

fix #24009 - don't call setting storage in settings setup stage or checkbox state gets lost

Add/ignore popular tags

Add:

• advertising=totem

some small cleanups

i18n updates

Dependency updates

ivy.xml:

• junit5-system-exit: 1.1.2 -> 2.0.0 on Java 17+. This is needed since there are patches currently being applied to the JDK to remove the security manager (see JEP 486), and the 1.x series will no longer work. The 2.x series is Java 17+ only and runs as a javaagent.
• tag2link: 2024.8.21 -> 2024.10.21
• wiremock: 3.9.1 -> 3.9.2
• junit5: 5.11.0 -> 5.11.3

tools/ivy.xml:

• checkstyle: 10.18.1 -> 10.18.2
• proguard-ant: 7.5.0 -> 7.6.0
• pmd: 7.5.0 -> 7.6.0
• errorprone: Not upgraded from 2.31.0 -> 2.34.0 (since it is Java 17+ only)

see #23964 - One typo in each added word - was probably not my best day ;-)

Fix #23920: Wrapped ReportedException don't keep data on bug report

cut long line

Add/ignore popular tags

Add:

• fountain -- the type of water fountain for drinking water. Some miscellaneous tags for water fountains were also added.

add some more script variants, fix #23964

See #23926: Fix new coverity issues

Coverity doesn't like null checks when a previous statement would have thrown
a NullPointerException on the object being checked for null. This fixes the
"defect" by removing the null checks and adding a null check in
ColorScale#addTitle.

Fix #23926: Extend GPS legend for time information, improve design (patch by Pauline, modified)

Modifications are as follows:

• Reduction of code duplication
• Addition of functions in ColorHelper to calculate contrast ratios

Fix #23951: Fix free in startup linux scripts when it is in a localized environment

Fix #23948: Update AppStream metadata (patch by sebastic, modified)

Modifications are as follows:

• Addition of caption to screenshot
• Addition of various supplementary URLs

i18n updates

Fix #23930: Merging duplicated layers with little differences stalls JOSM

This is fixed by keeping the "last" conflict in the problem if statement body.

Update tests for r19225

Add/ignore popular tags

Add:

• flood_prone=yes: This is mostly used to indicate that a highway may be flooded after a heavy rain.

Add/ignore popular tags

Ignore:

• admin_type:PH: Highly localized to the Philippines
• residential:condominium: Deprecated -- wiki suggests residential=apartments + condo=*
• sidewalk: This is replaced by sidewalk:both, but is still valid tagging.

Add:

• managed (to wetland, wood, fell, and heath)
• sidewalk:{both|left|right}: We already had validator rules for these, this just adds them to presets. Note that sidewalk and sidewalk:both are similar, but sidewalk=separate is unspecific as to the side of the sidewalk.

See #11487: Have josm render data to tiles

Start adding basic rendering tests for tiled rendering.
Right now, the test only looks at a point in the center of the tile; there seems
to be some positioning/stretching issues at the edges that I need to debug and
fix.

fix a PMD warning

Fix #23866: java.io.UncheckedIOException: java.nio.file.FileSystemException: The device is not ready

This does two things:

1. Unwrap an unchecked exception in ImagesLoader so that we are throwing a checked exception
2. Explain some IO exceptions (specifically "the device is not ready")

This is not the "best" solution, but it should mean that we are not ignoring
issues related to JOSM.

Fix #23908: Significantly improve the performance of copy/paste when dealing with large amounts of data

From #23908, at least one valid workflow involves copy/pasting large amounts of
data (specifically updating boundaries). The relation for Terwolde in the
sample data had 2206 objects. This took >5 minutes to copy between layers. With
this change, it takes <1 second.

This is a performance regression from r19176. The primary culprit from r19176 is
when we check the size of the dataset. The problem is that we check to see if the
size of the primitives being changed is greater than or equal to the non-deleted
complete primitives in the dataset. We get a new filtered collection each time
we get those primitives, and therefore the size of that is not cached. The size
calculation for the filtered collection is where almost all the expense is. We
fix that by wrapping the work from AddPrimitivesCommand in DataSet#update to
have a single large update at the end of the copy operation. This ensures that
we do not have many spurious fired event calls when a mass operation is going on.

Fix #23770: Deprecate cycleway=opposite* family (patch by Famlam)

The cycleway=opposite* family was deprecated in
​osmwiki:Proposal:Deprecate_cycleway=opposite_family on 2024-06-22.

This removes the opposite* values from the cycleway tags in defaultpresets.xml
and adds a deprecation warning for them.

Add/ignore popular tags

Ignore:

• motor_vehicle=agricultural;forestry: This is covered by standard access tagging. I am uncertain why someone decided to create a page for a tag consisting of a list of values.

Dependency updates:

ivy.xml:

• jmapviewer: 2.21 -> 2.22: Fix a NumberFormatException (fix #23888)
• commons-compress: 1.27.0 -> 1.27.1
• tag2link: 2024.8.12 -> 2024.8.21
• commons-lang3: 3.16.0 -> 3.17.0
• classgraph: 4.8.174 -> 4.8.175
• junit: 5.10.3 -> 5.11.0: Repeatable @..Source annotations for parameterized tests
• equalsverifier: 3.16.1 -> 3.16.2

tools/ivy.xml:

• checkstyle: 10.17 -> 10.18: Better support for Java 21
• pmd: 7.4.0 -> 7.5.0
• errorprone: 2.30.0 -> 2.31.0: Note: this is the last planned release that supports running on Java 11.

See #23875: Use SNAPSHOT instead of 1.0-SNAPSHOT since that is what our scripts currently publish

This should fix the Jenkins build for plugins.

Note: Maven warns that this may break in the future, in which case we'll have to
change our processes.

Fix #23874: Syntax issue from r19169

It looks like tr issues don't get caught by automated tests.

Fix #23251: Crossing preset: Change label for crossing_ref

This is a followup of r19164 to change another crossing_ref reference.

Fix #23821: Ensure that remote control commands are processed in order

This reverts or partially reverts r19153 and r19196 in favour of forcing ordering
in the RequestProcessor#run method. This does not block the server thread, but
it can mean that we have a bunch of processor threads that are waiting on the
previous processor thread.

fix checkstyle

See #23821: Show confirmation dialogs in the order in which the remote control commands were sent to JOSM

fix #23850 - reduce long cache file names

Fix #23841: Bing: Automatically reload all tiles with Error: Attribution is not loaded yet after successfully loading the attribution

Java 11 Windows is a bit slow

Uih, MacOs precision is worse

fix debug

Fix EnumSet instantiation error

reduce test threshold to get MacOS working

Fix some coverity issues

Add/ignore documented popular tags

Add

• ​osmwiki:Tag:emergency=life_ring
• ​osmwiki:Tag:emergency=lifeguard (fixes #22852) lifeguard isn't actually a popular tag (yet), but it is documented and similar enough to life_ring that I'm adding it to make it easier for people to avoid making mistakes.

Fix #11487: Have josm render data to tiles

This adds a new rendering method that renders async. This avoids blocking the UI.

Where this is useful:

• Large datasets (think county or country level)

Where this is not useful:

• Micromapping -- the tiles aren't being rendered exactly where they should be and there are some minor rendering artifacts.

Known issues:

• Some tiles aren't exactly where they should be (off by a pixel or two -- by default, we use the old render method at z16+)
• Rendering of tiles is slow -- there is some prework done to render tiles in batches. The primary reason rendering is slow is we are effectively rendering 25 total tiles (to avoid movement of text, we render 2 tiles in each directory and only keep the middle one)
• Due to the above speed issue, hovering over an object will cause the highlight to render in slowly.

New advanced preferences:

• mappaint.fast_render.tile_size -- controls the number of pixels in a tile
• mappaint.fast_render.zlevel -- controls the maximum z level at which tiles are generated

Add javafx to ignore list for API check (ant check-plugins)

javafx is expected to be provided by the installed Java distribution, be it our
installers, one provided by OpenWebStart, or installed by the user.

Fix #23290: Use checks in checkgroups when looking for out-of-region tags

Also fix an i18n issue and update a test to use a key that is currently invalid
in a region.

Fix #23290: When an object is not in the appropriate region based off of the center of its bbox, check all the nodes.

This does not appear to have a significant performance impact; this may change as
more region specific presets are created.

Fix #23772: Fix logging issue which indicated that a dependency was not found

Fix #23828: Very slow wireframe view with large data set

This occurred since we were drawing every object in every relation (including
nodes of ways) even if those objects were not in view. We fix that by only
drawing objects that are inside the current viewing area.

Fix #23251: Crossing preset: Change label for crossing_ref

The crossing_ref tag is not constrained to the UK.

Fix #21333: Extend SharpAngles test to railways

Fix #23825: UI appears to freeze when a multi-select option is used

There are two problems fixed here:

1. The ListSelectionListener gets called twice; this is fixed by waiting for the list value to stop changing.
2. The act of applyChangeTags clones any primitive that might be affected by the tag change of the primitive. This can get pretty expensive if relations are involved. This is fixed by cloning the primitive in a different thread.