Modify

Opened 3 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#23988 closed enhancement (fixed)

Enable Authorize now (Fully automatic) button for OpenHistoricalMap endpoints

Reported by: Rub21 Owned by: team
Priority: normal Milestone: 24.10
Component: Core Version:
Keywords: Cc: 1ec5

Description

Hey JOSM team,

There are some issues with logging into OpenHistoricalMap in JOSM. Currently, JOSM is hardcoded for https://www.openhistoricalmap.org/api, but some users have been trying to use the alternative API endpoint, https://api.openhistoricalmap.org/api. but it did not work, Is there a possibility to add this alternative API endpoint as well? ir order to activate the "Authorize now (Fully automatic)" button for login.

issue reported: https://github.com/OpenHistoricalMap/issues/issues/901

I’ve been testing this the following peace of code on my local setup JOSM and works well for both https://www.openhistoricalmap.org/api and https://api.openhistoricalmap.org/api at this line:

https://github.com/JOSM/josm/blob/master/src/org/openstreetmap/josm/data/oauth/OAuthParameters.java#L134

            case "https://www.openhistoricalmap.org/api":
            case "https://api.openhistoricalmap.org/api":
                // clientId provided by 1ec5 (Minh Nguyễn)
                clientId = "Hl5yIhFS-Egj6aY7A35ouLOuZl0EHjj8JJQQ46IO96E";
                clientSecret = null;
                break;

could be possible to add the line case "https://api.openhistoricalmap.org/api":?

Attachments (0)

Change History (2)

comment:1 by taylor.smock, 3 weeks ago

Resolution: fixed
Status: newclosed

In 19253/josm:

Fix #23988: Add api.openhistoricalmap.org as a possible endpoint for OHM when getting the default client id (patch by Rub21)

comment:2 by taylor.smock, 3 weeks ago

Milestone: 24.10

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.