[WIP patch] Filter downloaded notes

[skyper]

It would be nice to filter notes and to only download requested. Several filter options come to my mind:

• by user (exclude + only mentioned)
• by status
  • I often want to get rid of closed ones as the system gets quite slow with lots of notes.
• by time (span of time, creation + closed)

Maybe even a combination would be cool in order to find only the notes closed by a certain user in a specific timespan.

[Don-vip]

upstream ticket: ​https://github.com/iandees/josm-notes/issues/24

[skyper]

As notes is integrated into core this enhancement request is back.

P.S.: Do we need an new component "Core notes" ?

[skyper]

See also #9907 with a similar scenario.

[Don-vip]

Replying to skyper:

P.S.: Do we need an new component "Core notes" ?

I will rename the "plugin notes" component to "core notes" when we deprecate the plugin.

@ToeBee: can we do that now, or are there some features in the plugin we don't offer yet in core?

[ToeBee]

I'd be fine with renaming. I think the only feature that hasn't been put into core yet is to use the API search functionality to download notes.

[skyper]

Replying to Don-vip:

Replying to skyper:

P.S.: Do we need an new component "Core notes" ?

I will rename the "plugin notes" component to "core notes" when we deprecate the plugin.

Well, I can live with "plugin notes", so far, and enhancements might be valid for both.

[skyper]

Replying to ToeBee:

I'd be fine with renaming. I think the only feature that hasn't been put into core yet is to use the API search functionality to download notes.

Did you implement "Open in Webbrowser", yet, or is there at least the id visible ?

By the way, I can only download and open new notes but all other actions are unavailable (greyed out) atm with r7787. Is this intended or should I open a new ticket ?

[Don-vip]

The Notes API is still very limited. We can only search for notes on text and comments, not on users and dates.
There are a few tickets aiming at improving the Notes API:

• ​#486
• ​#801
• ​#1194

[skyper]

There were some enhancements committed to search by user and dates, see ​#1955

[skyper]

According to the API description, searching aka filtered download is now possible. See ​API_v0.6#Search_for_notes:_GET_/api/0.6/notes/search.

[Don-vip]

Ticket #20583 has been marked as a duplicate of this ticket.

[simon04]

/api/0.6/notes/search does not support filtering by a bounding box, e.g., ​https://api.openstreetmap.org/api/0.6/notes/search?bbox=11,47,12,48&q=trail

The UI could be inspired by the changeset query dialog:

[NoteRoamer]

I'm a bit uncertain if this issue is about filtering notes before downloading or after downloading. Title suggests after but content seems to be about before. I will assume before.

I'm posting to let anyone interested know that I'm working on an action that will use some more features of the current OSM API to select which notes to download. When done and tested it should replace the current "Search notes..." action.

The current state is that matching on a string and/or a username works. It is also possible to change some settings for this one query (or use the defaults from preferences). It should be usable and should not have any negative effects. It probably is lacking in the UI and several features of the OSM API is still missing.

I will attach a patch for what I have so far, any comments are welcome.

[NoteRoamer]

Work In Progress on new notes download action.