WMS layer handling

[stoecker]

Currently WMS layers are hardcoded in WMS URL. This works, but leaves room for improvement. Suggestions:

• Introduce <layers> tag and {layers} for URL and allow to separate URL and layers. For each layer a boolean should tell whether it is used or not (and default, i.e. in Maps, or not). Possible layout for maps page:

    <layers>
      <layer value="strassen" name="Streets" default="true"/>
    </layers>
  

• Later we may add feature to select layers inside of JOSM from imagery menu (requires some work regarding caching as well).

[wiktorn]

I'm thinking about changing how the WMS imageries are provided. What I think is, that we could store the GetCapabilities URL, and then store:

• layers
• styles
• custom headers

etc. in preferences and in maps page.

This I could possibly do as an extension to wms_endpoint imagery type.

The next thing I'd like to do, is to provide ability to share all the settings outside the preferences - though some JSON string.

[bastiK]

Replying to wiktorn:

I'm thinking about changing how the WMS imageries are provided. What I think is, that we could store the GetCapabilities URL, and then store:

• layers
• styles
• custom headers

etc. in preferences and in maps page.

Right, good idea!

The GetCapabilities document can be quite large and cause considerable delay when WMS layer is added. (Think of problems with Bing attribution.) We could generate the current template-URL for image download as an intermediate step and save it in cache.

The next thing I'd like to do, is to provide ability to share all the settings outside the preferences - though some JSON string.

This should be possible in any case by saving the layer as a session.

[wiktorn]

In 13733/josm:

Imagery definition refactor

Extend imagery definitions by:

• allowing setting default layers for WMS_ENDPOINT and WMTS
• allowing setting minimum expires time for tile for this imagery
• allowing setting custom headers that will be sent for all requests

(get map, get capabilities) for this imagery

Additional changes in code:

• use TileJobOptions to pass miscellaneous options to loaders
• refactor WMSImagery to use SAX parser

See: #15981, #7953, #16224, #15940, #16249

[wiktorn]

In 13734/josm:

GUI for imagery definitions refactor

Extend preferences panel by:

• allowing setting default layers for WMS / WMTS
• allowing setting minimum expires (expert mode)
• allowing setting custom headers (expert mode)

See: #15981, #7953, #16224, #15940, #16249