Modify

Opened 12 years ago

Closed 12 years ago

#7952 closed defect (fixed)

[PATCH] add a checkbox for Antialiasing in wireframe mode

Reported by: Cobra Owned by: team
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

After switching to the wireframe mode osm data is drawn as if antialiasing was disabled.

Attachments (1)

antialiasing_v0-5538.patch (5.4 KB ) - added by Cobra 12 years ago.
adds checkboxes for antialiasing preferences for wireframe mode and gpx layers

Download all attachments as: .zip

Change History (8)

comment:1 by Don-vip, 12 years ago

What is the value of your "mappaint.wireframe.use-antialiasing" property ? If if does not exist, set it to true and check again :)

Last edited 12 years ago by Don-vip (previous) (diff)

comment:2 by Don-vip, 12 years ago

Resolution: invalid
Status: newclosed

comment:3 by Cobra, 12 years ago

you're right. But wouldn't it be nice to set both to true when the "normal" antialiasing is enabled in the settings?

comment:4 by Don-vip, 12 years ago

I think it's for performance reasons as users probably want JOSM to be as smooth as possible in wireframe mode.

comment:5 by Cobra, 12 years ago

Resolution: invalid
Status: closedreopened
Summary: Antialiasing doesn't work in wireframe mode[PATCH] add a checkbox for Antialiasing in wireframe mode

I've created a patch which adds a checkbox for antialiasing in wireframe mode and another one for antialiasing for GPX layers. The preferences themselves are already implemented, but hidden behind their keys in the advanced settings tab.
This patch will make them visible to normal users when expert mode is activated.

Antialiasing can't be toggled per layer, source:trunk/src/org/openstreetmap/josm/gui/layer/GpxLayer.java does only check this preference globally. I think this is reasonable behaviour, so I didn't change it. The checkbox in the layer customization dialog will set the global preference instead.

by Cobra, 12 years ago

Attachment: antialiasing_v0-5538.patch added

adds checkboxes for antialiasing preferences for wireframe mode and gpx layers

comment:6 by Don-vip, 12 years ago

Thanks for the patch !

comment:7 by Don-vip, 12 years ago

Resolution: fixed
Status: reopenedclosed

In 5568/josm:

fix #7952 - GUI expert settings for enabling GPX/wireframe antialiasing (patch by Cobra)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.