Modify ↓

Opened 14 years ago

Last modified 4 years ago

#6102 new defect

Non-Connected way checks in validator needs to be projection independent

Reported by: Nakor Owned by:
Priority: major Milestone:
Component: Core validator Version: latest
Keywords: unconnected_way Cc:

Description (last modified by simon04)

If you run validator the attached file in 3782 it correctly detects "Way end node near other highway".

In 3976 it does not detect it.

Attachments (2)

validator_bug.osm​ (151.3 KB ) - added by Nakor 14 years ago.
UnconnectedWays.diff​ (3.6 KB ) - added by Nakor 14 years ago.
patch

Download all attachments as: .zip

Change History (21)

by Nakor, 14 years ago

Attachment: validator_bug.osm​ added

comment:1 by skyper, 14 years ago

Component: Core → Core validator

comment:2 by skyper, 14 years ago

In r3992 it does not find any "way end node near other way" anymore.

comment:3 by skyper, 14 years ago

strange just some minutes ago it worked for some ways but now it does not.

r4001

comment:4 by Zibik, 14 years ago

Hello

I have the same problem with validator...

comment:5 by Nakor, 14 years ago

Summary: Validator won't detect non connected highways → Validator won't detect non connected highways anymore

3921 is OK
3925 has the bug

comment:6 by stoecker, 14 years ago

NOTE: Error due to scaling factor change for mercator code?

comment:7 by Nakor, 14 years ago

I tried to narrow it down to a precise revision:

  • 3921 works fine
  • 3922 is broken

by Nakor, 14 years ago

Attachment: UnconnectedWays.diff​ added

patch

comment:8 by Nakor, 14 years ago

Owner: changed from team to Nakor
Status: new → assigned
Summary: Validator won't detect non connected highways anymore → [patch] Validator won't detect non connected highways anymore

@stoecker this is the reason. Attached is a patch that fixes the issue

comment:9 by Nakor, 14 years ago

Summary: [patch] Validator won't detect non connected highways anymore → [incomplete patch] Validator won't detect non connected highways anymore

There is something more. The patch works on small examples but get stuck on big files.

comment:10 by stoecker, 14 years ago

In [4034/josm]:

see #6102 - partial fix for nearby node checks

comment:11 by stoecker, 14 years ago

The code depends on display projection. This is not really usable. It either should rely on direct LatLon calculations (e.g. greatCircleDistance() or force e.g. mercator projection for calculations.

comment:12 by stoecker, 14 years ago

Summary: [incomplete patch] Validator won't detect non connected highways anymore → Non-Connected way checks in validator needs to be projection independent

comment:13 by Nakor, 14 years ago

Owner: Nakor removed
Status: assigned → new

comment:14 by simon04, 13 years ago

Description: modified (diff)
Keywords: UnconnectedWays added

comment:15 by simon04, 13 years ago

Keywords: unconnected_way added; UnconnectedWays removed

comment:16 by GerdP, 5 years ago

In 15344/josm:

see #6102, #11778: Improve UNCONNECTED_WAYS test

  • avoid to fill QuadBuckets structure with nodes outside downloaded area
  • reduce dependence on projection, calculate distance as greatCircleDistance
  • check if barrier is between unconnected highways
  • don't ignore nodes which are only "connected" via a long detour (4 x mindist), this replaces the method Node.isConnectedTo() which counted hops in a rather unpredictable way.
  • fix error in Geometry.addIntersections() which didn't return the intersection node when parameter test was true
  • don't report ways with different layer=* values

Test now typically produces a lot more warnings, esp. for sidewalks and for service roads like service=parking_aisle. Not sure if the latter should be supressed...

comment:17 by skyper, 5 years ago

Anything left todo ?

comment:18 by GerdP, 5 years ago

Not sure. Some calculation are still done with projecte values. What would be a good test case?

comment:19 by skyper, 4 years ago

See #19568 for a regression. railway=platform got removed.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none) to the specified user.
Next status will be 'needinfo'. The owner will be changed from (none) to Nakor.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.