Opened 14 years ago
Closed 13 years ago
#5216 closed enhancement (needinfo)
[patch needs rework] shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension)
| Reported by: | dieterdreist | Owned by: | bilbo |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core multipoly | Version: | latest |
| Keywords: | shortcut mirror | Cc: |
Description
Strangely someone must have decided to change the shortcut for add node. I has become ALT+SHIFT+A instead of A. This is horrible. You have to change all the time when editing. Please don't change the mostly used shortcuts. IMHO this is a big usability fail.
Attachments (1)
Change History (13)
comment:1 by , 14 years ago
| Component: | Core → Plugin |
|---|---|
| Summary: | shortcut for add nodes changed → shortcut for add nodes changed by "convert to multipolygon"-extension |
comment:2 by , 14 years ago
| Component: | Plugin → Plugin multipoly |
|---|---|
| Owner: | changed from to |
comment:4 by , 14 years ago
| Keywords: | mirror added; add nodes removed |
|---|---|
| Priority: | major → normal |
| Summary: | shortcut for add nodes changed by "convert to multipolygon"-extension → shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension) |
| Type: | defect → enhancement |
Now it conflicts with mirror but is silently moved.
comment:6 by , 14 years ago
Added patch that will fix the conflict - the default shortcut will be changed to Alt+M (it is not used by anything in default installation)
Note that all shortcuts can be redefined (actually, some of them like "copy" and "paste" can't, but this one can) in the settings.
Also, the patch updates the old comment in the source code so it will describe what the class does now, not what the class have done about year ago before people started improving it.
comment:7 by , 14 years ago
| Summary: | shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension) → [patch] shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension) |
|---|
comment:8 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
| Summary: | [patch] shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension) → [patch needs rework] shortcut is already use by mirror (WAS: shortcut for add nodes changed by "convert to multipolygon"-extension) |
Is this really necessary? I have no related shortcut conflict here. Also the Shortcut call should not directly use a KeyEvent-mask value.
comment:9 by , 13 years ago
| Owner: | changed from to |
|---|
comment:10 by , 13 years ago
I am not sure what exactly the patch does. This ticket was changed several times by a lot of people. I don't have the original issue any more (that "add node" was not "a" for some time).
For your info, these are the current silent shortcut conflicts that I get, but I don't perceive them as problems:
Silent shortcut conflict: 'mapmode:parallel' moved by 'tools:pdfimport' to 'Alt+Umschalt+P'.
Silent shortcut conflict: 'subwindow:properties' moved by 'mapmode:parallel' to 'Alt+D'.
Silent shortcut conflict: 'properties:add' moved by 'menu:PicLayer' to 'Alt+G'.
Silent shortcut conflict: 'subwindow:authors' moved by 'tools:taggingresettester' to 'Alt+J'.
Keystroke alt pressed J is already assigned to utilsplugin2.ExtractPointAction@e9493a, will be overridden by org.openstreetmap.josm.gui.dialogs.ToggleDialog$ToggleDialogAction@1e2b67c
Silent shortcut conflict: 'subwindow:conflict' moved by 'menu:Public Transport' to 'Alt+Umschalt+C'.
I don't know how is the shortcut conflict handling, but preferably the shortcuts from the main module should not be overridden by plugins (or only on user confirmation). Maybe this is already the case.
comment:11 by , 13 years ago
| Owner: | changed from to |
|---|
sorry, I got confused because I was marked as responsible for some seconds ;-), re-set bilbo.
comment:12 by , 13 years ago
| Resolution: | → needinfo |
|---|---|
| Status: | needinfo → closed |
Replying to dieterdreist:
:: This is caused by the "convert to multipolygon"-plugin-extension. Please change the default there!