Unsaved changes dialog should be shown only when layer is backed by a file

[dieterdreist]

I uploaded my modifications, there was no error, but when I try to close, it says: "there are unsaved changes". I tried to reupload, but: "no modifications to upload", afterwards still the same error on exit (unsaved changes).

[stoecker]

Correct. The upload process itself causes changes in the data set. If I remember correctly the warning text also tells this.

[dieterdreist]

Replying to stoecker:

Correct. The upload process itself causes changes in the data set. If I remember correctly the warning text also tells this.

This is possible, but it is definitely a bug: there shouldn't be the alert for dataloss on close if there is no data you "loose". This dialog should be suppressed, if the only change you did is having uploaded a changeset. Otherwise the dialog is of no use anymore: it will give you an alert everytime you close (and previously uploaded at least one time), not regarding whether you loose data or not.

[Gubaer]

There *is* data you loose. When you upload the server assigns new IDs and modifies the state of your primitives. Now you have these changes in your local dataset and your layer might be assigend to a file and for *this* file you have unsafed data.

will give you an alert everytime you close (and previously uploaded at least one time), not regarding whether you loose data or not.

No, not everytime. If you save locally there won't be an asterix (*) in the title bar and if you quit JOSM you won't get a warning.

I see just one optimiziation here: for data layers which aren't linked to a file one could indeed suppress the warning.

[dieterdreist]

Replying to Gubaer:

There *is* data you loose. When you upload the server assigns new IDs and modifies the state of your primitives. Now you have these changes in your local dataset and your layer might be assigend to a file and for *this* file you have unsafed data.

will give you an alert everytime you close (and previously uploaded at least one time), not regarding whether you loose data or not.

No, not everytime. If you save locally there won't be an asterix (*) in the title bar and if you quit JOSM you won't get a warning.

I see just one optimiziation here: for data layers which aren't linked to a file one could indeed suppress the warning.

OK; I hadn't thought of people saving to local disc. So the message is correct if there is a file associated. I agree though that the message should be suppressed if no file is associated.

[Daeron]

The unsaved changes dialog only pops up if there has been some editing done in the session, whether the data has been uploaded or not. But if new data has been downloaded but not edited, the dialog never appears and the downloaded data is lost (from the file).

I suggest that every time a new data is downloaded, the layer is marked unsaved, but the dialog is only shown, if the data was originally loaded from a file (or merged with a layer loaded from a file).

That way the dialog would be much more useful, as now it annoys when you just have downloaded data from the server and done some modifications and sent them back, but if you just wanted to download more data to a saved file, the dialog never appears.

[anonymous]

Of course the warning (or another warning) should stay if you downloaded some data, made some changes, and didn't upload the changes again so far. In this case, the layer isn't backed by a file.

[RussNelson]

This is a defect and needs to be fixed. If you *only* download from the API, make a change, and (successfully) upload, then you shouldn't be prompted to save it to a file.

[Gubaer]

Fixed in r2025