[PATCH] Support writing to jpeg, the new EXIF GPS metadata managed in Josm

[StephaneP]

Since #24238 is merged, new GPS metadata are available in ImageEntry.
This patch add support for these new tags in the photo_geotagging plugin.
new tags:

• GPSDOP
• GPSDifferential
• GPSHPositioningError
• GPSMeasureMode
• GPSMapDatum (with the EPSG code)
• GPSTrack

!! This patch should not be merged before apache-commons plugin is updated to use apache commons-imaging 1.0.0-alpha6 !!

Question:
I simply add more parameters to setExifGPSTag. Should I overload it?

[stoecker]

You need to adapt build.xml and pom.xml to set the new minimum josm version

I simply add more parameters to setExifGPSTag. Should I overload it?

I'd pass the ImageEntry instead of extracting the data and passing it individually.

!! This patch should not be merged before apache-commons plugin is updated to use apache commons-imaging 1.0.0-alpha6 !!

alpha6 is not yet released...

[StephaneP]

Replying to stoecker:

I'd pass the ImageEntry instead of extracting the data and passing it individually.

Thanks, I'm working on it.
I have some trouble to run the unit tests.

....\ExifGPSTaggerTest.java:61: error: cannot find symbol
    [javac]         final File in = new File(TestUtils.getTestDataRoot(), "IMG_7250_small.JPG");
    [javac]                                  ^

alpha6 is not yet released...

I know :-(
I hope this release will be available in the coming days.
The other way would be to comment the part related to GpsTagConstants.GPS_TAG_GPS_HOR_POSITIONING_ERROR until it's available:

[stoecker]

Hello,

I have some trouble to run the unit tests.

....\ExifGPSTaggerTest.java:61: error: cannot find symbol
    [javac]         final File in = new File(TestUtils.getTestDataRoot(), "IMG_7250_small.JPG");
    [javac]                                  ^

Hah, welcome in the club. Im using rolling release openSUSE Tumbleweed and on my system the unit test work/work not/work/work not. Each time a new error message which either goes away or not. JUnit seeems to break extremely easy. Which also means I have to rely on the server run tests to know if something is wrong in the repository (i.e. incompatible versions downloaded). I stopped to investigate, as spending hours to fix it, only to discover that the next system update again breaks it is wasted time.

For me it currently says org.junit.platform.commons.JUnitException: TestEngine with ID 'junit-jupiter' failed to discover tests.

Sometimes when "ant test" fails "mvn test" still works. ATM for me both fail.

I don't like that at all, but I also have no solution for this.

[StephaneP]

Here is a new patch, with:

• pom.xml and build.xml updated with the min Josm release
• setExifGPSTag use ImageEntry instead of separate parameters
• Various checkstyle fixes

I've search if there is a way to set a minimum version for apache-commons, but I didn't find.
In the unit test, I'd like to test the value written in the jpg file, but as I can't run these tests....

Replying to stoecker:

Hah, welcome in the club.

With mvn test there were no test detected. I had to set the classes to public (explanations found ​here). Then it failed with NoClassDefFoundError com/github/tomakehurst/wiremock/core/Options. I don't have the knowledge to investigate more.
If with your skill, you didn't find a way to fix all these unit test errors, I won't even try :-)

[stoecker]

In 36436/osm:

see #24278 - add new EXIF metadata (patch by StephaneP, modified), fix mvn test function

[stoecker]

Please try before I build a dist file. Tests should work with "mvn" now. Seems only some dependencies have been missing.

[StephaneP]

Replying to stoecker:

Please try before I build a dist file. Tests should work with "mvn" now. Seems only some dependencies have been missing.

Thank you for the update for the tests.
It still complains with a missing symbol :

cannot find symbol
[ERROR]   symbol:   variable GPS_TAG_GPS_HOR_POSITIONING_ERROR
[ERROR]   location: class org.apache.commons.imaging.formats.tiff.constants.GpsTagConstants

GPS_TAG_GPS_HOR_POSITIONING_ERROR was added in this alpha-6 release. I will investigate more later in the week.

[stoecker]

In 36437/osm:

see #11902, #24278 - fix skipped unit test

[stoecker]

For me all tests are fine...

[StephaneP]

This morning, the tests are passing.
Thanks

[stoecker]

Released.