Opened 7 weeks ago
Last modified 2 weeks ago
#23949 new defect
[PATCH] sidewalk=* missing
Reported by: | anonymous | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Internal preset | Version: | tested |
Keywords: | sidewalk regression | Cc: | taylor.smock |
Description
Why was “sidewalk=both/left/right/no” replaced by “sidewalk:both/left/right=*” in the template for “highway=residential” in version 19230? That would have been fine as an addition, but replacing “sidewalk=*” completely seems wrong.
Attachments (1)
Change History (9)
comment:1 by , 7 weeks ago
Cc: | added |
---|---|
Component: | Core → Internal preset |
Keywords: | sidewalk regression added |
Version: | latest → tested |
comment:2 by , 7 weeks ago
Values for sidewalk
: both,left,right,no,separate
.
Values for sidewalk:<side>
: yes,no,separate
(side can be left
, right
, both
)
sidewalk=both
->sidewalk:both=yes
sidewalk=left
->sidewalk:left=yes
+sidewalk:right=no
sidewalk=right
->sidewalk:right=yes
+sidewalk:left=no
sidewalk=separate
->sidewalk:left=<separate|no>
+sidewalk:right=<separate|no>
sidewalk=no
->sidewalk:left=no
|sidewalk:right=no
An important note is that sidewalk
was not removed from validation (it was instead added to tags to ignore).
My reasoning as to removing it from the preset:
- I'm adding 3 tags which can be used to describe the existing tag values
- The new tags have fewer "unknowns" than the existing tag (specifically as it relates to
sidewalk=separate
) - People who map sidewalks frequently can still manually add
sidewalk=*
tags
comment:3 by , 7 weeks ago
this is no reason for me to remove the established tag “sidewalk=*” (4 015 085 x in use), so it should be added again
comment:4 by , 7 weeks ago
Actually, unlike cycleway=*
, sidewalk=no
and sidewalk=separate
are not ambiguous as the former is clearly defined to mean no sidewalk on neither side and the latter means that all sidewalks are mapped as separate objects. Actually, we do not need sidewalk:both=*
at all.
Why should I use two tags if one is enough at least in case of sidewalk=both/left/right/no
?
sidewalk=*
are the only tags with an accepted proposal while especially sidewalk:both=*
looks like yet another invention by StreetComplete. Looking at the numbers of uses, sidewalk=*
is still used around four times more than all three other keys together (not counting that sidewalk:left
and sidewalk:right
always have to be used at the same time).
An established tag should not be removed from the default presets and hidden for less experienced users, so I kindly ask you to add it back.
comment:5 by , 7 weeks ago
Summary: | sidewalk → sidewalk=* missing |
---|
comment:6 by , 6 weeks ago
That's how I see it too.
I don't think it's good to remove an established and documented tag just to impose your own style.
@taylor.smock please add sidewalk=* again.
by , 3 weeks ago
Attachment: | restore_sidewalk.patch added |
---|
Patch restoring the sidewalk=* field on highway=residential, removing sidewalk:both=*
comment:7 by , 3 weeks ago
Summary: | sidewalk=* missing → [PATCH] sidewalk=* missing |
---|
comment:8 by , 2 weeks ago
I am not sure if we should remove sidewalk:both=*
again or just leave it as additional option as the key is in use.
Anyway, we need to update the validator warnings regarding sidewalk. Combinations of sidewalk:both
and sidewalk
, sidewalk:right
or sidewalk:left
should be flagged, see #22023. Additionally, sidewalk:left
and sidewalk:right
should always be combined and if only one is tagged it should be flagged.
Good, question. I did not spot the removal of
sidewalk=*
in r19222 and think it should be re-added but maybe Taylor had a good reason to remove it which I am not aware of.