Changeset 19222 in josm

Timestamp:

2024-09-13T12:47:56+02:00 (2 months ago)

Author:

taylor.smock

Message:

Add/ignore popular tags

Ignore:

• admin_type:PH: Highly localized to the Philippines
• residential:condominium: Deprecated -- wiki suggests residential=apartments + condo=*
• sidewalk: This is replaced by sidewalk:both, but is still valid tagging.

Add:

• managed (to wetland, wood, fell, and heath)
• sidewalk:{both|left|right}: We already had validator rules for these, this just adds them to presets. Note that sidewalk and sidewalk:both are similar, but sidewalk=separate is unspecific as to the side of the sidewalk.

Location:

trunk/resources/data

Files:

• defaultpresets.xml (modified) (6 diffs)
• validator/deprecated.mapcss (modified) (1 diff)
• validator/ignoretags.cfg (modified) (2 diffs)

trunk/resources/data/defaultpresets.xml

@@ -533 +533 @@
         </optional>
     </chunk>
+    <chunk id="managed">
+        <optional>
+            <combo key="managed" text="Managed" values="no,yes,grazing,undergrowth,mowing,scientific" values_context="Key:managed" />
+        </optional>
+    </chunk>
     <chunk id="substance">
         <combo key="substance" text="Substance" values="water,hot_water,steam,sewage,gas,oil" values_sort="false" values_searchable="true" />
@@ -936 +941 @@
                 <text key="width" text="Width (meters)" />
                 <combo key="bus_bay" text="Bus bay" values="both,left,right" />
-                <combo key="sidewalk" text="Sidewalk" values="both,left,right,no,separate" values_context="sidewalk" />
+                <combo key="sidewalk:both" text="Sidewalk (both)" values="yes,no,separate" values_context="sidewalk" />
+                <combo key="sidewalk:left" text="Sidewalk (left)" values="yes,no,separate" values_context="sidewalk" />
+                <combo key="sidewalk:right" text="Sidewalk (right)" values="yes,no,separate" values_context="sidewalk" />
                 <checkgroup columns="3">
                     <check key="dual_carriageway" text="Divided highway" disable_off="true" />
@@ -2405 +2412 @@
             <combo key="wetland" text="Type" values="bog,fen,mangrove,marsh,reedbed,saltern,saltmarsh,string_bog,swamp,tidalflat,wet_meadow" values_searchable="true" />
             <check key="seasonal" text="Seasonal" disable_off="true" />
+            <reference ref="managed" />
         </item> <!-- Wetland -->
         <item name="Mud" icon="presets/landuse/mud.svg" type="closedway,multipolygon" preset_name_label="true">
@@ -9287 +9295 @@
             <text key="name" text="Name" />
             <reference ref="leaf" />
+            <reference ref="managed" />
         </item> <!-- Wood -->
         <item name="Forest" icon="presets/landmark/forest.svg" type="closedway,multipolygon" preset_name_label="true">
@@ -9340 +9349 @@
             <key key="natural" value="fell" />
             <text key="name" text="Name" />
+            <reference ref="managed" />
         </item> <!-- Fell -->
         <item name="Scrub" icon="presets/landuse/scrub.svg" type="closedway,multipolygon" preset_name_label="true">
@@ -9359 +9369 @@
             <key key="natural" value="heath" />
             <text key="name" text="Name" />
+            <reference ref="managed" />
         </item> <!-- Heath -->
         <item name="Sand" icon="presets/landuse/sand.svg" type="closedway,multipolygon" preset_name_label="true">

trunk/resources/data/validator/deprecated.mapcss

@@ -2578 +2578 @@
   suggestAlternative: "oneway:bicycle=no + cycleway:right=* + cycleway:left=* + cycleway:right:oneway=-1";
 }
+*[residential=condominium] {
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  group: tr("deprecated tagging");
+  suggestAlternative: "residential=apartments + condo=*"
+}
 
 /* When tags are deprecated they should be added to ignoretags.cfg too. */

trunk/resources/data/validator/ignoretags.cfg

@@ -169 +169 @@
 E:genus:de
 E:heritage:operator
+E:admin_type:PH
+E:sidewalk
 ;
 ; Ignore valid and semi-valid keys that end with...
@@ -753 +755 @@
 E:ref:gnis
 E:tiger:PLACENS
+K:residential=condominium
 ;
 ; Tags not yet decided (to remove from this section when added or moved up when deprecated)