Error not fully downloaded referrers when opening from osm file

[SanderH]

What steps will reproduce the problem?

1. Get JOSM version since 19078
2. Download a part of OSM
3. Delete an object (no issue)
4. Save to osm file
5. Delete the layer
6. Open the saved osm file
7. Delete an object (and gets an error message)

What is the expected result?

No message about not fully downloaded referrers

What happens instead?

Get a message that the referrers are not fully downloaded

Please provide any additional information below. Attach a screenshot if possible.

I think while solving issue #4142 forgot to save the downloaded state to the osm file causing the popup to appear unwanted.
Noticed this issue when my JOSM screen went fully black, so had to terminate the application. When restoring from the saved files, I was confronted with this annoying message constantly.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-06-03 18:08:14 +0200 (Mon, 03 Jun 2024)
Revision:19096
Build-Date:2024-06-05 01:31:15
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19096 en) Windows 11 64-Bit
OS Build number: Windows 10 Pro 23H2 (22631)
Memory Usage: 544 MB / 48000 MB (257 MB allocated, but free)
Java version: 17.0.11+9-LTS, Red Hat, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1644×1042 (scaling 1.00×1.00)
Maximum Screen Size: 1644×1042
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Dsun.java2d.opengl=True, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED]
Dataset consistency test: No problems found

Plugins:
+ DirectDownload (36178)
+ FixAddresses (36258)
+ Mapillary (3904)
+ OpeningHoursEditor (36258)
+ PicLayer (1.0.3)
+ apache-commons (36176)
+ apache-http (36176)
+ ejml (36176)
+ geotools (36176)
+ geotools-wfs (26.2)
+ graphview (36258)
+ jackson (36176)
+ jaxb (36118)
+ jna (36176)
+ jts (36004)
+ measurement (36256)
+ nl-pdok-report (0.5)
+ nl_bag (0.9)
+ ods-bag (0.7.0)
+ opendata (36256)
+ opendataservices (0.7.0)
+ photo_geotagging (36178)
+ photoadjust (36200)
+ poly (36126)
+ reverter (36256)
+ scripting (v0.3.1)
+ turnlanes (36206)
+ undelete (36226)
+ utilsplugin2 (36241)
+ waydownloader (36196)

Tagging presets:
+ C:\Users\Sander\Tools\JOSM\Presets_Monuments.zip

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Potlatch2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/AddressValidator&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
+ https://signs.tools4osm.nl/JOSM/Styles_Traffic_signs-style.mapcss
- http://mijndev.openstreetmap.nl/~allroads/JOSM/Styles/Road_Extended_JOSM_style.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Noname&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NumberedCycleNodeNetworks&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/NumberedWalkingNodeNetworks&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&style&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features_ryg&style&zip=1
- C:\Users\Sander\Tools\JOSM\FI_traffic_signs\fisigns-all.mapcss

Validator rules:

Last errors/warnings:
- 00000.470 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.472 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00002.687 W: Unable to request certificate of https://roottest-g3.pkioverheid.nl
- 00002.860 W: Unable to request certificate of https://roottest-g3.pkioverheid.nl
- 00003.598 W: Update plugins - You updated your JOSM software. To prevent problems the plugins should be updated as well.  Update plugins now?

[GerdP]

I already expected this ticket ;)
A possible solution could be to set the flag for all objects inside the <bounds> , but the obvious problem is that such a file can be years old and thus completey out-aged.
I see no way to store the flag itself in the standard OSM xml or other export formats like osm.pbf

[anonymous]

Older OSM files is indeed a problem I didn't consider until you mentioned it.

Maybe an option to redownload the area to get any changes?
I'm often working in an area that's too big for OSM to allow download, but downloading the area again in an overpass query would be a workaround.

Was already working with the latest build and had to fix a plugin to mark everything as downloaded (getting OSM data from overpass; not filtered to cause any issues with the referrers, but mainly for the larger sizes), but other than that didn't have too many issues with it until I had to revert and got this frustrating dialog again ;(

[skyper]

See also #23749

Replying to anonymous:

Maybe an option to redownload the area to get any changes?

Yes, an optional dialog to update data loading an osm data file would be an option.