[Patch] Franchises in Korea has cuisine=Korean not cuisine=korean

[mkoniecz]

A quite minor issue - and admittedly I am not sure whether it should be reported here (never tried reporting issues in user presets)

Franchises in Korea by LuxuryCoop listed at https://josm.openstreetmap.de/wiki/Presets has

	<item icon="presets/food/restaurant.svg" name="Ebadom" ko.name="이바돔감자탕" type="node,relation,closedway,multipolygon">
		<label text="Ebadom" ko.text="이바돔감자탕"/>
		<space />
        <key key="amenity" value="restaurant"/>
        <key key="cuisine" value="Korean"/>

value="Korean" there should be value="korean"

[skyper]

Replying to mkoniecz:

A quite minor issue - and admittedly I am not sure whether it should be reported here (never tried reporting issues in user presets)

It is fine to report problems with external presets here. In this case it might be worth to also create an issue at ​https://github.com/osm-korea/Preset-Franchises_in_Korea/ linking to this ticket.

Additionally to Korean I find <key key="cuisine" value="Japanese;shabu-shabu"/> which should be changed to small letters as-well.

[mkoniecz]

Thanks for tracking down repo!

I created ​https://github.com/osm-korea/Preset-Franchises_in_Korea/pull/1

In this case it might be worth to also create an issue at ​​https://github.com/osm-korea/Preset-Franchises_in_Korea/ linking to this ticket.

Impossible, that repo has forked other repo and not enabled issue tracker.

It is fine to report problems with external presets here.

Is one for each case, one for each preset or one for all problems at once preferable? I found several cases of presets having quite clear typos in them.

[skyper]

Replying to mkoniecz:

It is fine to report problems with external presets here.

Is one for each case, one for each preset or one for all problems at once preferable? I found several cases of presets having quite clear typos in them.

I would say at least separate tickets for each preset (style or rule). Clear typos in external presets (styles and rules) hosted here can be simply fixed at the corresponding wiki page. The last column at Presets (resp. Styles or Rules) is the link to the wiki page if it is hosted here. Otherwise the second column tells you where the source is hosted.

[mkoniecz]

Looking at ​https://github.com/osm-korea/Preset-Franchises_in_Korea/pull/1 and ​https://github.com/osm-korea/Preset-Franchises_in_Korea it seems not maintained - maybe it should be removed from JOSM presets if through 2025 nothing will change?

[stoecker]

If request and tickets aren't fixed disabling is fine: See last section of PresetsSource page.

[stoecker]

Reaction time should be less than two month...

[taylor.smock]

I pinged them in ​https://github.com/osm-korea/Preset-Franchises_in_Korea/pull/2, so they do respond. They may not have seen your PR.

[mkoniecz]

They responded and merged PR. Should it be enough to fix this issue?

[taylor.smock]

Fixed in ​17beffd6a2cade78c8c108c506c87761fe754c63.