Opened 11 months ago
Last modified 11 months ago
#23358 reopened enhancement
Better warning for bridge on suspicious object
Reported by: | Emvee | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | |
Keywords: | bridge aqueduct | Cc: |
Description
An Aqueduct is tagged as:
- waterway=canal
- bridge=aqueduct
- layer=1
But this triggers incorrectly a suspicious tag combination warning "bridge on suspicious object"
For an example see https://www.openstreetmap.org/way/1016984767
Notice that the validator already proposes to use add "bridge=aqueduct"
/* #11127, #13727 */ way[waterway][bridge=yes][waterway!=weir] { throwWarning: tr("{0} together with {1}", "{0.key}", "{1.tag}"); suggestAlternative: "bridge=aqueduct"; group: tr("suspicious tag combination"); fixAdd: "bridge=aqueduct"; }
It is then a strange to issue another warning after fixing this one.
Attachments (0)
Change History (5)
comment:1 by , 11 months ago
Resolution: | → worksforme |
---|---|
Status: | new → closed |
comment:2 by , 11 months ago
Keywords: | bridge aqueduct added |
---|---|
Resolution: | worksforme |
Status: | closed → reopened |
How about mentioning the possibly missing tags in the warning as a hint, e.g. bridge=* without highway=*, railway=*, waterway=*, area:highway=*, piste:type=*, type=bridge, public_transport=platform, route=ferry, man_made=pipeline, man_made=goods_conveyor, man_made=wildlife_crossing or man_made=bridge
?
comment:3 by , 11 months ago
Summary: | Exclude bridge=aqueduct from warning bridge on suspicious object → Better warning for bridge on suspicious object |
---|---|
Type: | defect → enhancement |
comment:4 by , 11 months ago
Add man_made=bridge to the aqueduct area.
On https://wiki.openstreetmap.org/wiki/Tag:bridge%3Daqueduct with man_made=-bridge is an option for the outline of an aqueduct and for the example that is the case so I did change that.
But aqueducts can be also mapped as way only and then no "man_made=bridge" should be added then. No "amenity=bridge" for "bridge=aqueduct" is true for almost all tagged aqueducts according to taginfo, https://taginfo.openstreetmap.org/tags/bridge=aqueduct#combinations.
What about adding [bridge!=aqueduct] to the problematic rule?
comment:5 by , 11 months ago
There is no warning created for ways if highway=*
, railway=*
or waterway=*
(among other tags) is present.
natural=*
is the suspicious combination in your example. Actually, I am not happy about the combination of man_made
and natural
. I do not know this aqueduct but something seems to be wrong as right now we have four man_made=bridge
next to each other and some are even overlapping (flagged as informational validator warning).
Now, here is the question if we should allow bridge=aqueduct
(or even bridge=*
) in combination with water=canal
and without man_made=bridge
.
Add
man_made=bridge
to the aqueduct area. We expectbridge
to be used in conjunction with another tag.MapCSS selector for the "problematic" rule:
*[bridge ][!highway][!area:highway][!railway][!waterway][!piste:type][type!=bridge][public_transport!=platform][route!=ferry][man_made!=pipeline][man_made!=goods_conveyor][man_made!=wildlife_crossing][man_made!=bridge]