Remove default shortcuts for Move Object actions

[GerdP]

What steps will reproduce the problem?

1. Select a way or node.
2. Open relation editor with existing members.
3. Click on a member to select it.
4. Press Shift+Down to select further member(s) until the selected members are no longer visible.
5. Use mouse to drag the mapview so that more members are visible and the original object is no longer visible, e.g. hidden by the relation editor dialog. Side effect: The relation editor looses focus.
6. Press Shift+Down again to select further member(s), note (only) that this doesn't change the selection in the relation editor.
7. Click the relation editor dialog to give back focus.
8. Press Shift+Down again to select further member(s), now that works as expected.
9. Do something with the members, e.g. remove them from the relation or reorder them.
10. Close dialog with OK.

What is the expected result?

The relation is changed, nothing else.

What happens instead?

Step 6 moves the selected way or node because Shift+Down is the shortcut for "Move objects down".

Please provide any additional information below. Attach a screenshot if possible.

I know it's worksform but I happened to move objects like this two or three times now and it is likely that you don't recognize the uninted move. There is also no warning even when I move lots of nodes like this.
Even when I notice the problem I have to undo my changes in the relation and the move or maybe Purge the moved nodes.
I've disabled the fpour shortcuts for the "Move Objects ..." action. I wasn't even aware that they exist.
Is there (still) a good reason to have these shortcuts?
Why doesn't JOSM warn when I move several objects with the shortcut like it does when I use the mouse?

Revision:18789
Build-Date:2023-08-01 13:06:18

Identification: JOSM/1.5 (18789 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 1085 MB / 1972 MB (632 MB allocated, but free)
Java version: 17.0.8+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18789, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (36079)
+ RoadSigns (36097)
+ apache-commons (36034)
+ buildings_tools (36097)
+ comfort0 (35976)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (36068)
+ jackson (36034)
+ jaxb (35952)
+ jts (36004)
+ o5m (36079)
+ opendata (36097)
+ pbf (36034)
+ poly (36097)
+ reltoolbox (36103)
+ reverter (36066)
+ undelete (36066)
+ utilsplugin2 (36097)

Validator rules:
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss
+ c:\josm\core\resources\data\validator\unnecessary.mapcss
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

Last errors/warnings:
- 00030.940 E: Failed to locate image 'Flag, Blue'
- 00030.941 E: Failed to locate image 'Flag, Blue'
- 00030.942 E: Failed to locate image 'Flag, Blue'
- 00031.020 E: Failed to locate image 'Flag, Blue'
- 00031.022 E: Failed to locate image 'Flag, Blue'
- 00031.023 E: Failed to locate image 'Flag, Blue'
- 00031.024 E: Failed to locate image 'Flag, Blue'
- 00031.034 E: Failed to locate image 'Flag, Blue'
- 00031.035 E: Failed to locate image 'Flag, Blue'
- 00031.037 E: Failed to locate image 'Flag, Blue'

[taylor.smock]

I know it's [worksforme] but I happened to move objects like this two or three times now and it is likely that you don't recognize the [unintended] move. There is also no warning even when I move lots of nodes like this.

This seems to be an alternate input mode. I can see use cases for it (for example, if I was mapping with a controller, mapping one of the joysticks/dpads to shift+direction would probably help a lot).

Even when I notice the problem I have to undo my changes in the relation and the move or maybe Purge the moved nodes.

We probably ought to allow independent commands to be undone individually (e.g., if no participating primitives were not also used in another operation, allow for that command to be undone).

Why doesn't JOSM warn when I move several objects with the shortcut like it does when I use the mouse?

No clue. I'd have to go back through history. And hope that the commit message and/or ticket are sufficiently detailed. But this could get annoying if I were to be mapping with a controller.