#23149 closed enhancement (fixed)
[patch] Add line_arrangement to power supports presets
Reported by: | francois.lacombe | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 23.11 |
Component: | Internal preset | Version: | |
Keywords: | power, utility, line arrangements | Cc: |
Description
Dear maintainers,
The key line_arrangement has been very recently reviewed on the wiki and received an approval vote.
https://wiki.openstreetmap.org/wiki/Key:line_arrangement
It allows to describe how power lines are geometrically arranged on their supports.
The post-vote cleanup is in progress and documentation is currently under completion.
It may be great to update JOSM presets as follow:
- Add the key with its eight values (horizontal, semi_horizontal, vertical, semi_vertical, triangular, delta, square and unarranged) on power and utility supports presets power=tower, power=pole, power=insulator, power=portal and power=terminal and man_made=utility_pole
- Warn about the use of line_arrangement on any other feature than a node.
Feel free to ask for any unclear point, all the best
François
Attachments (2)
Change History (15)
comment:1 by , 16 months ago
Summary: | Add line_arrnagement to power support preset → Add line_arrangement to power supports presets |
---|
comment:2 by , 16 months ago
comment:3 by , 16 months ago
Hi
Documentation in English is now stable, it's mostly about translation currently.
It is a brand new key, no outdated content was available before. The wiki was took out of the proposal.
All the best
comment:4 by , 16 months ago
Milestone: | → 23.09 |
---|
Reading the documentation, this looks like it will be fairly easy to support.
comment:5 by , 16 months ago
@francois.lacombe: What do you recon, in what order the line_arrangement
, line_attachment
and line_management
should be presented in the presets?
comment:6 by , 16 months ago
Hello
It's a good question. It may be good to put line_arrangement between the other two:
- line_attachment
- line_arrangement
- line_management
Best regards
by , 16 months ago
Attachment: | josm.patch added |
---|
comment:7 by , 16 months ago
Summary: | Add line_arrangement to power supports presets → [patch] Add line_arrangement to power supports presets |
---|
Oops, I forgot to change the file name.
Anyway, changes:
- added
line_arrangement
values from wiki - added a
line_properties
chunk forline_*
values - disabled lexicographical sorting, use the predefined order for
line_arrangement
(order by wiki) andline_attachment
(order by usage count)
Edit: Also not added to man_made=utility_pole
, it's intentional. I'm hesitant to add it since the preset is universal and I don't know if it would confuse users.
follow-up: 9 comment:8 by , 16 months ago
Hello
I don't know if it would confuse users.
I guess not: it's documented
https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dutility_pole
by , 16 months ago
Attachment: | josm_23149_v2.patch added |
---|
Can you ping me when this is done? I don't want to add tags where the documentation is currently in flux, even if it is the result of a vote and should therefore be fairly well documented; I don't want to read something that is outdated and make an easily avoidable mistake.