Modify

Opened 16 months ago

Closed 15 months ago

Last modified 14 months ago

#23149 closed enhancement (fixed)

[patch] Add line_arrangement to power supports presets

Reported by: francois.lacombe Owned by: team
Priority: normal Milestone: 23.11
Component: Internal preset Version:
Keywords: power, utility, line arrangements Cc:

Description

Dear maintainers,

The key line_arrangement has been very recently reviewed on the wiki and received an approval vote.
https://wiki.openstreetmap.org/wiki/Key:line_arrangement
It allows to describe how power lines are geometrically arranged on their supports.

The post-vote cleanup is in progress and documentation is currently under completion.
It may be great to update JOSM presets as follow:

  • Add the key with its eight values (horizontal, semi_horizontal, vertical, semi_vertical, triangular, delta, square and unarranged) on power and utility supports presets power=tower, power=pole, power=insulator, power=portal and power=terminal and man_made=utility_pole
  • Warn about the use of line_arrangement on any other feature than a node.

Feel free to ask for any unclear point, all the best

François

Attachments (2)

josm.patch (6.0 KB ) - added by gaben 16 months ago.
josm_23149_v2.patch (6.5 KB ) - added by gaben 16 months ago.

Download all attachments as: .zip

Change History (15)

comment:1 by francois.lacombe, 16 months ago

Summary: Add line_arrnagement to power support presetAdd line_arrangement to power supports presets

comment:2 by taylor.smock, 16 months ago

The post-vote cleanup is in progress and documentation is currently under completion.

Can you ping me when this is done? I don't want to add tags where the documentation is currently in flux, even if it is the result of a vote and should therefore be fairly well documented; I don't want to read something that is outdated and make an easily avoidable mistake.

comment:3 by francois.lacombe, 16 months ago

Hi

Documentation in English is now stable, it's mostly about translation currently.
It is a brand new key, no outdated content was available before. The wiki was took out of the proposal.

All the best

comment:4 by taylor.smock, 16 months ago

Milestone: 23.09

Reading the documentation, this looks like it will be fairly easy to support.

comment:5 by gaben, 16 months ago

@francois.lacombe: What do you recon, in what order the line_arrangement, line_attachment and line_management should be presented in the presets?

comment:6 by francois.lacombe, 16 months ago

Hello

It's a good question. It may be good to put line_arrangement between the other two:

  • line_attachment
  • line_arrangement
  • line_management

Best regards

by gaben, 16 months ago

Attachment: josm.patch added

comment:7 by gaben, 16 months ago

Summary: Add line_arrangement to power supports presets[patch] Add line_arrangement to power supports presets

Oops, I forgot to change the file name.

Anyway, changes:

  • added line_arrangement values from wiki
  • added a line_properties chunk for line_* values
  • disabled lexicographical sorting, use the predefined order for
    • line_arrangement (order by wiki) and
    • line_attachment (order by usage count)

Edit: Also not added to man_made=utility_pole, it's intentional. I'm hesitant to add it since the preset is universal and I don't know if it would confuse users.

Last edited 16 months ago by gaben (previous) (diff)

comment:8 by francois.lacombe, 16 months ago

Hello

I don't know if it would confuse users.

I guess not: it's documented
https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dutility_pole

in reply to:  8 comment:9 by gaben, 16 months ago

Thank you! I added line_properties to man_made=utility_pole.

by gaben, 16 months ago

Attachment: josm_23149_v2.patch added

comment:10 by francois.lacombe, 16 months ago

That's really great, thank you!

comment:11 by taylor.smock, 15 months ago

Resolution: fixed
Status: newclosed

In 18834/josm:

Fix #23149: Add line_arrangement to power supports presets (patch by gaben)

comment:12 by taylor.smock, 15 months ago

Milestone: 23.0923.10

Ticket retargeted after milestone deleted

comment:13 by taylor.smock, 14 months ago

Milestone: 23.1023.11

Ticket retargeted after milestone deleted

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.