regression: validation layer not removed on layer removal

[dieterdreist]

What steps will reproduce the problem?

1. download some data, modify it
2. upload the data (and have some problems so that a validation layer is created)
3. delete the data layer

What is the expected result?

the validation layer is also removed, as it was the case some months ago

What happens instead?

the validation layer remains

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-07-10 22:19:01 +0200 (Mon, 10 Jul 2023)
Revision:18776
Build-Date:2023-07-11 01:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18776 en) Mac OS X 13.4.1
OS Build number: macOS 13.4.1 (22F82)
Memory Usage: 1066 MB / 4096 MB (457 MB allocated, but free)
Java version: 20.0.1, Homebrew, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: Display 1 1920×1080 (scaling 1.00×1.00) Display 2 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_IT
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djosm.home=<josm.pref>, -Dsun.java2d.opengl=true]
Dataset consistency test: No problems found

Plugins:
+ apache-commons (36034)
+ buildings_tools (36097)
+ editgpx (36097)
+ ejml (35924)
+ geotools (36068)
+ jackson (36034)
+ jaxb (35952)
+ jts (36004)
+ mbtiles (v2.6.1)
+ measurement (36097)
+ opendata (36097)
+ openqa (v0.3.3)
+ pbf (36034)
+ poly (36097)
+ todo (123)
+ undelete (36066)
+ utilsplugin2 (36097)

Tagging presets:
removed

Map paint styles:
removed

[taylor.smock]

I haven't been able to reproduce with r18776. I might be misunderstanding the steps to reproduce. The validator layer should be automatically removed when there are no OSM data layers remaining.

EDIT: "OSM data layers" includes any layer which subclasses OsmDataLayer, which is pretty common.

[dieterdreist]

Actually the old behaviour was that the validator layer was removed when the associated layer (not sure if this is the right term and if it even exists) was deleted, even if other data layers still existed. From memory I seem to recall that the validator layer is created for the currently active layer when I click "upload". So if this layer is then removed, the validator layer (in the layer window) must be removed. Currently the validator entry in the layer window is kept while the "validator" issues are empty (after removing the data layer).

[GerdP]

Maybe related: The validation layer is not updated on upload if no error/warning is detected. Can be confusing when you used validator before on all data, got a warning, fixed it and then start upload. Maybe that is intended?

[gaben]

Hmm, I cannot reproduce the bug either. @GerdP can you?

[GerdP]

I think question No 1 would we if @dieterdreist can reproduce with the lateest tested version. There where some changes since r18776, right?
Edit: And no, I cannot reproduce, but I use r18895

[dieterdreist]

Works for me, it deletes the validation layer as well when you delete the data layer. r18904 (I think is not tested but latest)

[gaben]

Replying to GerdP:

I think question No 1 would we if @dieterdreist can reproduce with the lateest tested version. There where some changes since r18776, right?
Edit: And no, I cannot reproduce, but I use r18895

Yeah, you are right. It seems he cannot, so I guess it's a worksforme.

[gaben]

Replying to GerdP:

Maybe related: The validation layer is not updated on upload if no error/warning is detected. Can be confusing when you used validator before on all data, got a warning, fixed it and then start upload. Maybe that is intended?

Before closing this ticket, do you have/know a separate somewhere to track this behaviour?

[GerdP]

No, but I think it was introduced with the progress bar for the upload validation.

[gaben]

Replying to GerdP:

Maybe related: The validation layer is not updated on upload if no error/warning is detected. Can be confusing when you used validator before on all data, got a warning, fixed it and then start upload. Maybe that is intended?

SekeRob just opened a ticket for it, see #23344.

[gaben]

Works for me on r18907 which is the latest stable available today.