[patch] Trunk and some highway links not possible to set on closed way when using presets

[riiga_92@…]

What steps will reproduce the problem?

1. Draw a closed way
2. Apply the trunk preset

What is the expected result?

A closed way with trunk tagging

What happens instead?

Error "The preset Trunk cannot be applied because the selection is unsuitable!"

Please provide any additional information below. Attach a screenshot if possible.

It appears all of the following lack support for closed ways:

• motorway
• motorway_link
• trunk
• trunk_link
• primary_link
• secondary_link
• tertiary_link

Maybe the links should stay as they are, but motorway and trunk exist as roundabouts so they should support being closed ways in the preset. It was also how I discovered this: the trunk preset not showing up on a roundabout tagged as trunk.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-03-01 15:17:42 +0100 (Wed, 01 Mar 2023)
Revision:18678
Build-Date:2023-03-02 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18678 en) Linux Manjaro Linux
Memory Usage: 348 MB / 8004 MB (88 MB allocated, but free)
Java version: 19.0.2+7, N/A, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: sv_SE.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_SE
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: KDE
VM arguments: [--add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, -Djosm.restart=true, -Dawt.useSystemAAFontSettings=gasp]
Dataset consistency test: No problems found

Plugins:
+ AddrInterpolation (36011)
+ FastDraw (35978)
+ OpeningHoursEditor (35924)
+ PicLayer (1.0.2)
+ apache-commons (36034)
+ apache-http (35924)
+ areaselector (1652822522)
+ austriaaddresshelper (master-4e80dc2e4261d321150187f4951684ad97342d5e)
+ buildings_tools (36011)
+ conflation (0.6.9)
+ ejml (35924)
+ geotools (36028)
+ imagery_offset_db (35978)
+ jackson (36034)
+ jaxb (35952)
+ jna (36005)
+ jogl (1.2.3)
+ jts (36004)
+ kendzi3d-resources (0.0.2)
+ log4j (36034)
+ measurement (35978)
+ opendata (36025)
+ pt_assistant (1ff2e15)
+ reverter (36043)
+ tageditor (36011)
+ terracer (35978)
+ turnlanes-tagging (v0.0.5)
+ turnrestrictions (36011)
+ utilsplugin2 (36011)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/PublicTransportOneClick&zip=1
+ ${HOME}/Dokument/QuickSets.zip
+ https://github.com/kendzi/Simple3dBuildingsPreset/releases/download/0.9_2018-05-08/s3db-preset.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LayerChecker&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Streets&zip=1
- ${HOME}/Dokument/OSM/Styles_Maxspeed_Extended-style.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_buildings_sv&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PriorityRoad&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleBuildingTags&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/SimpleRoofTags&zip=1
- https://raw.githubusercontent.com/yopaseopor/indoormap/master/indoormap-style.mapcss
- https://github.com/GlassOceanos/indoor-JOSM-style/archive/master.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Coloured_Postcode&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Admin_Boundaries&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://www.openrailwaymap.org/styles/standard.zip

Last errors/warnings:
- 00000.916 W: Update plugins - You updated your JOSM software. To prevent problems the plugins should be updated as well.  Update plugins now?
- 00005.988 E: Failed to locate image 'bus.png'

[Sarabjeet108]

Can I work on this issue?

[Sarabjeet108]

Added support for closed ways.

[Woazboat]

highway=motorway should be free of intersections or roundabouts by definition: ​https://wiki.openstreetmap.org/wiki/Tag:highway%3Dmotorway

[taylor.smock]

Replying to Sarabjeet108:

Can I work on this issue?

Yes. :)

As a heads up, you should modify the ticket title to have [PATCH] in it. This allows the ticket to show up in the Open tickets, with patches attached report/search.

See wiki:DevelopersGuide/PatchGuide for more useful guidelines.

Anyway, as @Woazboat said, ​osmwiki:Tag:highway=motorway doesn't make sense with a roundabout. A motorway has the following properties:

• Limited or controlled access; limited === very few intersections, controlled === on/off ramps for vehicles to speed up/slow down
  • For limited access, the motorway must not have:
    • Roundabouts (incoming traffic must yield to traffic in the roundabout)
    • Rotaries (traffic in the rotary must yield to incoming traffic)
    • Traffic signals
    • Stop signs (the other roads at the intersection may have stop signs)
    In other words, a driver must not be expected to stop and/or slow down significantly on the motorway under standard conditions (so we are excluding traffic jams, car crashes, floods, avalanches, rock slides, etc.). A controlled access highway should never have any of the above traffic control systems. For this reason, it isn't very common for a limited access road to be a motorway. They will typically be (at most) trunk.
• Driving directions are separated (typically by a physical barrier or separation, not paint)
• Typically 2 or more lanes in each driving direction
• Typically paved
  • If it isn't paved, I would strongly reconsider the highway=motorway classification. After some precipitation, it is highly unlikely to be a high-performance road.
• Typically high speed (> 45 mph). Exceptions to this will include routes through mountainous territory (such as the Rocky Mountains) where the geography and/or weather may prevent high speeds.

@riiga_92: Can you please link to an example of a roundabout on a motorway? It is possible that I am wrong. Maybe the roundabout exists, but is only there for use in emergency situations.

[riiga_92@…]

I think you are right about motorways, so that can skipped, and I'm also not sure how much sense it makes to include links, but trunk should definitely be supported.

[skyper]

In France I have seen all kinds of roundabouts including motorway_link and other *_link. They might not be that common but it should be possible to tag them with presets.