[patch] Minor typo fixes, code cleanup

[gaben]

I collected these changes along for about a year, it's time to publish.

They are very minor, there shouldn't be any functional change in any of the patches:

1. typo fixes
2. simplifications, cleanups
3. shell file fixes
4. rest mixed, skip if not necessary

[gaben]

ShellCheck suggestions applied, although haven't tested

[gaben]

Maybe I should put them on GitHub to have better visibility...

src/org/openstreetmap/josm/data/osm/OsmUtils.java

@@ -36 +36 @@
     /**
      * Discouraged synonym for {@link #TRUE_VALUE}
      */
+    @Deprecated
     public static final String trueval = TRUE_VALUE;
     /**
      * Discouraged synonym for {@link #FALSE_VALUE}
      */
+    @Deprecated
     public static final String falseval = FALSE_VALUE;
     /**
      * Discouraged synonym for {@link #REVERSE_VALUE}
      */
+    @Deprecated
     public static final String reverseval = REVERSE_VALUE;
 
     private OsmUtils() {
@@ -53 +56 @@
     /**
      * Converts a string to a boolean value
      * @param value The string to convert
-     * @return {@link Boolean#TRUE} if that string represents a true value,
-     *         {@link Boolean#FALSE} if it represents a false value,
-     *         <code>null</code> otherwise.
+     * @return {@link Boolean#TRUE} if that string represents a true value,<br>
+     *         {@link Boolean#FALSE} if it represents a false value,<br>
+     *         {@code null} otherwise.
      */
     public static Boolean getOsmBoolean(String value) {
         if (value == null) return null;
@@ -74 +77 @@
      */
     public static String getNamedOsmBoolean(String value) {
         Boolean res = getOsmBoolean(value);
-        return res == null ? value : (res ? trueval : falseval);
+        return res == null ? value : (res ? TRUE_VALUE : FALSE_VALUE);
     }
 
     /**

[gaben]

Patch on Github: ​https://github.com/JOSM/josm/pull/124

[taylor.smock]

In 18801/josm:

Fix #22832: Code cleanup and some simplification, documentation fixes (patch by gaben)

There should not be any functional changes in this patch; it is intended to do
the following:

• Simplify and cleanup code (example: Arrays.asList(item) -> Collections.singletonList(item))
• Fix typos in documentation (which also corrects the documentation to match what actually happens, in some cases)

[gaben]

Thank you! :)

I can look at the since xxx fixer script next time.

[taylor.smock]

I can look at the since xxx fixer script next time.

I've got some local modifications, that, among other things, lets me run it against a changelist. Poke me about it next week so I can share it with you.

[taylor.smock]

In 18813/josm:

See #22832: Don't quote $JPACKAGEOPTIONS

[gaben]

Oops :s

[taylor.smock]

Mistakes happen.

Don't worry about it too much -- it was one of the reasons why I wanted to merge this patch early in the cycle. I should have checked the builds earlier though.