[PATCH] Expand historic=memorial preset subkey memorial=*

[JeroenHoek]

Adds stolperstein, ghost_bike, blue_plaque, cross, sculpture, and bench.
Give all of them descriptions (useful for words like 'stele').

All of these have over 1,000 uses, with the exception of bench and ghost_bike which have several hundred, but are well documented on the wiki.

(I noticed sculpture was missing, and updated the list judging from current use.)

[taylor.smock]

I kind of wish we had a regions tag for presets (see ​vespucci). I don't like the (United Kingdom)/(Europe, Russia) prefixes in the tagging. We do have (<COUNTRY CODE>) elsewhere, but it is for crossing_ref, payment:*, and ref:*. Those locations use ISO 3166 country codes, but I would prefer to avoid adding more.

Other than that, it looks good.

@JeroenHoek: How would you feel if I dropped the blue_plaque and stolperstein for now? I would expect both of those to be regionally limited and not widely used.

[JeroenHoek]

Replying to taylor.smock:

I kind of wish we had a regions tag for presets (see ​vespucci). I don't like the (United Kingdom)/(Europe, Russia) prefixes in the tagging. We do have (<COUNTRY CODE>) elsewhere, but it is for crossing_ref, payment:*, and ref:*. Those locations use ISO 3166 country codes, but I would prefer to avoid adding more.

Other than that, it looks good.

@JeroenHoek: How would you feel if I dropped the blue_plaque and stolperstein for now? I would expect both of those to be regionally limited and not widely used.

Without those two this patch should already improve JOSM, so that's fine if you dislike those. It would be nice to have a way to include them sensibly though; Stolpersteine are quite common in Europe.

For reference: stolperstein has 9200 uses, blue_plaque 1100.

[taylor.smock]

Replying to JeroenHoek:

For reference: stolperstein has 9200 uses, blue_plaque 1100.

I hadn't checked either in taginfo. stolperstein is pretty close to the JOSM thresholds (10k), so I'll go ahead and leave both in. I'll just modify the country references ((GB) and (EU,RU) I think).

[JeroenHoek]

I'll just modify the country references ((GB) and (EU,RU) I think).

Note that blue plaques are used in all of the United Kingdom, not just Great Britain (GB). They are used in Northern Ireland as well.

[taylor.smock]

Replying to JeroenHoek:

Note that blue plaques are used in all of the United Kingdom, not just Great Britain (GB). They are used in Northern Ireland as well.

You might want to checkout ​wikipedia:ISO_3166-2:GB. :)

[taylor.smock]

In 18722/josm:

Fix #22831: Add additional memorial values for the historic=memorial preset (patch by JeroenHoek, modified)