Opened 22 months ago
Closed 21 months ago
#22798 closed defect (fixed)
[PATCH] Convert actions which extend `AbstractAction` to ones which extend `JosmAction`
Reported by: | taylor.smock | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 23.04 |
Component: | Core | Version: | |
Keywords: | Cc: |
Description (last modified by )
We should try to ensure that all actions (especially those that some users may want to bind to shortcuts) extend JosmAction
.
The affected dialogs and actions are as follows:
- ChangesetDialog
- SelectObjectsAction
- ReadChangesetsAction
- CloseOpenChangesetsAction
- ShowChangesetInfoAction
- LaunchChangesetManagerAction
- CommandStackDialog
- SelectAction
- SelectAndZoomAction
- Undo/Redo actions (since these are distinct from the global undo/redo action -- will undo/redo to the selected command)
- FilterDialog
- AddAction
- EditAction
- DeleteAction
- MoveUpAction
- MoveDownAction
- SortAction
- ReverseAction
- MapPaintDialog
- OnOffAction
- MoveUpDownAction
- NotesDialog
- AddCommentAction
- CloseAction
- NewAction
- ReopenAction
- SortAction
- OpenInBrowserAction
- RelationListDialog
- NewAction
- UserListDialog
- SelectUserPrimitivesAction
- ShowUserInfoAction -- this calls a different
super
constructor actually
I don't see most of these getting shortcuts, especially official shortcuts, but some people on various chat channels have mentioned that they would like to have a shortcut for creating a new relation.
The current patch primarily focuses on actions for toggle dialogs.
Attachments (1)
Change History (4)
by , 22 months ago
Attachment: | 22798.patch added |
---|
comment:1 by , 22 months ago
Description: | modified (diff) |
---|---|
Milestone: | → 23.04 |
Summary: | Convert actions which extend `AbstractAction` to ones which extend `JosmAction` → [PATCH] Convert actions which extend `AbstractAction` to ones which extend `JosmAction` |
See also #22801.