The "Add Tag" dialog should not be modal

[GerdP]

What steps will reproduce the problem?

1. Have one or more images of a guidepost
2. add tags like direction_north with long values, see e.g. ​https://www.osm.org/node/10712464058
3. try to zoom or move the image to be able to view all details of the signs for one direction

What is the expected result?

View can be changed while the add tags

What happens instead?

The image dialog doesn't react

Please provide any additional information below. Attach a screenshot if possible.

Not sure if there are good reasons that AddTagsDialog is modal?

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-03-01 15:17:42 +0100 (Wed, 01 Mar 2023)
Revision:18678
Build-Date:2023-03-02 02:30:57
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18678 en) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 582 MB / 1972 MB (320 MB allocated, but free)
Java version: 17.0.4+8-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18531, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\HWConsole.exe]

Plugins:
+ OpeningHoursEditor (35924)
+ RoadSigns (36038)
+ apache-commons (36034)
+ buildings_tools (36011)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ geotools (36028)
+ jackson (36034)
+ jaxb (35952)
+ jts (36004)
+ o5m (35893)
+ opendata (36025)
+ pbf (36034)
+ poly (35976)
+ reltoolbox (35976)
+ reverter (36043)
+ undelete (36011)
+ utilsplugin2 (36011)

Validator rules:
+ c:\josm\core\resources\data\validator\combinations.mapcss
+ c:\josm\core\resources\data\validator\geometry.mapcss
+ c:\josm\core\resources\data\validator\unnecessary.mapcss
+ d:\java_tools\JOSM\mygeometry.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/GermanySpecific&zip=1

Last errors/warnings:
- 00000.608 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.611 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00002.193 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available

[taylor.smock]

Not sure if there are good reasons that AddTagsDialog is modal?

I don't know of any good reason, with a caveat that we have some modals that appear behind other dialog windows (for example, if authentication fails while in preferences, the warning dialog is behind the preferences window).

We already allow tag changes via the relation editor without blocking the mapview rendering, so we could probably convert it to a non-blocking dialog.

[skyper]

Well, relation editor is more independent.
Right now, all added tags result in a single change in the command stack and using "cancel" in the Add Tag Dialog at any time does not add any tags. Switching to non-modal needs well designed conflict solution as some or all objects in questions could have been modified up to being deleted.

[GerdP]

OK, good point. Is there another way to make the image dialog usable while AddTagDialog is visible? If not we should probably close this as wontfix.

[skyper]

I guess, you need to use the option/button to open the image in an external image viewer ().

[GerdP]

That button doesn't react when the AddTagDialog is open.

[taylor.smock]

We could try locking the dataset while the dialog is open, and then unlocking the dataset once the dialog closes. I don't know if that will work, but it should prevent the modification of data while the dialog is open.