Deleting Geotagged Image - does no longer automatically skip forward to the next image

[mrgenie]

What steps will reproduce the problem?

1. Load Geotagged Images
2. open the undocked window for geotagged images
3. Click on the red waste bin button in the lower part

What is the expected result?

next image to be seen

What happens instead?

it still shows the image I just deleted - with an error warning

Please provide any additional information below. Attach a screenshot if possible.

Until the Nov/Dec 2022 update - in JOSM if I had the "Geotagged Images" window open and clicked on the "red waste bin" to delete this specific image - it would automatically go to the next.

this behavior is not anymore. After the Nov/Dec 2022 update - I delete an image using the "red waste bin" button I need to click on the "blue next" button and then I'm 2 ahead so I also need to click the "blue previous" button to actually get to the next geotagged image.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2023-01-29 21:53:34 +0100 (Sun, 29 Jan 2023)
Revision:18646
Build-Date:2023-01-30 02:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18646 en) Windows 10 64-Bit
OS Build number: Windows 10 Home Single Language 2009 (19045)
Memory Usage: 878 MB / 3038 MB (345 MB allocated, but free)
Java version: 11.0.12+8-LTS-237, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.25×1.25) \Display1 3840×2160 (scaling 1.50×1.50)
Maximum Screen Size: 3840×2160
Best cursor sizes: 16×16→48×48, 32×32→48×48
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890

Plugins:
+ DirectDownload (36011)
+ DirectUpload (35951)
+ ElevationProfile (35978)
+ ImageWayPoint (35893)
+ ImproveWay (32)
+ Mapillary (2.1.1)
+ PicLayer (1.0.2)
+ RoadSigns (36038)
+ apache-commons (36034)
+ editgpx (35931)
+ imagery_offset_db (35978)
+ indoor_sweepline (36011)
+ indoorhelper (1.2.2)
+ jaxb (35952)
+ jogl (1.2.3)
+ kendzi3d (1.0.205)
+ kendzi3d-resources (0.0.2)
+ log4j (36034)
+ measurement (35978)
+ openindoor-1.0.2-josm (UNKNOWN)
+ openqa (v0.3.3)
+ pbf (36034)
+ photo_geotagging (35933)
+ photoadjust (36011)
+ tageditor (36011)
+ terracer (35978)
+ turnlanes (36011)
+ turnlanes-tagging (v0.0.5)
+ turnrestrictions (36011)
+ undelete (36011)
+ utilsplugin2 (36011)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/PhilippinesJeepneys&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/PhilippinesTrafficSigns&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PhilippinesTrafficSigns&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/SidewalksAndFootways&zip=1
- <josm.pref>\plugins\indoorhelper\resources\sit.mapcss

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/IndoorRules&zip=1

Last errors/warnings:
- 00000.419 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00000.421 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00038.924 W: com.drew.imaging.jpeg.JpegProcessingException: JPEG data is expected to begin with 0xFFD8 (ÿØ) not 0x0

[taylor.smock]

Ticket retargeted after milestone closed

[taylor.smock]

This appears to be an easy fix. Writing a test to ensure that it stays fixed is going to be a harder problem.

[taylor.smock]

In 18685/josm:

Fix #22767: Geotagged image deletion does not move to the next/previous image

[taylor.smock]

In 18686/josm:

See #22767, fix failing unit tests

The fix for #22767 included a new unit test, which caused a cascading failure.
The first step of the fix included removing the destroyed dialog from the
MapFrame. Unfortunately, MapFrame#removeToggleDialog did not properly
remove the ToggleDialog -- it called DialogsPanel#remove(Component) with
the ToggleDialog as an argument. Since the DialogsPanel never adds the
ToggleDialog as a direct subcomponent, this was effectively a no-op.

[anonymous]

Ticket #22584 has been marked as a duplicate of this ticket.

[taylor.smock]

In 18689/josm:

Revert tests added in r18685/r18686, see #22767

The test has proven much harder to fix than expected. The test should be
readded once it has been fixed.

[taylor.smock]

Ticket #21486 has been marked as a duplicate of this ticket.