Opened 3 years ago
Closed 17 months ago
#21486 closed defect (duplicate)
Upon command to delete a geotagged image from disk, the corresponding marker sometimes is not removed from the map view
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core image mapping | Version: | latest |
| Keywords: | template_report, regression, javabug | Cc: |
Description
What steps will reproduce the problem?
- create a layer of geotagged images
- click on the red bin icon (or press Ctrl+Shift+Delete) to delete one or more images
What is the expected result?
The image is deleted from the geotagged photo layer and from disk
What happens instead?
Sometimes, the marker of the deleted image remains on the map.
Please provide any additional information below. Attach a screenshot if possible.
Using the previous/next navigation buttons, the markers corresponding to the deleted images are correctly skipped, without issuing any error.
I still haven't figured out what triggers the bug, it happens often. I'm working with 360 images. When I delete several images in a row, it happens for all of them.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2021-10-26 23:06:56 +0200 (Tue, 26 Oct 2021) Revision:18292 Build-Date:2021-10-26 21:15:54 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (18292 en_GB) Windows 10 64-Bit OS Build number: Windows 10 Home 2009 (19043) Memory Usage: 2142 MB / 4068 MB (1227 MB allocated, but free) Java version: 11.0.2+9-LTS, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 3840×2160 (scaling 2.50×2.50) Maximum Screen Size: 3840×2160 Best cursor sizes: 16×16→64×64, 32×32→64×64 System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Locale info: en_GB Numbers with default locale: 1234567890 -> 1234567890 Dataset consistency test: No problems found Plugins: + Mapillary (2.0.0-alpha.40) + QuickLabel (23) + SimplifyArea (35640) + apache-commons (35524) + apache-http (35589) + editgpx (35562) + ejml (35458) + geotools (35458) + jna (35662) + jts (35458) + measurement (35640) + merge-overlap (35640) + photo_geotagging (35783) + photoadjust (35770) + reltoolbox (35829) + reverter (35732) + rex (53) + undelete (35640) Tagging presets: + D:\OSM\JOSM\presets\cai_josm_preset-master\cai.xml + https://josm.openstreetmap.de/josmfile?page=Presets/Mountains&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1 + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/CH.zip + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1 + https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss - https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1 + https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR.zip + https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1 Last errors/warnings: - 100458.269 E: java.io.FileNotFoundException: C:\OSM\Mapillary to be edited\OSM e Mapillary\Rifugio Rosalba\Theta V\R0288814.JPG (The system cannot find the file specified) - 100469.578 E: java.io.FileNotFoundException: C:\OSM\Mapillary to be edited\OSM e Mapillary\Rifugio Rosalba\Theta V\R0288817.JPG (The system cannot find the file specified) - 100497.246 E: java.io.FileNotFoundException: C:\OSM\Mapillary to be edited\OSM e Mapillary\Rifugio Rosalba\Theta V\R0288818.JPG (The system cannot find the file specified) - 100499.362 E: java.io.FileNotFoundException: C:\OSM\Mapillary to be edited\OSM e Mapillary\Rifugio Rosalba\Theta V\R0288817.JPG (The system cannot find the file specified) - 100500.862 E: java.io.FileNotFoundException: C:\OSM\Mapillary to be edited\OSM e Mapillary\Rifugio Rosalba\Theta V\R0288818.JPG (The system cannot find the file specified) - 100501.877 E: java.io.FileNotFoundException: C:\OSM\Mapillary to be edited\OSM e Mapillary\Rifugio Rosalba\Theta V\R0288819.JPG (The system cannot find the file specified) - 100503.363 E: java.io.FileNotFoundException: C:\OSM\Mapillary to be edited\OSM e Mapillary\Rifugio Rosalba\Theta V\R0288818.JPG (The system cannot find the file specified) - 100503.590 E: java.io.FileNotFoundException: C:\OSM\Mapillary to be edited\OSM e Mapillary\Rifugio Rosalba\Theta V\R0288817.JPG (The system cannot find the file specified) - 101545.808 W: Unable to delete file C:\OSM\Mapillary to be edited\OSM e Mapillary\Rifugio Rosalba\Theta V\R0288817.JPG - 101551.456 E: java.io.FileNotFoundException: C:\OSM\Mapillary to be edited\OSM e Mapillary\Rifugio Rosalba\Theta V\R0288818.JPG (The system cannot find the file specified)
Attachments (0)
Change History (18)
comment:1 by , 3 years ago
| Keywords: | regression added |
|---|---|
| Owner: | changed from to |
comment:2 by , 3 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
I don't have a bunch of 360 images. I'm going to try and get some (I had one, and delete worked perfectly). I was unable to reproduce with traditional perspective pictures. On Mac OS X, not MS Windows 10.
If I am unable to reproduce with 360 images, I'll see if I can find a Windows machine lying around somewhere. Hopefully it is not a Windows specific bug.
As a sanity check, can you update to the current latest (r18299, you were running r18292), and try to reproduce?
follow-up: 4 comment:3 by , 3 years ago
Same problem also with r18299:
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2021-10-31 22:36:43 +0100 (Sun, 31 Oct 2021) Revision:18299 Build-Date:2021-11-01 02:31:12 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (18299 en_GB) Windows 10 64-Bit OS Build number: Windows 10 Home 2009 (19043) Memory Usage: 1487 MB / 4068 MB (607 MB allocated, but free) Java version: 11.0.2+9-LTS, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 3840×2160 (scaling 2.50×2.50) Maximum Screen Size: 3840×2160 Best cursor sizes: 16×16→64×64, 32×32→64×64 System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Locale info: en_GB Numbers with default locale: 1234567890 -> 1234567890 Plugins: + Mapillary (2.0.0-alpha.40) + QuickLabel (23) + SimplifyArea (35640) + apache-commons (35524) + apache-http (35589) + editgpx (35562) + ejml (35458) + geotools (35458) + jna (35662) + jts (35458) + measurement (35640) + merge-overlap (35640) + photo_geotagging (35783) + photoadjust (35770) + reltoolbox (35829) + reverter (35732) + rex (53) + undelete (35640) Tagging presets: + D:\OSM\JOSM\presets\cai_josm_preset-master\cai.xml + https://josm.openstreetmap.de/josmfile?page=Presets/Mountains&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1 + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/CH.zip + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1 + https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss - https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1 + https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR.zip + https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1 Last errors/warnings: - 00913.120 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00913.129 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00913.138 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00913.149 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00913.158 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00913.167 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00913.176 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00913.185 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00913.194 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00913.203 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first
comment:4 by , 3 years ago
Replying to bartosomail@…:
Java version: 11.0.2+9-LTS, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Might not solve the problem but Debian released a security update for java 11, today, and the version changed from 11.0.12 to 11.0.13. Now, I wonder if your java RE is up-to-date.
comment:5 by , 3 years ago
I both updated Java to 17.0.1 and JOSM to 18303. Can't say what did the trick, but it seems that I'm now unable to reproduce the problem :-)
The exception with trying to delete the image multiple time is my fault. It happens when I want to fast delete several images in a row without even looking at them, and keep hammering on the delete button before giving enought time for the image next to the just deleted one to appear. I even get a notification message. No issue at all I would say, just my insane editing habit. Maybe it could be prevented by disabling the delete button until the next image appears?
comment:6 by , 3 years ago
| Keywords: | javabug added |
|---|---|
| Resolution: | → othersoftware |
| Status: | needinfo → closed |
The Java update probably is what fixed it.
The only differences between r18299 and r18303 that even mildly affected the codepaths for image viewing was r18300. And that didn't touch image deletion.
EDIT: And your use of the image viewer closely mirrors my own (I upload to Mapillary first, just in case I delete stuff a little too fast).
comment:7 by , 3 years ago
| Resolution: | othersoftware |
|---|---|
| Status: | closed → reopened |
It happened again. Still cant's say how to reproduce it, but the problem is still there. Once it is somehow initiated, it stays there.
I suspect that might be related to holding down the next key for several seconds to fast move along a long sequence of images. (I work with layers contaning afew thousand images)
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2021-11-04 00:56:52 +0100 (Thu, 04 Nov 2021) Revision:18309 Build-Date:2021-11-04 02:31:03 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (18309 en_GB) Windows 10 64-Bit OS Build number: Windows 10 Home 2009 (19043) Memory Usage: 3334 MB / 4068 MB (671 MB allocated, but free) Java version: 17.0.1+12-LTS-39, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 3840×2160 (scaling 2.50×2.50) Maximum Screen Size: 3840×2160 Best cursor sizes: 16×16→64×64, 32×32→64×64 System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Locale info: en_GB Numbers with default locale: 1234567890 -> 1234567890 Plugins: + Mapillary (2.0.0-alpha.40.a) + QuickLabel (23) + SimplifyArea (35640) + apache-commons (35524) + apache-http (35589) + editgpx (35562) + ejml (35458) + geotools (35458) + jna (35662) + jts (35458) + measurement (35640) + merge-overlap (35640) + photo_geotagging (35783) + photoadjust (35770) + reltoolbox (35829) + reverter (35732) + rex (53) + undelete (35640) Tagging presets: + D:\OSM\JOSM\presets\cai_josm_preset-master\cai.xml + https://josm.openstreetmap.de/josmfile?page=Presets/Mountains&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1 + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/CH.zip + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1 + https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss - https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1 + https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR.zip + https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1 Last errors/warnings: - 00247.029 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00247.038 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00247.046 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00247.054 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00247.062 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00247.072 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00247.080 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00247.089 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 00247.098 E: Error reading EXIF from file: com.drew.metadata.MetadataException: Tag 'GPS Latitude' has not been set -- check using containsTag() first - 23083.242 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
comment:9 by , 3 years ago
Not sure if it's linked to your problem, but can you please test with r18315?
follow-up: 11 comment:10 by , 3 years ago
The problem is still there. Unfortunately I still haven't figured out a way to reproduce it at will.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2021-11-07 15:01:40 +0100 (Sun, 07 Nov 2021) Revision:18315 Build-Date:2021-11-07 14:05:37 URL:https://josm.openstreetmap.de/svn/trunk Identification: JOSM/1.5 (18315 en_GB) Windows 10 64-Bit OS Build number: Windows 10 Home 2009 (19043) Memory Usage: 3720 MB / 4068 MB (431 MB allocated, but free) Java version: 17.0.1+12-LTS-39, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 3840×2160 (scaling 2.50×2.50) Maximum Screen Size: 3840×2160 Best cursor sizes: 16×16→64×64, 32×32→64×64 System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Locale info: en_GB Numbers with default locale: 1234567890 -> 1234567890 Plugins: + Mapillary (2.0.0-alpha.41) + QuickLabel (23) + SimplifyArea (35640) + apache-commons (35524) + apache-http (35589) + editgpx (35562) + ejml (35458) + geotools (35458) + jna (35662) + jts (35458) + measurement (35640) + merge-overlap (35640) + photo_geotagging (35783) + photoadjust (35770) + reltoolbox (35829) + reverter (35846) + rex (53) + undelete (35848) Tagging presets: + D:\OSM\JOSM\presets\cai_josm_preset-master\cai.xml + https://josm.openstreetmap.de/josmfile?page=Presets/Mountains&zip=1 + https://josm.openstreetmap.de/josmfile?page=Presets/ParkingLanes&zip=1 + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/CH.zip + https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/IT.zip Map paint styles: + https://josm.openstreetmap.de/josmfile?page=Styles/DestinationSignRelation&zip=1 + https://raw.githubusercontent.com/species/josm-preset-traffic_sign_direction/master/direction.mapcss - https://josm.openstreetmap.de/josmfile?page=Styles/Osmc&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1 + https://raw.githubusercontent.com/yopaseopor/traffic_signs_style_JOSM/master/Styles_Traffic_signs_EUR.zip + https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1 Last errors/warnings: - 00000.497 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF' - 00000.500 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF' - 16928.202 W: No default layer selected, choosing first layer.
comment:11 by , 3 years ago
Replying to bartosomail@…:
The problem is still there. Unfortunately I still haven't figured out a way to reproduce it at will.
OK. I'm going to have to get some 360 images. I'll try to reproduce in a few days. It most likely is not 360 image specific, so I would assume I would be able to reproduce with standard images. But just in case, I'll try with 360 images.
Note: I don't have Windows, so hopefully it isn't an OS specific bug.
comment:12 by , 3 years ago
Thanks. Yes, it's likely that I notice the problem with the 360 images, due to the large amount of such images I deal with compared to normal ones.
I just noted that the problem with the image icon has now materialized in the opposit way.
I have moved some images to a different location. No marker is shown for the moved images, yet the images are there, and I can navigate them using the next and forward buttons at any time. When the image is visualized, an highligted marker is shown at its position. But as soon I select another picture the marker completely disappears, until I navigate again to that image. There's no way to select the image clicking at the position when the marker should be.
JOSM doesn't list anythin in last errors/warnings.
Just for information, I happen to mostly play with deletions and relocations of images which are very close to each other, say 1 meter or so, no idea if this could play a role.
comment:13 by , 3 years ago
Sorry, I must correct what I just said. I can select the image by blindly clicking at the position where the marker should be, (it's just difficult, because you don't know where to click).
comment:14 by , 3 years ago
Just noticed that the problem with the markers of the deleted images not being removed from the map occurred also with an old JOSM version (18237), prior of the implementation of the 360 viewer.
comment:16 by , 17 months ago
| Status: | reopened → needinfo |
|---|
I think this might be fixed. Or I didn't notice it when photomapping last week. #22767 might have been a duplicate of this ticket.
Let me know if this isn't fixed.
comment:18 by , 17 months ago
| Resolution: | → duplicate |
|---|---|
| Status: | needinfo → closed |
Closed as duplicate of #22767.
It looks like we are trying to delete the image multiple times.