Validator should not warn for direction relations which use roundabout

[anonymous]

RelationChecker does not check if the relation uses a roundabout in role "from" (even when tagged with oneway) and generates a misleading warning: Type "Line" for member in role "from" is not in accepted values "Point/Line"

What steps will reproduce the problem?

1. Load data with a relation for a destination_sign using a roundabout e.g. ​https://www.openstreetmap.org/relation/4068333#map=18/48.30736/11.89197
2. Execute JOSM checks

What is the expected result?

No warning for the relation as it is correctly defined.

What happens instead?

Warning is created.

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-09-29 20:51:54 +0200 (Thu, 29 Sep 2022)
Revision:18565
Build-Date:2022-09-30 01:30:56
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18565 de) Windows 11 64-Bit
OS Build number: Windows 10 Pro 2009 (22621)
Memory Usage: 928 MB / 4062 MB (430 MB allocated, but free)
Java version: 17.0.2+8-LTS, Microsoft, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.25×1.25) \Display1 1680×1050 (scaling 1.00×1.00) \Display2 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (36011)
+ reverter (36043)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Last errors/warnings:
- 00001.875 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF'
- 00001.878 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00009.238 W: Unable to request certificate of https://roottest-g3.pkioverheid.nl
- 00010.516 W: Unable to request certificate of https://roottest-g3.pkioverheid.nl
- 00015.817 W: java.nio.file.FileSystemException: %UserProfile%\AppData\Local\Temp\josm_exec_powershell_316217196773450632.txt: Der Prozess kann nicht auf die Datei zugreifen, da sie von einem anderen Prozess verwendet wird
- 00015.819 W: Unable to request certificate of https://grca.nat.gov.tw
- 00020.922 W: java.nio.file.FileSystemException: %UserProfile%\AppData\Local\Temp\josm_exec_powershell_350500854017405048.txt: Der Prozess kann nicht auf die Datei zugreifen, da sie von einem anderen Prozess verwendet wird
- 00020.924 W: Unable to request certificate of https://grca.nat.gov.tw

[GerdP]

No warning for the relation as it is correctly defined.

I've never created such a relation type, but I think the wiki says you should either use a member with role from or a member with role intersection, not both at the same time. Why can't you simply remove the from way?

[anonymous]

This would be possible but a lot of relations already use it as it is similar to the common schema from/via/to (just with intersection).

Besides, the warning leads users to split the roundabout into multiple parts (which avoids the warning) but obviously there is no reason for that.

[GerdP]

Well, I am not sure if the test checks what the wiki says or if there is another reason for the message, but if you think that the wiki is wrong you should discuss that on the tagging list and not here.

[anonymous]

Indeed, the wiki says that either from or intersection must be given.

Removing the intersection and using from+to warns that the road with role 'from' is not in the accepted types, thus this warning seems to be wrong.

Removing the from and keeping intersection+to works.

[skyper]

Keep it simple and only use from if needed.
Personally, I found many situation where some via ways were needed, so I am not quite happy with the roles, either.

[anonymous]

Your advice is to tag differently to avoid a wrong warning?

[skyper]

Looking at the table for members on the ​wiki, I only find node and open way for from but closed way (area) is missing.

Regarding your example, excluding from is just perfect and with a deeper look, I find some reasons to split the roundabout. E.g. there is only a sidewalk on the northern side (sidewalk=separate?) and all the PTv2 relations would benefit from splitting the roundabout.

I have to admit, though, that the warning Role verification problem - Type 'way' of relation member with role 'from' does not match accepted types 'node/way' in preset Destination Sign is misleading as only closed ways are not accepted.