Incorrect warning: "Construction without building, highway or landuse" for railway=construction + construction=*

[Famlam]

What steps will reproduce the problem?

1. Validate ​https://www.openstreetmap.org/way/1052080206 , a platform under construction drawn as area. Current tags:

   area=yes
   construction=platform
   railway=construction
   

What is the expected result?

No warning

What happens instead?

warning: "Construction without building, highway or landuse"

Please provide any additional information below. Attach a screenshot if possible.

Introduced in #20960, patch by skyper
The following line in combinations.mapcss lacks [!railway] (and probably many other tags, like aerialway, aeroway, ..., that can be under construction)

area[construction][!building][!highway][!landuse]:closed,

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-04-04 22:26:00 +0200 (Mon, 04 Apr 2022)
Build-Date:2022-04-05 01:30:55
Revision:18427
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18427 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19044)
Memory Usage: 522 MB / 1820 MB (145 MB allocated, but free)
Java version: 1.8.0_331-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: nl_NL
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35924)
+ SimplifyArea (35893)
+ imagery_offset_db (35893)
+ pbf (35893)
+ pt_assistant (1ff2e15)
+ reverter (35893)
+ tageditor (35893)
+ turnlanes-tagging (v0.0.5)
+ undelete (35893)
+ utilsplugin2 (35951)

Tagging presets:
+ http://mijndev.openstreetmap.nl/~allroads/JOSM/Presets/NL-Fiets.zip

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.mappaint.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Styles/Sidewalks&zip=1

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ https://raw.githubusercontent.com/Famlam/OsmMapcssValidationNL/main/netherlands.validator.mapcss

Last errors/warnings:
- 00017.581 E: Lokaliseren van afbeelding 'bus.png' mislukt

[skyper]

Right, this does not work nicely:

way[construction][!highway][!railway][!waterway]!:closed,
area[construction][!building][!highway][!landuse]:closed,

Probably needs a completely different approach. How about removing the two lines for now.

[Famlam]

I would agree that removing them is probably the best solution for now.
(I can't think of a solution with mapcss)

[Famlam]

@skyper, would it be good to set a milestone to this so it gets included in the end-of-May/early-June release? I can't commit myself (and to my knowledge the github, where I could make PR's, is only a mirror)

[Klumbumbus]

In 18463/josm:

fix #22039, see #20960 - Remove warning about construction without highway/railway/waterway/building/landuse as it produces too much false positives

[Famlam]

That was fast, thanks :)