[Patch] Warn about construction=* without or conflicting primary tag

[skyper]

Inspired by #17607.

What steps will reproduce the problem?

1. Have a way with only construction=*
2. Run Validator

What is the expected result?

A warning about missing primary tag

What happens instead?

No warning

OR

What steps will reproduce the problem?

1. Have a way with railway=rail and construction=rail
2. Run Validator

What is the expected result?

A warning about conflicting tags

What happens instead?

No warning

Please provide any additional information below. Attach a screenshot if possible.

Not sure if a autofix can be offered but suggestions can be made.
The four primary tags highway, railway, building and landuse use construction=*, atm.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-06-02 23:14:11 +0200 (Wed, 02 Jun 2021)
Revision:17921
Build-Date:2021-06-03 01:31:07
URL:https://josm.openstreetmap.de/svn/trunk

[skyper]

patch

[skyper]

Please find attached patch​ which updates/adds the rules for construction=*.
I am not sure if waterway=* might be a fifth primary tag where the combination with construction=* is valid.

I gonna work on #20963 which should be fixed together with this ticket.

[skyper]

Have to little rework the rule and need to find/create a nice icon for building=construction.

[skyper]

Version 2​ does not warn about waterway=*

Additionally, I rearranged some rules to have harmonized plus ordered placeholder numbers in the throw*. First step of cleaning up.

[skyper]

version 2: does not warn about waterway; rearrange some rules to use ordered placeholder numbers

[skyper]

#20963 has a patch now.

[stoecker]

In 18397/josm:

fix #20960 - patch by skyper - validator fixes with construction tag

[skyper]

Sorry, I mixed up the order in one case, see #22009.

[Famlam]

The latest patch seems to lack [!railway] in this line:

area[construction][!building][!highway][!landuse]:closed,

Example: ​https://www.openstreetmap.org/way/1052080206 , a platform under construction

[skyper]

Replying to Famlam:

The latest patch seems to lack [!railway] in this line:

area[construction][!building][!highway][!landuse]:closed,

Example: ​https://www.openstreetmap.org/way/1052080206 , a platform under construction

See #22039

[Klumbumbus]

In 18446/josm:

fix #22009, see #20960 - Fix incorrect warning message *:lanes without highway (instead of lanes) (patch by skyper)

[Klumbumbus]

In 18463/josm:

fix #22039, see #20960 - Remove warning about construction without highway/railway/waterway/building/landuse as it produces too much false positives