Opened 3 years ago
Last modified 3 years ago
#21542 new enhancement
Problem with Ignore list and new objects
Reported by: | anonymous | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | |
Keywords: | template_report ignore list id:0 new object | Cc: |
Description
What steps will reproduce the problem?
- Mark an individual warning in the validation list.
- Open 'Manage Ingore'
- The marked warning is not in the ignore list
What is the expected result?
The marked warning should be in the ignore list.
What happens instead?
Warning not in the list.
Please provide any additional information below. Attach a screenshot if possible.
Marking and ignoring a whole group is ok.
Revision:18303 Build-Date:2021-11-01 22:53:13 Identification: JOSM/1.5 (18303 en) Windows 10 64-Bit OS Build number: Windows 10 Home 2009 (19042) Memory Usage: 2458 MB / 4078 MB (1493 MB allocated, but free) Java version: 17.0.1+12-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 2560×1440 (scaling 1.00×1.00) Maximum Screen Size: 2560×1440 Best cursor sizes: 16×16→32×32, 32×32→32×32 System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Locale info: en_SE Numbers with default locale: 1234567890 -> 1234567890 VM arguments: [-Djpackage.app-version=1.5.18303, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe] Program arguments: [%UserProfile%\Documents\OSM\start.jos] Dataset consistency test: No problems found Plugins: + PicLayer (1.0.1) + apache-commons (35524) + ejml (35458) + geotools (35458) + imagery_offset_db (35640) + jaxb (35543) + jts (35458) + measurement (35640) + merge-overlap (35640) + opendata (35803) + reltoolbox (35829) + reverter (35846) + turnrestrictions (35640) + utilsplugin2 (35856) Map paint styles: - https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1 - https://josm.openstreetmap.de/josmfile?page=Styles/Lane_features&zip=1 Last errors/warnings: - 00000.334 W: extended font config - overriding 'filename.Myanmar_Text=mmrtext.ttf' with 'MMRTEXT.TTF' - 00000.335 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF' - 00000.882 E: java.security.KeyStoreException: Windows-ROOT not found. Cause: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available
Attachments (0)
Change History (4)
comment:1 by , 3 years ago
Owner: | changed from | to
---|---|
Status: | new → needinfo |
comment:2 by , 3 years ago
Component: | Core → Core validator |
---|---|
Keywords: | ignore list added |
comment:3 by , 3 years ago
Sorry for not answering this long ago. It seems the ignore list only filter out old objects.
I have not found any case where this is not correct.
If this is the intended function, this bug report can be closed.
But I find this behaviour confusing.
A user probably don't understand that new objects are not filtered (only if the new objects are in a group).
I suggest this function is updated:
- Include all objects. New and old.
or
- Show a warning to the user, if trying to filter out new objects (id=0), saying new objects will not be ignored.
comment:4 by , 3 years ago
Keywords: | id:0 new object added |
---|---|
Owner: | changed from | to
Status: | needinfo → new |
Summary: | Problem with Ignore list → Problem with Ignore list and new objects |
Type: | defect → enhancement |
Replying to anonymous:
But I find this behaviour confusing.
A user probably don't understand that new objects are not filtered (only if the new objects are in a group).
I suggest this function is updated:
- Include all objects. New and old.
or
- Show a warning to the user, if trying to filter out new objects (id=0), saying new objects will not be ignored.
The 1. point is not that easy, see #4595. I thought about an ignore file for sessions in #20055.
The 2. point should be possible. At least, I have updated the validator wiki page (diff) and maybe quick help on mouse hover could show this second sentence, too.
Do you have an example, please?
Please, check if the object is a new object (id 0). New object are not added to the list as an object id above zero is needed. Once the new object has been uploaded, you can add it.