Please restore standard file selection window for Mac

[nkamapper]

With JOSM 18303 for Mac, the Mac OS standard "Open" file selection window seems to be gone. This makes it very time consuming to navigate, sort etc, and it breaks a habit for all Mac users. Please restore the standard window, at least as an option.

Another problem with the new Open window is that seems to remember neither the last viewed folder nor the last used file sorting (from the current session).

[skyper]

Please, always add your status report for defects. At least, your java version and the way you start JOSM might be important.

On Linux, the sorting is not remembered with the internal file browser, too, but the folder is.

[taylor.smock]

Thanks for your report, however your ticket is incomplete and therefore not helpful in its current form.

Please add all needed information according to this list:

• The required parts of the Status Report from your JOSM.
  • Please, use Report Bug from Help menu and copy & paste.
• Describe what behaviour you expected.
• Describe what did happen instead.
• Describe if and how the issue is reproducible.
• Add any relevant information like error messages or screenshots.

To ensure that all technical relevant information is contained, create new tickets by clicking in JOSMs Main Menu on Help → Report Bug.

Remember: This is a generic notice so we don't need to write the same stuff again and again. It may only apply in parts to the specific case!

Replying to nkamapper:

With JOSM 18303 for Mac, the Mac OS standard "Open" file selection window seems to be gone. This makes it very time consuming to navigate, sort etc, and it breaks a habit for all Mac users. Please restore the standard window, at least as an option.

Another problem with the new Open window is that seems to remember neither the last viewed folder nor the last used file sorting (from the current session).

See #21344 . The reason why the Mac OS file selection dialog no longer appears is that it does not support picking directories (at least in current Java code).

You may also be interested in ​https://bugs.openjdk.java.net/browse/JDK-7125172 .

EDIT: Relevant JOSM source:/trunk/src/org/openstreetmap/josm/gui/widgets/NativeFileChooser.java@18303:175-189#L175​

[nkamapper]

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-11-01 23:05:46 +0100 (Mon, 01 Nov 2021)
Build-Date:2021-11-01 22:25:18
Revision:18303
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18303 en_GB) Mac OS X 10.16
OS Build number: macOS 11.4 (20F71)
Memory Usage: 816 MB / 3641 MB (527 MB allocated, but free)
Java version: 1.8.0_311-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.apple.laf.AquaLookAndFeel
Screen: Display 69733568 1440×900 (scaling 1.00×1.00)
Maximum Screen Size: 1440×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/56/1ee8cfb8-5f399dac, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Dmacosx.jnlpx.dock.name=JOSM, -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-2b48d418.icns, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp , -Djnlpx.jvm="<java.home>/bin/java"]

Plugins:
+ PicLayer (1.0.1)
+ apache-commons (35524)
+ apache-http (35589)
+ changeset-viewer (25)
+ conflation (0.6.8)
+ ejml (35458)
+ ext_tools (35640)
+ geotools (35458)
+ imagery-xml-bounds (35723)
+ jaxb (35543)
+ jna (35662)
+ jts (35458)
+ opendata (35803)
+ pdfimport (35640)
+ reverter (35732)
+ todo (30306)
+ utilsplugin2 (35833)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/CEVNI_MapCSS.mapcss
- https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT1_Seamark.mapcss

[nkamapper]

I do not think I have ever needed to pick a full directory. Could there be a preference parameter to use the traditional Mac file selection dialog?

[taylor.smock]

Replying to nkamapper:

I do not think I have ever needed to pick a full directory. Could there be a preference parameter to use the traditional Mac file selection dialog?

Perhaps. I'll put it on my things to look into. I'd prefer to see ​https://bugs.openjdk.java.net/browse/JDK-7125172 get fixed.

[nkamapper]

One more thing: There is no way to search for a file in the new window, which is now a big problem when there are hundreds of files in a directory.

[Don-vip]

Closed as duplicate of #10024.

[Don-vip]

There is an option for this in the UI for 7 years now.

[nkamapper]

Replying to Don-vip:

There is an option for this in the UI for 7 years now.

Thanks. If you mean use.native.file.dialog, it dot not work. The dialog is the same regardless of true/false.

Somehow this changed between 18193 and 18303.

[taylor.smock]

Add check in OpenFileAction for FileChooserManager.PROP_USE_NATIVE_FILE_DIALOG -- doCreateFileChooser only uses it if the native file chooser also supports the selection mode.

[Don-vip]

OK that's a side-effect regression of r18238.

[Don-vip]

In 18314/josm:

fix #21497 - see #21344 - don't use FILES_AND_DIRECTORIES selection mode if user chose native file dialogs (patch by taylor.smock)

[Don-vip]

Milestone renamed