Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21344 closed enhancement (fixed)

[PATCH] Allow opening a directory tree of pictures in JOSM

Reported by: marcello@… Owned by: Don-vip
Priority: normal Milestone: 21.10
Component: Core Version:
Keywords: Cc:

Description (last modified by taylor.smock)

JOSM should allow users to open multiple directories of images. The attached patch does affect other file types.

Old bug report description

Mapillary "Import Pictures" does not honor exif orientation
When importing images with File | Import Pictures | All Images in a Directory all portrait images are rotated. Importing the same pictures with File | Open ... all portrait pictures are right.

Attachments (4)

Screenshot from 2021-09-19 13-53-40.png (889.0 KB ) - added by marcello@… 3 years ago.
21344.patch (1008 bytes ) - added by taylor.smock 3 years ago.
Allow directories of images or other files to be opened in JOSM
Screen Shot 2021-09-20 at 7.40.01 AM.png (149.1 KB ) - added by taylor.smock 3 years ago.
Java Swing File Picker
Screen Shot 2021-09-20 at 7.44.18 AM.png (235.7 KB ) - added by taylor.smock 3 years ago.
Mac OS X Native File Picker

Download all attachments as: .zip

Change History (15)

by marcello@…, 3 years ago

comment:1 by taylor.smock, 3 years ago

As an FYI, the import functionality in the Mapillary plugin is a candidate for removal.

The only reason it still exists is for 360 image support, which I've been working on moving into JOSM core. Once that happens, the import functionality will be removed.

comment:2 by marcello@…, 3 years ago

That's bad because it is the only way to import a directory tree of pictures into JOSM. File | Open ... does only one directory at a time. I guess that's another ticket then.

comment:3 by taylor.smock, 3 years ago

My long term intent is to move as much stuff as possible into JOSM core that is not directly related to Mapillary (as in, it requires the Mapillary API) so that other plugins (e.g., MS StreetSide, KartaView, etc.) can reuse code, so if there is something in Mapillary not directly related to the Mapillary API, please let me know so I can look into moving it to JOSM core.

Last edited 3 years ago by taylor.smock (previous) (diff)

in reply to:  2 comment:4 by taylor.smock, 3 years ago

Replying to marcello@…:

That's bad because it is the only way to import a directory tree of pictures into JOSM. File | Open ... does only one directory at a time. I guess that's another ticket then.

It turns out to be a fairly simple change.

The only problem is that the native file choosers may not support it, so we get the uglier Java Swing File picker.

Java Swing File PickerMac OS X Native File Picker

Last edited 3 years ago by taylor.smock (previous) (diff)

by taylor.smock, 3 years ago

Attachment: 21344.patch added

Allow directories of images or other files to be opened in JOSM

by taylor.smock, 3 years ago

Java Swing File Picker

by taylor.smock, 3 years ago

Mac OS X Native File Picker

comment:5 by taylor.smock, 3 years ago

@marcello: I'm OK with moving to the uglier, but more functional Java Swing Picker for JOSM. Will that work for you?

Last edited 3 years ago by taylor.smock (previous) (diff)

comment:6 by marcello@…, 3 years ago

that's ok with me

comment:7 by taylor.smock, 3 years ago

Component: Plugin mapillaryCore
Description: modified (diff)
Keywords: mapillary exif orientation removed
Owner: changed from taylor.smock to team
Summary: Mapillary "Import Pictures" does not honor exif orientation[PATCH] Allow opening a directory tree of pictures in JOSM
Type: defectenhancement

comment:8 by Don-vip, 3 years ago

Milestone: 21.09
Owner: changed from team to Don-vip
Status: newassigned

comment:9 by Don-vip, 3 years ago

Resolution: fixed
Status: assignedclosed

In 18238/josm:

fix #21344 - Allow directories of images or other files to be opened in JOSM (patch by taylor.smock)

comment:10 by Don-vip, 3 years ago

Milestone: 21.0921.10

Milestone renamed

comment:11 by Don-vip, 3 years ago

In 18314/josm:

fix #21497 - see #21344 - don't use FILES_AND_DIRECTORIES selection mode if user chose native file dialogs (patch by taylor.smock)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.