[Patch] Add preset "layer" to preset "railway"

[tomasmarklund]

Add preset "layer" to "railway" preset dialog, in the same way as "layer" is available in all the highway preset dialogs.

It would increase speed and quality if both "bridge" tickbox and "layer" dropdown were available in the railway preset. Now, only the bridge tickbox is available, and the layer tag needs to either be added manually, or by opening the "bridge" preset after closing the railway preset.

[skyper]

+1, makes perfectly sense to always offer layer=* with bridge=* and/or tunnel=*

[skyper]

Another option would be replacing the checks for tunnel and bridge with preset_links to Tunnel resp. Bridge preset for all *ways. These links can be placed everywhere in the preset and not only on the bottom but they use quite a lot of space as one occupies a complete row.

[skyper]

patch

[skyper]

Find attached patch​:

• adds layer=* to railways and man_made=conveyor
• adds bridge subtags to man_made=bridge and type=bridge
• adds default layer value to some bridge and tunnel presets

On the fly I fixed indention of one preset.

[Don-vip]

In 18279/josm:

fix #21426 - Add preset "layer" to preset "railway" (patch by skyper)

• adds layer=* to railways and man_made=conveyor
• adds bridge subtags to man_made=bridge and type=bridge
• adds default layer value to some bridge and tunnel presets

[Famlam]

layer=0 (added to the presets) would result in unnecessary tag warnings
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/unnecessary.mapcss#L5

Maybe the patch should only suggest to add 5,4,3,2,1,-1,-2,-3,-4,-5?

[skyper]

Well, again, I just copied the layer combo but you are right that it is strange to first offer the value and than warn about it. New ticket?

[Famlam]

Replying to skyper:

Well, again, I just copied the layer combo but you are right that it is strange to first offer the value and than warn about it. New ticket?

Done #21447

[riiga_92@…]

It seems layer=-1 is being set by default for the "Bridge outline" preset. Looks like a copy-paste error, should probably be changed to layer=1.

Line 6182 in [18279].

[skyper]

Replying to riiga_92@…:

It seems layer=-1 is being set by default for the "Bridge outline" preset. Looks like a copy-paste error, should probably be changed to layer=1.

Line 6182 in [18279].

Yes, of course, see #21610

[Klumbumbus]

In 18326/josm:

fix #21447, fix #21610, see #21426 - remove layer=0 from presets and fix default layer=-1 to layer=1 for man_made=bridge (patch by skyper)