[Patch] Update power plant related preset

[skyper]

I split this of #21396 where plant:method is one part.
I see some possible improvements:

• add icons to values of plant:source using the icons for generator:source
  • changing the combo into a multiselect?
• add power:method
  • This probably leads to own presets per plant:source as only some methods are valid for each source
    • Do we find different icons and/or should we use different background colors per source?

• add new preset for ​power=heliostat

Some validator warnings might be useful, see #21399

[skyper]

Ok, I found an icon for heliostat but I fear I cannot hide a general preset, atm, see my comment 7 on #20843.

[skyper]

reworked heliostat icon to be placed under presets/power/; own work

[skyper]

patch

[skyper]

Ok, I reworked my own icon a bit:

Please, find attached josm_21396.patch​ which:

• adds power=heliostat to preset and style
• adds a new group for power=plant with a general preset and one for each plant:source
  • multiselect with icons plant:source for general preset but no plant:method
  • correct plant:method per plant:source in individual plant presets
• match="none" to generator:method with only one value in power:generator presets, to have working presets links without generator:method
  • I moved the wiki links of power:generator up, to follow common practice.

I was not able to hide the general preset with match_expression="" but I do not like to add plant:method to the general preset as values depend on the plant:source.
Some wiki pages for values of plant:source are not written, yet, so I used the power plan page form them.
Regarding icons, I use the same icon for all presets and I think different background is possible but different icons per source would be much nicer.

Please, test. Comments welcome.

[Don-vip]

In 18264/josm:

fix #21398 - Update power plant related preset (patch by skyper)

• add power=heliostat to preset and style
• add a new group for power=plant with a general preset and one for each plant:source
  • multiselect with icons plant:source for general preset but no plant:method
  • correct plant:method per plant:source in individual plant presets
• match="none" to generator:method with only one value in power:generator presets, to have working presets links without generator:method
  • move the wiki links of power:generator up, to follow common practice.

[Don-vip]

In 18268/josm:

see #21398 - fix typo

[Don-vip]

Milestone renamed

[skyper]

working match_expression

[skyper]

Heureka, I got the match_expression to work: josm_21398_match_expression.patch​

[francois.lacombe]

Hello Skpyer

As always it's great work what is done here, thank you.

It's a detail but I'm not sure it's ok to make plant:source as a multiselect. It's pretty always a single value which is expected here.
​https://taginfo.openstreetmap.org/keys/plant%3Asource#values

The same for generator:source, generator:method and generator:type

Ok for icons anyway.

All the best

[skyper]

I found some plants in the wild with multiple sources and it is written in the wiki that multiple values are valid. Therefore I used a multiselect but not for method. With working match_expression, there will always be only one preset link.

Do you fear, users will add too many or wrong sources with the multiselect? I like to give the user the option and information that multiple values are allowed but I can change it back to a combo if you think it is saver.

[gaben]

Multiple plant sources are okay. See for example ​District heating. There is even a gif where the sources are listed. Also, in our city, geothermal energy and gas are used in conjunction in these plants. It may be the minority, but correct.

[skyper]

new icons derived from existing plant icon

[skyper]

update v2: adds icons with background color for source

[skyper]

Ok, I spend my time with icons and added different background colors per source for the power plants. Additionally the power source icons source code looked strange and I cleaned it up. See update v2​ plus new icons​.

We can usually save 25-75% of image file size by using plain svg and cleaning up the source code by removing unused objects/paths. I do not know if this makes a difference in performance, though.

[skyper]

New icons are in separate file​.

[francois.lacombe]

Indeed I mistaken a bit about plant:source by looking at big plants only. It's ok with multiple values.

With #21399 we'll be able to check consistency between plant source and generators.

Icons are fine for me

[skyper]

update v3: adds "generator:plant" to generator presets

[skyper]

As it came up in #21399, the approved generator:plant is missing in defaultpresets. I took the chance and added it to this update: josm_21398_u3.patch​

[Don-vip]

In 18286/josm:

fix #21398 - Update power plant related preset (patch by skyper)

[Don-vip]

Thanks!