Modify ↓

Opened 3 years ago

Closed 3 years ago

#21190 closed defect (fixed)

Source JAR for r18118 doesn't contain svgSalamander source

Reported by: sebastic Owned by: Don-vip
Priority: normal Milestone: 21.08
Component: Core Version: tested
Keywords: Cc:

Description (last modified by Don-vip)

The source JAR for r18118 doesn't contain svgSalamander source, it contains the .class files instead of .java files:

$ find src/com/kitfox/svg/ -name "*.class" | wc -l
190
$ find src/com/kitfox/svg/ -name "*.java" | wc -l
0

The source JAR in Maven Central does contain the sources:

$ jar tvf /tmp/svgSalamander-1.1.2.4-sources.jar | grep java$ | head
 11463 Sun Nov 15 16:51:48 CET 2020 com/kitfox/svg/Marker.java
  2701 Sun Nov 15 16:51:48 CET 2020 com/kitfox/svg/Defs.java
  5053 Sun Nov 15 16:51:48 CET 2020 com/kitfox/svg/Polyline.java
  4644 Sun Nov 15 16:51:48 CET 2020 com/kitfox/svg/animation/AnimateColor.java
 16499 Sun Nov 15 16:51:48 CET 2020 com/kitfox/svg/animation/AnimationElement.java
  3896 Sun Nov 15 16:51:48 CET 2020 com/kitfox/svg/animation/TrackPath.java
  2084 Sun Nov 15 16:51:48 CET 2020 com/kitfox/svg/animation/TimeIndefinite.java
  3003 Sun Nov 15 16:51:48 CET 2020 com/kitfox/svg/animation/TimeCompound.java
  4338 Sun Nov 15 16:51:48 CET 2020 com/kitfox/svg/animation/TrackBase.java
  2738 Sun Nov 15 16:51:48 CET 2020 com/kitfox/svg/animation/TimeLookup.java

The problem seems to be in the Ivy configuration, and likely needs this change to fix it:

  • ivy.xml 

    diff --git a/ivy.xml b/ivy.xml
index 23646568f..d6fa0b323 100644
    a b  
    4343        <dependency conf="sources->sources" org="org.tukaani" name="xz" rev="1.9"/>
    4444        <dependency conf="sources->sources" org="com.adobe.xmp" name="xmpcore" rev="6.1.11"/>
    4545        <dependency conf="sources->sources" org="com.drewnoakes" name="metadata-extractor" rev="2.16.0" transitive="false"/>
    46         <dependency conf="sources->default" org="com.formdev" name="svgSalamander" rev="1.1.2.4"/>
     46        <dependency conf="sources->sources" org="com.formdev" name="svgSalamander" rev="1.1.2.4"/>
    4747        <dependency conf="sources->sources" org="ch.poole" name="OpeningHoursParser" rev="0.24.0"/>
    4848        <dependency conf="sources->sources" org="oauth.signpost" name="signpost-core" rev="2.1.1"/>
    4949        <dependency conf="sources->default" org="org.webjars.npm" name="tag2link" rev="2021.3.21"/><!-- sources->default sic! (tag2link-sources.jar is empty, see #19335) -->

Attachments (0)

Change History (4)

comment:1 by sebastic, 3 years ago

Description: modified (diff)

comment:2 by Don-vip, 3 years ago

Description: modified (diff)

comment:3 by Don-vip, 3 years ago

Owner: changed from team to Don-vip
Status: new → assigned

ah, stupid copy/paste mistake, thanks.

comment:4 by Don-vip, 3 years ago

Resolution: → fixed
Status: assigned → closed

In 18119/josm:

see #16868 - fix #21190 - include svgSalamander sources correctly

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.