Modify ↓
#16868 closed enhancement (fixed)
Move svgSalamander out of JOSM
Reported by: | michael2402 | Owned by: | Don-vip |
---|---|---|---|
Priority: | normal | Milestone: | 21.07 |
Component: | Core | Version: | |
Keywords: | hack-weekend-2018-10 maven ivy dependency svg svgsalamander | Cc: | DevCharly, simon04 |
Description
The current problem with this is that we often apply our own fixes / quickfixes and that svgSalamander does not provide a maintained maven repository.
After setting up our git server:
- Clone the main svgSalamander repository
- Apply our patches (if we need to, currently they are in sync)
- Create a branch for our changes (for easier tracking them)
- Add a small gradle build script on our that includes the maven publish task
- Set up our CI to run the publish to our maven server on every commit to that branch.
- Change JOSM to use the maven dependency (using ivy for now)
Afterwards, syncing with upstream svgSalamander is easier.
Attachments (0)
Change History (9)
comment:1 by , 5 years ago
Keywords: | hack-weekend-2018-10 maven ivy dependency added |
---|
comment:2 by , 5 years ago
Keywords: | svg svgsalamander added |
---|
comment:3 by , 3 years ago
Cc: | added |
---|---|
Milestone: | → 21.07 |
comment:4 by , 3 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:7 by , 3 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
dist-optimized fails with references to an SVG ant task we should not include
dist-optimized: [proguard] ProGuard, version 7.1.0-beta3 [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find superclass or interface org.apache.tools.ant.Task [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.Task [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced method 'void log(java.lang.String)' in program class com.kitfox.svg.app.ant.SVGToImageAntTask [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.types.FileSet [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced method 'org.apache.tools.ant.Project getProject()' in program class com.kitfox.svg.app.ant.SVGToImageAntTask [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.types.FileSet [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.FileScanner [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.FileScanner [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.BuildException [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.BuildException [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.Task [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.types.FileSet [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.FileScanner [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.FileScanner [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.types.FileSet [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.types.FileSet [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.types.FileSet [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.FileScanner [proguard] Warning: com.kitfox.svg.app.ant.SVGToImageAntTask: can't find referenced class org.apache.tools.ant.types.FileSet [proguard] Warning: there were 17 unresolved references to classes or interfaces. [proguard] You may need to add missing library jars or update their versions. [proguard] If your code works fine without the missing classes, you can suppress [proguard] the warnings with '-dontwarn' options. [proguard] (https://www.guardsquare.com/proguard/manual/troubleshooting#unresolvedclass) [proguard] Warning: there were 2 unresolved references to program class members. [proguard] Your input classes appear to be inconsistent. [proguard] You may need to recompile the code. [proguard] (https://www.guardsquare.com/proguard/manual/troubleshooting#unresolvedprogramclassmember)
Note:
See TracTickets
for help on using tickets.
There is now a fork maintained by DevCharly with releases available on Maven Central, so we can finally get rid of the source code copy in our repository:
https://github.com/JFormDesigner/svgSalamander
https://repo1.maven.org/maven2/com/formdev/svgSalamander/