Add/ignore popular tags: attraction=water_slide, designation=public_bridleway/public_footpath, ownership=private, wall=brick/stone, water=ditch/stream

[Don-vip]

Lot of new popular tags to decide:

• ​amenity=events_venue - 10083
• ​attraction=water_slide - 10010
• ​boundary=local_authority - 15486
• ​boundary=marker - 12934
• ​building=government - 10362
• ​cai_scale=E - 10074
• ​designation=public_bridleway - 46576
• ​designation=public_footpath - 219787
• ​location=overhead - 10063
• ​ownership=private - 30376
• ​shelter_type=gazebo - 12986
• ​wall=brick - 20499
• ​wall=stone - 12315
• ​water=ditch - 10363
• ​water=stream - 15471

[skyper]

ownership comes mainly from imports and designation looks like a key almost exclusively used in Great Britain plus already included in Presets/EnglandWalesRightsOfWay. Thus I tend to ignore these tags for now.

The rest could be added to defaultpresets and default style, I guess.

[skyper]

patch adding wall=brick|stone and water=stream|ditch to defaultpresets and some icons for the combo

[skyper]

We need an icon for water_slide which is different to leisure=water_park:

For wall=brick|stone and water=stream|ditch the fix is easy and no style update is needed. Please, find attached patch josm_20835_wall_water.patch​ which additionally adds some icons to the combos.

[skyper]

patch ignoring "ownership" and "designation"

[Don-vip]

In 18032/josm:

see #20835 - add wall=brick|stone, water=stream|ditch, ignore "ownership" and "designation", add some icons in comboboxes (patches by skyper)

[Don-vip]

thanks!

[Don-vip]

In 18033/josm:

see #20835 - add shelter_type=gazebo (needs its own icon), ignore cai_scale, building=government

[Don-vip]

I've done the quick and easy updates. Remaining: those which needs some research/icons/new presets

[skyper]

I am unsure about ​boundary=local_authority as it was not approved (just "in use") and looks like a value for only certain countries.

[Don-vip]

It's widely used in France and emerged from a correct community discussion/consensus. But agreed, it's not worldwide (although I see India followed our proposal). Better to include it in French/Indian specific presets, as the values possible for each country will never be the same.

[Klumbumbus]

In 18090/josm:

see #20835 - Add own icon for shelter_type=gazebo (icon derived from leisure/bandstand.svg, CC0 and PD licensed)

[Klumbumbus]

In 18091/josm:

see #20835 - Enhance location combo boxes (add overhead), remove one unneeded chunk

[Klumbumbus]

In 18092/josm:

see #20835 - Add attraction=water_slide, use icon from leisure=water_park, for leisure=water_park use a new icon instead: ​https://wiki.openstreetmap.org/wiki/File:Swimming-16.svg (PD and CC0 licensed)

[skyper]

patch for amenity=events_venue and boundary=marker. Own icons missing.

[skyper]

josm_20835_presets_without_icons_v2.patch​ covers the last two missing presets, amenity=events_venue and boundary=marker, but lacks icons, so far.

[Klumbumbus]

In 18094/josm:

see #20835 - Add boundary=marker and amenity=events_venue (patch by skyper), icons derived from service/community_centre and landmark/boundary_stone, both PD and CC0 licensed, ignore boundary=local_authority for now

[Klumbumbus]

Replying to Klumbumbus:

In 18094/josm:

... ignore boundary=local_authority for now

I don't know why Jenkins still warns about boundary=local_authority.

[skyper]

Ticket #20079 has been marked as a duplicate of this ticket.

[Don-vip]

Replying to Klumbumbus:
There's an invisible character between : and b:

[Don-vip]

In 18101/josm:

see #20835 - remove invisible U+200B whitespace character

[Don-vip]

In 18102/josm:

see #20835 - ignore healthcare=yes

[Klumbumbus]

Replying to Klumbumbus:
There's an invisible character between : and b:

Thanks!