Modify

Opened 4 years ago

Closed 4 years ago

#20551 closed defect (fixed)

JOSM was frozen, closed using task manager, trying to reopen ot

Reported by: anonymous Owned by: taylor.smock
Priority: normal Milestone:
Component: Plugin mapwithai Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

What is the expected result?

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-28 22:03:23 +0100 (Mon, 28 Dec 2020)
Build-Date:2020-12-30 02:30:55
Revision:17428
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17428 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 126 MB / 247 MB (42 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) Client VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32

Plugins:
+ Mapillary (1.5.36.4)
+ apache-commons (35524)
+ apache-http (35589)
+ buildings_tools
+ fieldpapers (v0.5.0)
+ imagery_offset_db (35640)
+ jna (35662)
+ mapwithai
+ markseen (14)
+ measurement (35640)
+ scripting (30798)
+ terracer
+ utilsplugin2 (35691)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1
- https://github.com/hotosm/HDM-JOSM-style/archive/master.zip
+ https://github.com/osmlab/appledata/archive/josm_paint_inline_validation.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/Highway_Nodes&zip=1
+ https://github.com/MissingMaps/josm_styles/archive/master.zip
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Last errors/warnings:
- 00019.863 W: Region [TMS_BLOCK_v2] : Problem verifying disk.
- 00020.385 E: Failed to locate image 'MapWithAI'
- 00049.311 E: Handled by bug report queue: java.lang.NullPointerException
- 00049.527 E: Handled by bug report queue: java.lang.reflect.InvocationTargetException. Cause: java.lang.NullPointerException



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (16) of main
java.lang.reflect.InvocationTargetException
	at java.awt.EventQueue.invokeAndWait(Unknown Source)
	at java.awt.EventQueue.invokeAndWait(Unknown Source)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:99)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:142)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NullPointerException
	at org.openstreetmap.josm.plugins.mapwithai.io.mapwithai.ESRISourceReader.featureService(ESRISourceReader.java:180)
	at org.openstreetmap.josm.plugins.mapwithai.io.mapwithai.ESRISourceReader.parse(ESRISourceReader.java:123)
	at org.openstreetmap.josm.plugins.mapwithai.io.mapwithai.ESRISourceReader.parse(ESRISourceReader.java:102)
	at org.openstreetmap.josm.plugins.mapwithai.data.mapwithai.MapWithAILayerInfo$DefaultEntryLoader.parseEsri(MapWithAILayerInfo.java:287)
	at org.openstreetmap.josm.plugins.mapwithai.data.mapwithai.MapWithAILayerInfo$DefaultEntryLoader.finish(MapWithAILayerInfo.java:259)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.WaitDispatchSupport$2.run(Unknown Source)
	at java.awt.WaitDispatchSupport$4.run(Unknown Source)
	at java.awt.WaitDispatchSupport$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.awt.WaitDispatchSupport.enter(Unknown Source)
	at java.awt.Dialog.show(Unknown Source)
	at java.awt.Component.show(Unknown Source)
	at java.awt.Component.setVisible(Unknown Source)
	at java.awt.Window.setVisible(Unknown Source)
	at java.awt.Dialog.setVisible(Unknown Source)
	at org.openstreetmap.josm.gui.progress.swing.PleaseWaitProgressMonitor.lambda$doBeginTask$3(PleaseWaitProgressMonitor.java:255)
	at org.openstreetmap.josm.gui.progress.swing.PleaseWaitProgressMonitor.lambda$doInEDT$0(PleaseWaitProgressMonitor.java:113)
	at java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

=== RUNNING THREADS ===
Thread: Thread-4 (20) of main
sun.nio.fs.WindowsNativeDispatcher.GetQueuedCompletionStatus0(Native Method)
sun.nio.fs.WindowsNativeDispatcher.GetQueuedCompletionStatus(Unknown Source)
sun.nio.fs.WindowsWatchService$Poller.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Thread: main-worker-0 (15) of main
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.locks.LockSupport.park(Unknown Source)
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(Unknown Source)
java.util.concurrent.LinkedBlockingQueue.take(Unknown Source)
java.util.concurrent.ThreadPoolExecutor.getTask(Unknown Source)
java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Thread: Signal Dispatcher (4) of system

Thread: Finalizer (3) of system
java.lang.Object.wait(Native Method)
java.lang.ref.ReferenceQueue.remove(Unknown Source)
java.lang.ref.ReferenceQueue.remove(Unknown Source)
java.lang.ref.Finalizer$FinalizerThread.run(Unknown Source)

Thread: JOSM version checker (53)
java.net.DualStackPlainSocketImpl.waitForConnect(Native Method)
java.net.DualStackPlainSocketImpl.socketConnect(Unknown Source)
java.net.AbstractPlainSocketImpl.doConnect(Unknown Source)
java.net.AbstractPlainSocketImpl.connectToAddress(Unknown Source)
java.net.AbstractPlainSocketImpl.connect(Unknown Source)
java.net.PlainSocketImpl.connect(Unknown Source)
java.net.SocksSocketImpl.connect(Unknown Source)
java.net.Socket.connect(Unknown Source)
sun.security.ssl.SSLSocketImpl.connect(Unknown Source)
sun.net.NetworkClient.doConnect(Unknown Source)
sun.net.www.http.HttpClient.openServer(Unknown Source)
sun.net.www.http.HttpClient.openServer(Unknown Source)
sun.net.www.protocol.https.HttpsClient.<init>(Unknown Source)
sun.net.www.protocol.https.HttpsClient.New(Unknown Source)
sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.getNewHttpClient(Unknown Source)
sun.net.www.protocol.http.HttpURLConnection.plainConnect0(Unknown Source)
sun.net.www.protocol.http.HttpURLConnection.plainConnect(Unknown Source)
sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(Unknown Source)
sun.net.www.protocol.https.HttpsURLConnectionImpl.connect(Unknown Source)
org.openstreetmap.josm.tools.Http1Client.performConnection(Http1Client.java:78)
org.openstreetmap.josm.tools.HttpClient.connect(HttpClient.java:148)
org.openstreetmap.josm.tools.HttpClient.connect(HttpClient.java:124)
org.openstreetmap.josm.io.CachedFile.checkLocal(CachedFile.java:498)
org.openstreetmap.josm.io.CachedFile.getFile(CachedFile.java:284)
org.openstreetmap.josm.io.CachedFile.getInputStream(CachedFile.java:227)
org.openstreetmap.josm.io.CachedFile.getByteContent(CachedFile.java:245)
org.openstreetmap.josm.gui.bugreport.JosmUpdatePanel.getTestedVersion(JosmUpdatePanel.java:70)
org.openstreetmap.josm.gui.bugreport.JosmUpdatePanel.readCurrentVersion(JosmUpdatePanel.java:53)
org.openstreetmap.josm.gui.bugreport.JosmUpdatePanel$$Lambda$536/26201733.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Thread: AWT-EventQueue-0 (16) of main
Stacktrace see above.

Thread: AWT-Windows (13) of system
sun.awt.windows.WToolkit.eventLoop(Native Method)
sun.awt.windows.WToolkit.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Thread: AWT-Shutdown (17) of system
java.lang.Object.wait(Native Method)
java.lang.Object.wait(Unknown Source)
sun.awt.AWTAutoShutdown.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Thread: Timer-0 (38) of main
java.lang.Object.wait(Native Method)
java.util.TimerThread.mainLoop(Unknown Source)
java.util.TimerThread.run(Unknown Source)

Thread: JCS-ElementEventQueue-Thread-7 (37) of main
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.locks.LockSupport.park(Unknown Source)
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(Unknown Source)
java.util.concurrent.LinkedBlockingQueue.take(Unknown Source)
java.util.concurrent.ThreadPoolExecutor.getTask(Unknown Source)
java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Thread: Reference Handler (2) of system
java.lang.Object.wait(Native Method)
java.lang.Object.wait(Unknown Source)
java.lang.ref.Reference.tryHandlePending(Unknown Source)
java.lang.ref.Reference$ReferenceHandler.run(Unknown Source)

Thread: Java2D Disposer (10) of system
java.lang.Object.wait(Native Method)
java.lang.ref.ReferenceQueue.remove(Unknown Source)
java.lang.ref.ReferenceQueue.remove(Unknown Source)
sun.java2d.Disposer.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Thread: main (1) of main
java.lang.Thread.sleep(Native Method)
org.openstreetmap.josm.plugins.mapwithai.data.mapwithai.MapWithAILayerInfo.getInstance(MapWithAILayerInfo.java:86)
org.openstreetmap.josm.plugins.mapwithai.gui.preferences.mapwithai.MapWithAILayerTableModel.getRowCount(MapWithAILayerTableModel.java:53)
javax.swing.table.DefaultTableModel.setDataVector(Unknown Source)
javax.swing.table.DefaultTableModel.<init>(Unknown Source)
javax.swing.table.DefaultTableModel.<init>(Unknown Source)
javax.swing.table.DefaultTableModel.<init>(Unknown Source)
org.openstreetmap.josm.plugins.mapwithai.gui.preferences.mapwithai.MapWithAILayerTableModel.<init>(MapWithAILayerTableModel.java:20)
org.openstreetmap.josm.plugins.mapwithai.gui.preferences.mapwithai.MapWithAIProvidersPanel.<clinit>(MapWithAIProvidersPanel.java:109)
org.openstreetmap.josm.plugins.mapwithai.gui.download.MapWithAIDownloadOptions.<init>(MapWithAIDownloadOptions.java:40)
org.openstreetmap.josm.plugins.mapwithai.MapWithAIPlugin.<init>(MapWithAIPlugin.java:120)
sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
java.lang.reflect.Constructor.newInstance(Unknown Source)
org.openstreetmap.josm.plugins.PluginInformation.load(PluginInformation.java:362)
org.openstreetmap.josm.plugins.PluginHandler.loadPlugin(PluginHandler.java:803)
org.openstreetmap.josm.plugins.PluginHandler.loadPlugins(PluginHandler.java:889)
org.openstreetmap.josm.plugins.PluginHandler.loadLatePlugins(PluginHandler.java:941)
org.openstreetmap.josm.gui.MainApplication.loadLatePlugins(MainApplication.java:1158)
org.openstreetmap.josm.gui.MainApplication.mainJOSM(MainApplication.java:922)
org.openstreetmap.josm.gui.MainApplication$3.processArguments(MainApplication.java:277)
org.openstreetmap.josm.gui.MainApplication.main(MainApplication.java:714)

Thread: bug-report-display (51) of main
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.locks.LockSupport.park(Unknown Source)
java.util.concurrent.FutureTask.awaitDone(Unknown Source)
java.util.concurrent.FutureTask.get(Unknown Source)
org.openstreetmap.josm.gui.util.GuiHelper.runInEDTAndWaitAndReturn(GuiHelper.java:277)
org.openstreetmap.josm.gui.bugreport.BugReportDialog.showFor(BugReportDialog.java:233)
org.openstreetmap.josm.gui.MainApplication$$Lambda$16/1263764.handle(Unknown Source)
org.openstreetmap.josm.tools.bugreport.BugReportQueue.displayFor(BugReportQueue.java:134)
org.openstreetmap.josm.tools.bugreport.BugReportQueue.access$200(BugReportQueue.java:17)
org.openstreetmap.josm.tools.bugreport.BugReportQueue$BugReportDisplayRunnable.run(BugReportQueue.java:100)
java.lang.Thread.run(Unknown Source)

Thread: TimerQueue (18) of system
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.locks.LockSupport.park(Unknown Source)
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(Unknown Source)
java.util.concurrent.DelayQueue.take(Unknown Source)
javax.swing.TimerQueue.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Thread: Weak reference cleaner (22) of main
java.lang.Object.wait(Native Method)
java.lang.ref.ReferenceQueue.remove(Unknown Source)
java.lang.ref.ReferenceQueue.remove(Unknown Source)
org.openstreetmap.josm.tools.ListenableWeakReference.clean(ListenableWeakReference.java:60)
org.openstreetmap.josm.tools.ListenableWeakReference$$Lambda$192/30609508.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Thread: Keep-Alive-Timer (50) of system
java.lang.Thread.sleep(Native Method)
sun.net.www.http.KeepAliveCache.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Thread: Attach Listener (5) of system

Thread: File Watcher (21) of main
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.locks.LockSupport.park(Unknown Source)
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(Unknown Source)
java.util.concurrent.LinkedBlockingDeque.takeFirst(Unknown Source)
java.util.concurrent.LinkedBlockingDeque.take(Unknown Source)
sun.nio.fs.AbstractWatchService.take(Unknown Source)
org.openstreetmap.josm.io.FileWatcher.processEvents(FileWatcher.java:120)
org.openstreetmap.josm.io.FileWatcher$$Lambda$155/5594634.run(Unknown Source)
java.lang.Thread.run(Unknown Source)

Attachments (0)

Change History (6)

in reply to:  description comment:1 by skyper, 4 years ago

Component: CorePlugin mapwithai
Owner: changed from team to taylor.smock

Replying to anonymous:

Memory Usage: 126 MB / 247 MB (42 MB allocated, but free)

I am not sure if all you plugins are happy with such small amount of memory.

comment:2 by skyper, 4 years ago

Ticket #20553 has been marked as a duplicate of this ticket.

comment:3 by skyper, 4 years ago

Ticket #20552 has been marked as a duplicate of this ticket.

in reply to:  description comment:4 by skyper, 4 years ago

Replying to anonymous:

Last errors/warnings:
- 00019.863 W: Region [TMS_BLOCK_v2] : Problem verifying disk.
- 00020.385 E: Failed to locate image 'MapWithAI'

Not enough disk space for download/caching could be another reason.

comment:5 by taylor.smock, 4 years ago

Replying to comment 1:

Memory Usage: 126 MB / 247 MB (42 MB allocated, but free)

I am not sure if all you plugins are happy with such small amount of memory.

I'm trying to be more conscious of memory usage, but I've never focused on improving it (i.e., can I use a byte instead of an int, etc.), and I usually (for MapWithAI) store stuff in the JOSM DataSet class.

But this looks like a more standard NPE.

Caused by: java.lang.NullPointerException
	at org.openstreetmap.josm.plugins.mapwithai.io.mapwithai.ESRISourceReader.featureService(ESRISourceReader.java:180)

Anyway, the only plugins I've written from the ground up are MapWithAI, OpenQA, highwayNameModification, and there might be one or two others.

But Mapillary isn't one of them (#20550 is probably what made you ask the question). As far as that goes, I'd have to look at why my fix for #20504 is causing this #20550 (my fix for #20550 was setting the queue sizes to the number of images that were being exported).

I'll get a fix for this ticket out soonish. Just adding some == null checks.

Replying to comment 4:

Not enough disk space for download/caching could be another reason.

That could be it. But there is still data downloaded (there are some earlier locations that should throw if no data was downloaded).

comment:6 by taylor.smock, 4 years ago

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain taylor.smock.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.