Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#20526 closed defect (wontfix)

building=yes results in JOSM to add Man Made/Man Made/Building and Man Made/Man Made/Residential Building

Reported by: anonymous Owned by: anonymous
Priority: normal Milestone:
Component: Internal preset Version: latest
Keywords: template_report building Cc: Klumbumbus, simon04

Description

What steps will reproduce the problem?

  1. Any building=yes
  2. 2 new tags show up in the list above the "key=value"
  3. Man Made/Man Made/Building and Man Made/Man Made/Residential Building

What is the expected result?

Man Made/Man Made/Building is correct

What happens instead?

Man Made/Man Made/Building
Man Made/Man Made/Residential Building

The second is an assumption and not correct to assume any non-designated building is residential

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-02-17 22:19:27 +0100 (Wed, 17 Feb 2021)
Build-Date:2021-02-18 02:30:50
Revision:17493
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17493 en) Windows 10 64-Bit
OS Build number: Windows 10 Home Single Language 2004 (19041)
Memory Usage: 815 MB / 1820 MB (475 MB allocated, but free)
Java version: 1.8.0_281-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00) \Display1 3840×2160 (scaling 1.00×1.00)
Maximum Screen Size: 3840×2160
Best cursor sizes: 16×16→32×32, 32×32→32×32
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.37.2)
+ apache-commons (35524)
+ apache-http (35589)
+ jna (35662)

Tagging presets:
+ <josm.pref>\Phillipines_Jeepney\Phillipines_Jeepney.xml

Map paint styles:
- https://github.com/bastik/mapcss-tools/raw/osm/mapnik2mapcss/osm-results/mapnik.zip
- https://josm.openstreetmap.de/josmfile?page=Styles/ColorWays&zip=1
+ %UserProfile%\Documents\elemstyles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/ColourGPSData&zip=1
- https://www.dropbox.com/s/qo3ai47fpv241jf/Styles_Fixme_and_Notes.zip?raw=1

Last errors/warnings:
- 00319.935 E: Failed to locate image 'object--wire-group'
- 00320.037 E: Failed to locate image 'regulatory--dual-lanes-cyclists-and-pedestrians--g1'
- 00320.907 E: Failed to locate image 'regulatory--texts--g1'
- 00320.908 E: Failed to locate image 'regulatory--texts--g2'
- 00321.002 E: Failed to locate image 'void--car-mount'
- 00321.003 E: Failed to locate image 'void--dynamic'
- 00321.003 E: Failed to locate image 'void--ego-vehicle'
- 00321.004 E: Failed to locate image 'void--ground'
- 00321.005 E: Failed to locate image 'void--static'
- 00321.188 E: Failed to locate image 'warning--kangaroo-crossing--g1'

Attachments (0)

Change History (11)

comment:1 by skyper, 4 years ago

Component: CoreInternal preset
Keywords: building added

comment:2 by Don-vip, 4 years ago

Cc: Klumbumbus simon04 added

yes has been added on purpose 5 years ago in r9392 (#12320).

comment:3 by skyper, 4 years ago

See also #19642.

comment:4 by Klumbumbus, 4 years ago

Yes this is by design to be able to access both building presets from the Tags/Membership panel (i.e. change a building=yes to some kind of residential building). Unless someone has a better idea to solve this I guess this is a wontfix.

comment:5 by Klumbumbus, 4 years ago

Owner: changed from team to anonymous
Status: newneedinfo

comment:6 by Klumbumbus, 4 years ago

Owner: changed from anonymous to team
Status: needinfonew

comment:7 by Klumbumbus, 4 years ago

Owner: changed from team to anonymous
Status: newneedinfo

(Hm, it seems needinfo state with owner team is not possible in trac)

comment:8 by skyper, 4 years ago

With the enhancement to match complete regex, match_expression="..." (#19012), it might be possible to solve this problem. At least I hope so, as this was one reason to ask for a complete filter option for match.

in reply to:  4 comment:9 by skyper, 4 years ago

Replying to Klumbumbus:

Yes this is by design to be able to access both building presets from the Tags/Membership panel (i.e. change a building=yes to some kind of residential building). Unless someone has a better idea to solve this I guess this is a wontfix.

Removing the value yes from the value list of residential building, should work now, but that does not solve the cheat with the two preset links in the panel. Why does building=* deserve a special treatment? Can we solve this with presetlinks from the general building presets to the categories?

comment:10 by Klumbumbus, 4 years ago

Resolution: wontfix
Status: needinfoclosed

see comment:4

comment:11 by skyper, 4 years ago

One question remains: Why is this hack only used for residential buildings?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain anonymous.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.