Building "Man Made/Man Made/Building..." preset removed when using civic values

[dr.kludge.gm@…]

Simple test
1.) Create a node
2.) Add a building key with a value from civic group ​http://wiki.openstreetmap.org/wiki/Key:building#Civic.2FAmenity
I first noticed the problem with church or chapel. Public, civic, stadium also cause the preset link to drop out. Note all civic building values create this issue such as hospital. I would think that the civic group would behave like the rest of the Man Made/Man Made Building list. Josm 9329 is the first time that I noticed the special residential treatment. I don't know if this is related. It looks like some of the building values were not included in the presets with the 9329 release. Finally, building=church does not generate the validator "not in presets" warning.

[Klumbumbus]

In the last months no value for the building key was removed from the internal preset. However some were added or added to the ignore list (so they do not appear in the "not in presets" warning), see #12135.

Note that in the drop dow list of a preset there are only the predefined values of that special preset, while the autocompletion uses all values from the whole presetfile an additional all values, which are in the currently downloaded dataset.

Please describe more precise what the problem is, because I don't really understand your text :)

[simon04]

Also, please follow the instructions at newticket – we do not require this information for nothing!

[dr.kludge.gm@…]

Step !

[dr.kludge.gm@…]

Step two there are missing values in the list of valued build value mostly in the civil section.

[dr.kludge.gm@…]

Step three change to church, the click apply.

[dr.kludge.gm@…]

There is no preset link to pull up the preset. I circle church once and circled the missing area three times. I don't know how to make this any easier.

[anonymous]

Umm... I don't know how I could have made this any simpler to reproduce. It feels like you did not read my enumerated steps in the original ticket as I provided you one missing value and gave you a link to the wiki page where there is a section of missing values. So this time I added images with the ticket and number plus a sequence number in the file name. The second image, ticket_12320_2_building_list_of_values.png, shows where the missing values should be expected. In this case, I started with yes. Note how most of the church kind-of values are not listed. There's no civic or stadium in the list either. Please see ​http://wiki.openstreetmap.org/wiki/Key:building#Civic.2FAmenity After church was set, *3*.png, look at *4*.png file. There are no preset links as are normally the case. The expectation is that I would see a link to a building preset. Please also read the file descriptions to explanations. I also circled where the missing link is at. Finally, I don't know when the problem occurred. However, with the 9329 release I noticed that a new preset box was enabled for residential values. The problem could have occurred with this release or some other release.

[simon04]

This ticket still lacks the required information mentioned in newticket (status report)

[dr.kludge.gm@…]

What steps will reproduce the problem?

1. Perform Attachment ticket_12320_1_building_yes.png​
2. Perform Attachment ticket_12320_2_building_list_of_values.png​
3. Perform Attachment ticket_12320_3_building_church.png​
4. Perform Attachment ticket_12320_4_no_preset_link.png​

What is the expected result?

I should see a link to the building presets. See Attachment ticket_12320_4_no_preset_link.png​ There is no preset link to pull up the building preset. I circle building=church tag entry once and circled the missing area three times. I don't know how to make this any easier.

What happens instead?

I do not see any preset links about the tab/value entry box. All of the preset links are removed for a valid building tag.

Please provide any additional information below. Attach a screenshot if possible.

Four screen shots area attached.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-01-06 17:30:31 +0100 (Wed, 06 Jan 2016)
Build-Date:2016-01-06 16:32:31
Revision:9329
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9329 en) Windows 7 64-Bit
Memory Usage: 998 MB / 998 MB (868 MB allocated, but free)
Java version: 1.8.0_31, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-XX:InitialCodeCacheSize=3M, -XX:ReservedCodeCacheSize=12M, -XX:NumberOfGCLogFiles=10, -XX:GCLogFileSize=8K, -Djosm.home=\gis\apps\josm, -Djosm.pref=\gis\apps\josm, -Djosm.cache=\gis\data\josm_temp, -Djosm.userdata=\gis\apps\josm\data_files]

Plugins:
- ColorPlugin (1414145445)
- CommandLine (31927)
- Create_grid_of_ways (31772)
- DirectDownload (31934)
- DirectUpload (31912)
- DxfImport (1006)
- FastDraw (31895)
- FixAddresses (31772)
- HouseNumberTaggingTool (31772)
- ImageWayPoint (31772)
- ImportImagePlugin (31772)
- ImproveOsm (18)
- Mapillary (31895)
- OpeningHoursEditor (31772)
- PicLayer (31895)
- RoadSigns (31895)
- ShapeTools (1000)
- alignways (31895)
- apache-commons (31895)
- apache-http (31895)
- buildings_tools (31895)
- conflation (0.1.9)
- continuosDownload (1446070193)
- dataimport (31772)
- download_along (31772)
- editgpx (31772)
- ejml (31895)
- ext_tools (31772)
- geotools (31895)
- graphview (31895)
- imageryadjust (31772)
- jna (31877)
- jts (31772)
- junctionchecking (31772)
- kendzi3d-jogl (41)
- lakewalker (31772)
- log4j (31895)
- mbtiles (v2.0)
- measurement (31895)
- namemanager (31772)
- opendata (31937)
- openvisible (31772)
- osmarender (31772)
- pbf (31772)
- pdfimport (31895)
- photo_geotagging (31895)
- photoadjust (31963)
- poly (31772)
- print (31895)
- proj4j (31830)
- public_transport (31895)
- public_transport_layer (31932)
- reltoolbox (31895)
- reverter (31897)
- routes (31772)
- routing (31772)
- scoutsigns (71)
- scripting (30722)
- tageditor (31772)
- tagging-preset-tester (31895)
- todo (29154)
- touchscreenhelper (31772)
- turnlanes (31772)
- turnrestrictions (31895)
- undelete (31895)
- utilsplugin2 (31895)
- walkingpapers (31603)
- waydownloader (31772)
- wikipedia (31917)

Last errors/warnings:
- W:  Railway Crossing: Could not get presets icon styles/standard/vehicle/crossing.png
- E: Failed to locate image 'images/styles/standard/misc/information.png'
- W:  Is In: Could not get presets icon images/styles/standard/misc/information.png
- E: Failed to locate image 'images/styles/standard/misc/information.png'
- W:  Wind Generator: Could not get presets icon images/styles/standard/misc/information.png

[simon04]

Thank you.

To reproduce:

• create node 1, add building=yes
• create node 2, add building=church

Node 1 shows the preset "Man Made/Man Made/Building..." in the tags/membership window, whereas node 2 does not.

At the moment, only the building types explicitly specified in the preset are matched.

[Klumbumbus]

We could add yes to the residential building preset and the place_of_worship building type values (church,cathedral,...) to the building preset.

[Klumbumbus]

In 9392/josm:

fix #12320 - add yes to the residential building preset and the place_of_worship building type values (church,cathedral,...) to the building preset; typo

[Klumbumbus]

In 9393/josm:

see #12320, see #12317 - typo

[Klumbumbus]

dr.kludge., the residential building type values are in an own residential building preset (Presets -> Man Made -> Man Made -> Residential Building). This one is now also linked in the Tags/Membership dialog for buildings with building=yes.

[Klumbumbus]

BTW:

Last errors/warnings:

• W: Railway Crossing: Could not get presets icon styles/standard/vehicle/crossing.png
• E: Failed to locate image 'images/styles/standard/misc/information.png'
• W: Is In: Could not get presets icon images/styles/standard/misc/information.png
• E: Failed to locate image 'images/styles/standard/misc/information.png'
• W: Wind Generator: Could not get presets icon images/styles/standard/misc/information.png

It seems you are using the old mappaint style JOSM default (XML; old version, outdated). You should switch to the current one JOSM default (MapCSS).
Use menu View -> Map Paint Styles or menu Windows -> Map Paint Styles