Preset default text is not applied when element already has any tag

[arminus]

What steps will reproduce the problem?

1. create a preset with at least a text entry like

   <text key="access:conditional" text="access:conditional" default="discouraged @ (Dec-May)" />
   

2. apply the preset to an element/way without any tags
3. apply the preset to an element/way with at least one existing tag (access:conditional does not yet exist in that element)

What is the expected result?

Default text value should be shown in both steps 1 and 2

What happens instead?

In Step 3 nothing is shown for the default text

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-12-28 22:03:23 +0100 (Mon, 28 Dec 2020)
Revision:17428
Build-Date:2020-12-30 02:30:55
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17428 de) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1909 (18363)
Memory Usage: 244 MB / 1024 MB (149 MB allocated, but free)
Java version: 13+33, Oracle Corporation, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1200 (scaling 1,00×1,00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→32×32, 32×32→32×32

Plugins:
+ DirectUpload (35640)
+ OpeningHoursEditor (35640)
+ PicLayer (2a9aa7a)
+ apache-commons (35524)
+ buildings_tools (35669)
+ ejml (35458)
+ geotools (35458)
+ imagery_offset_db (35640)
+ jaxb (35543)
+ jts (35458)
+ measurement (35640)
+ opendata (35640)
+ poly (35640)
+ reverter (35640)
+ utilsplugin2 (35682)

Tagging presets:
+ C:\Data\Development\OSM\ViaFerrataRelationPreset.xml
+ C:\Data\Development\OSM\XCRelationPreset.xml
+ C:\Data\Development\OSM\XCWayPreset.xml
+ C:\Data\Development\OSM\Schongebiet.xml
+ C:\Data\Development\OSM\SchongebietWeg.xml

Last errors/warnings:
- 00009,846 E: Fehler beim Laden des Bildes 'presets/empty.png'
- 00009,846 W:  Via Ferata Relation: Could not get presets icon presets/empty.png
- 00009,846 E: Fehler beim Laden des Bildes 'presets/empty.png'
- 00009,846 W:  XC Relation: Could not get presets icon presets/empty.png
- 00009,862 E: Fehler beim Laden des Bildes 'presets/empty.png'
- 00009,862 W:  XC Way: Could not get presets icon presets/empty.png
- 00009,862 E: Fehler beim Laden des Bildes 'presets/empty.png'
- 00009,862 W:  Schongebiet: Could not get presets icon presets/empty.png
- 00009,862 E: Fehler beim Laden des Bildes 'presets/empty.png'
- 00009,862 W:  SchongebietWeg: Could not get presets icon presets/empty.png

[Don-vip]

Can you please provide the exact preset and an .osm file with the primitive you try to add it?

[skyper]

This is close to the value_template="" (#20861) and as long as match_expression="" is not working 100% (#20843), it could lead to wild combinations.
At least a different text color would be nice. Maybe, it is worth thinking about a preference option to keep current behavior.

[marcello@…]

"What happens instead" is correct and by design. See the discussion and fix in #5564, #12733, and #17324.

IMO the "default" feature is broken by design. We should change it to always write the default even on tagged primitives.